mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-14 08:52:56 +00:00
e9dcfa2eb2
## Problem Running `pytest.skip(...)` in a test body instead of marking the test with `@pytest.mark.skipif(...)` makes all fixtures to be initialised, which is not necessary if the test is going to be skipped anyway. Also, some tests are unnecessarily skipped (e.g. `test_layer_bloating` on Postgres 17, or `test_idle_reconnections` at all) or run (e.g. `test_parse_project_git_version_output_positive` more than on once configuration) according to comments. ## Summary of changes - Move `skip_on_postgres` / `xfail_on_postgres` / `run_only_on_default_postgres` decorators to `fixture.utils` - Add new `skip_in_debug_build` and `skip_on_ci` decorators - Replace `pytest.skip(...)` calls with decorators where possible
63 lines
2.0 KiB
Python
63 lines
2.0 KiB
Python
from __future__ import annotations
|
|
|
|
import enum
|
|
from typing import TYPE_CHECKING
|
|
|
|
from typing_extensions import override
|
|
|
|
if TYPE_CHECKING:
|
|
from typing import Optional
|
|
|
|
|
|
"""
|
|
This fixture is used to determine which version of Postgres to use for tests.
|
|
"""
|
|
|
|
|
|
# Inherit PgVersion from str rather than int to make it easier to pass as a command-line argument
|
|
# TODO: use enum.StrEnum for Python >= 3.11
|
|
class PgVersion(str, enum.Enum):
|
|
V14 = "14"
|
|
V15 = "15"
|
|
V16 = "16"
|
|
V17 = "17"
|
|
|
|
# Default Postgres Version for tests that don't really depend on Postgres itself
|
|
DEFAULT = V16
|
|
|
|
# Instead of making version an optional parameter in methods, we can use this fake entry
|
|
# to explicitly rely on the default server version (could be different from pg_version fixture value)
|
|
NOT_SET = "<-POSTRGRES VERSION IS NOT SET->"
|
|
|
|
# Make it less confusing in logs
|
|
@override
|
|
def __repr__(self) -> str:
|
|
return f"'{self.value}'"
|
|
|
|
# Make this explicit for Python 3.11 compatibility, which changes the behavior of enums
|
|
@override
|
|
def __str__(self) -> str:
|
|
return self.value
|
|
|
|
# In GitHub workflows we use Postgres version with v-prefix (e.g. v14 instead of just 14),
|
|
# sometime we need to do so in tests.
|
|
@property
|
|
def v_prefixed(self) -> str:
|
|
return f"v{self.value}"
|
|
|
|
@classmethod
|
|
@override
|
|
def _missing_(cls, value: object) -> Optional[PgVersion]:
|
|
known_values = {v.value for _, v in cls.__members__.items()}
|
|
|
|
# Allow passing version as a string with "v" prefix (e.g. "v14")
|
|
if isinstance(value, str) and value.lower().startswith("v") and value[1:] in known_values:
|
|
return cls(value[1:])
|
|
# Allow passing version as an int (e.g. 15 or 150002, both will be converted to PgVersion.V15)
|
|
elif isinstance(value, int) and str(value)[:2] in known_values:
|
|
return cls(str(value)[:2])
|
|
|
|
# Make mypy happy
|
|
# See https://github.com/python/mypy/issues/3974
|
|
return None
|