John Khvatov 33cb9a68f7 pageserver: Reduce tracing overhead in timeline::get (#6115) ...

## Problem

Compaction process (specifically the image layer reconstructions part)
is lagging behind wal ingest (at speed ~10-15MB/s) for medium-sized
tenants (30-50GB). CPU profile shows that significant amount of time
(see flamegraph) is being spent in `tracing::span::Span::new`.

mainline (commit: 0ba4cae491):

![reconstruct-mainline-0ba4cae491c2](https://github.com/neondatabase/neon/assets/289788/ebfd262e-5c97-4858-80c7-664a1dbcc59d)

## Summary of changes

By lowering the tracing level in get_value_reconstruct_data and
get_or_maybe_download from info to debug, we can reduce the overhead of
span creation in prod environments. On my system, this sped up the image
reconstruction process by 60% (from 14500 to 23160 page reconstruction
per sec)

pr:

![reconstruct-opt-2](https://github.com/neondatabase/neon/assets/289788/563a159b-8f2f-4300-b0a1-6cd66e7df769)


`create_image_layers()` (it's 1 CPU bound here) mainline vs pr:

![image](https://github.com/neondatabase/neon/assets/289788/a981e3cb-6df9-4882-8a94-95e99c35aa83)

2023-12-18 13:33:23 +00:00

..

data/extension_test/5670669815

Feat/postgres 16 (#4761)

2023-09-12 15:11:32 +02:00

test_ancestor_branch.py

make flush frozen layer an atomic operation (#4720)

2023-07-20 13:39:19 -04:00

test_attach_tenant_config.py

tests: update allow list for negative_env (#6144)

2023-12-15 15:08:28 +00:00

test_auth.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_backpressure.py

Add extension neon to all databases.

2023-11-23 18:53:03 +00:00

test_bad_connection.py

Add test simulating bad connection between pageserver and compute (#5728)

2023-11-08 19:48:57 +00:00

test_basebackup_error.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_branch_and_gc.py

build: back to opt-level=0 in debug builds, for faster compile times (#5751)

2023-11-20 15:41:37 +01:00

test_branch_behind.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_branching.py

pageserver: improved handling of concurrent timeline creations on the same ID (#6139)

2023-12-15 08:51:23 +00:00

test_broken_timeline.py

pageserver: Reduce tracing overhead in timeline::get (#6115)

2023-12-18 13:33:23 +00:00

test_build_info_metric.py

feat: add build_tag env support for set_build_info_metric (#5576)

2023-10-27 10:47:11 +01:00

test_change_pageserver.py

tests: update for tenant generations (#5449)

2023-12-07 12:27:16 +00:00

test_clog_truncate.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_close_fds.py

tests: enable multiple pageservers in neon_local and neon_fixture (#5231)

2023-09-08 16:19:57 +01:00

test_compatibility.py

test_compatibility: make it use initdb.tar.zst

2023-12-13 15:04:25 -06:00

test_config.py

test_runner: use toml instead of formatted strings (#6088)

2023-12-11 15:13:27 +00:00

test_crafted_wal_end.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_createdropdb.py

Add a test case for "CREATE DATABASE STRATEGY=file_copy". (#5301)

2023-09-15 16:50:57 +03:00

test_createuser.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_ddl_forwarding.py

Disallow CREATE DATABASE WITH OWNER neon_superuser (#5887)

2023-11-20 22:39:47 +00:00

test_disk_usage_eviction.py

disk_usage_based_eviction: switch warmup to use full table scans (#5384)

2023-09-27 10:00:21 +01:00

test_download_extensions.py

Use test specific directory in test_remote_extensions (#5938)

2023-11-27 18:57:58 +00:00

test_duplicate_layers.py

tests: update for tenant generations (#5449)

2023-12-07 12:27:16 +00:00

test_fsm_truncate.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_fullbackup.py

test: include cmdline in captured output (#5977)

2023-11-30 17:31:03 +00:00

test_gc_aggressive.py

crash-consistent layer map through index_part.json (#5198)

2023-10-17 10:04:56 +01:00

test_gc_cutoff.py

tests: allow-lists for occasional failures (#6074)

2023-12-08 17:32:16 +00:00

test_hot_standby.py

test_runner: remove excessive timeouts (#4659)

2023-08-09 16:27:53 +01:00

test_import.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_large_schema.py

tests: enable multiple pageservers in neon_local and neon_fixture (#5231)

2023-09-08 16:19:57 +01:00

test_layer_eviction.py

build: back to opt-level=0 in debug builds, for faster compile times (#5751)

2023-11-20 15:41:37 +01:00

test_layer_writers_fail.py

Move tenant & timeline dir method to NeonPageserver and use them everywhere (#5262)

2023-09-15 11:17:18 +01:00

test_layers_from_future.py

tests: update for tenant generations (#5449)

2023-12-07 12:27:16 +00:00

test_lfc_resize.py

Do not handle lfc_change_limit in processes not haing PGPROC structure (#5332)

2023-09-19 21:55:36 +03:00

test_local_file_cache.py

LFC fixes + statistics (#5727)

2023-11-23 08:59:19 +02:00

test_logging.py

add libmetric metric for each logged log message (#4055)

2023-04-25 14:10:18 +02:00

test_logical_replication.py

Do not inherite replication slots in branch (#5898)

2023-12-12 14:24:21 +02:00

test_lsn_mapping.py

find_lsn_for_timestamp fixes (#5844)

2023-11-10 13:38:44 +01:00

test_multixact.py

Mx offset bug (#4775)

2023-07-21 21:20:53 +03:00

test_neon_cli.py

tests: update for tenant generations (#5449)

2023-12-07 12:27:16 +00:00

test_neon_extension.py

Only create neon extension in postgres database; (#5918)

2023-11-26 08:37:01 +00:00

test_neon_local_cli.py

neon_local: fix endpoint api to prevent two primary endpoints (#5520)

2023-11-29 19:38:03 +02:00

test_next_xid.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_normal_work.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_old_request_lsn.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_ondemand_download.py

tests: update tests that used local_fs&mock_s3 to use one or the other (#6015)

2023-12-08 14:52:37 +00:00

test_pageserver_api.py

tests: update for tenant generations (#5449)

2023-12-07 12:27:16 +00:00

test_pageserver_catchup.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_pageserver_generations.py

tests: start adding tests for secondary mode, live migration (#5842)

2023-12-11 16:55:43 +00:00

test_pageserver_metric_collection.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_pageserver_restart.py

concurrency-limit low-priority initial logical size calculation [v2] (#6000)

2023-12-04 17:22:26 +00:00

test_pageserver_restarts_under_workload.py

pageserver: improve the shutdown log error (#5792)

2023-11-07 16:57:26 +00:00

test_pageserver_secondary.py

pageserver: heatmap uploads (#6050)

2023-12-14 13:09:24 +00:00

test_parallel_copy.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_pg_regress.py

test: make pg_regress less flaky, hopefully (#4903)

2023-08-10 15:24:43 +03:00

test_physical_replication.py

Track size of FSM fork while applying records at replica (#5901)

2023-12-05 18:49:24 +02:00

test_pitr_gc.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_proxy_allowed_ips.py

IP allowlist on the proxy side (#5906)

2023-11-30 13:14:33 +00:00

test_proxy_metric_collection.py

refactor(test_consumption_metrics): split for pageserver and proxy (#5324)

2023-09-16 18:05:35 +03:00

test_proxy_rate_limiter.py

Proxy control plane rate limiter (#5785)

2023-11-15 09:15:59 +00:00

test_proxy.py

Proxy control plane rate limiter (#5785)

2023-11-15 09:15:59 +00:00

test_read_trace.py

tests: enable multiple pageservers in neon_local and neon_fixture (#5231)

2023-09-08 16:19:57 +01:00

test_read_validation.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_readonly_node.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_recovery.py

fix: demote warnings, fix flakyness (#4837)

2023-07-31 07:43:12 +00:00

test_remote_storage.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_setup.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_sni_router.py

tests: split neon_fixtures.py (#4871)

2023-08-03 17:20:24 +03:00

test_subxacts.py

test: make pg_regress less flaky, hopefully (#4903)

2023-08-10 15:24:43 +03:00

test_tenant_conf.py

tests: allow-lists for occasional failures (#6074)

2023-12-08 17:32:16 +00:00

test_tenant_delete.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_tenant_detach.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_tenant_relocation.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_tenant_size.py

tests: use approximate equality in test_get_tenant_size_with_multiple_branches (#5411)

2023-09-29 09:15:43 +01:00

test_tenant_tasks.py

propagate lock guard to background deletion task (#4495)

2023-06-15 17:30:12 +03:00

test_tenants_with_remote_storage.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_tenants.py

tests: update tests that used local_fs&mock_s3 to use one or the other (#6015)

2023-12-08 14:52:37 +00:00

test_threshold_based_eviction.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_timeline_delete.py

Use extend instead of groups of append calls in tests (#6109)

2023-12-12 18:00:37 +01:00

test_timeline_size.py

pageserver: prioritize activation of tenants with client requests (#6112)

2023-12-15 20:37:47 +00:00

test_truncate.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_twophase.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_unlogged.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_vm_bits.py

Handle update of VM in XLOG_HEAP_LOCK/XLOG_HEAP2_LOCK_UPDATED WAL records (#4896)

2023-09-15 17:47:29 +03:00

test_wal_acceptor_async.py

build: back to opt-level=0 in debug builds, for faster compile times (#5751)

2023-11-20 15:41:37 +01:00

test_wal_acceptor.py

tests: update tests that used local_fs&mock_s3 to use one or the other (#6015)

2023-12-08 14:52:37 +00:00

test_wal_receiver.py

Raise pageserver walreceiver timeouts.

2023-06-19 15:59:38 +04:00

test_wal_restore.py

test_wal_restore_http: cleanup test

2023-12-13 15:04:25 -06:00

test_walredo_not_left_behind_on_detach.py

Move tenant & timeline dir method to NeonPageserver and use them everywhere (#5262)

2023-09-15 11:17:18 +01:00