mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-05 20:42:54 +00:00
af46b5286f
Every time you run `make`, it runs `make install` on all the PostgreSQL sources, which copies the header files. That in turn triggers a rebuild of the `postgres_ffi` crate, and everything that depends on it. We had worked around this earlier (see #2458), by passing a custom INSTALL script to the Postgres makefiles, which refrains from updating the modification timestamp on headers when they have not been changed, but the v14 makefile didn't obey INSTALL for the header files. Backporting c0a1d7621b to v14 fixes that. This backports upstream PostgreSQL commit c0a1d7621b to v14. Corresponding PR in the 'postgres' repo: https://github.com/neondatabase/postgres/pull/660
265 lines
10 KiB
YAML
265 lines
10 KiB
YAML
name: Check neon with MacOS builds
|
||
|
||
on:
|
||
workflow_call:
|
||
inputs:
|
||
pg_versions:
|
||
description: "Array of the pg versions to build for, for example: ['v14', 'v17']"
|
||
type: string
|
||
default: '[]'
|
||
required: false
|
||
rebuild_rust_code:
|
||
description: "Rebuild Rust code"
|
||
type: boolean
|
||
default: false
|
||
required: false
|
||
rebuild_everything:
|
||
description: "If true, rebuild for all versions"
|
||
type: boolean
|
||
default: false
|
||
required: false
|
||
|
||
env:
|
||
RUST_BACKTRACE: 1
|
||
COPT: '-Werror'
|
||
|
||
# TODO: move `check-*` and `files-changed` jobs to the "Caller" Workflow
|
||
# We should care about that as Github has limitations:
|
||
# - You can connect up to four levels of workflows
|
||
# - You can call a maximum of 20 unique reusable workflows from a single workflow file.
|
||
# https://docs.github.com/en/actions/sharing-automations/reusing-workflows#limitations
|
||
permissions:
|
||
contents: read
|
||
|
||
jobs:
|
||
build-pgxn:
|
||
if: |
|
||
inputs.pg_versions != '[]' || inputs.rebuild_everything ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-macos') ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-*') ||
|
||
github.ref_name == 'main'
|
||
timeout-minutes: 30
|
||
runs-on: macos-15
|
||
strategy:
|
||
matrix:
|
||
postgres-version: ${{ inputs.rebuild_everything && fromJSON('["v14", "v15", "v16", "v17"]') || fromJSON(inputs.pg_versions) }}
|
||
env:
|
||
# Use release build only, to have less debug info around
|
||
# Hence keeping target/ (and general cache size) smaller
|
||
BUILD_TYPE: release
|
||
steps:
|
||
- name: Harden the runner (Audit all outbound calls)
|
||
uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
|
||
with:
|
||
egress-policy: audit
|
||
|
||
- name: Checkout main repo
|
||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||
|
||
- name: Set pg ${{ matrix.postgres-version }} for caching
|
||
id: pg_rev
|
||
run: echo pg_rev=$(git rev-parse HEAD:vendor/postgres-${{ matrix.postgres-version }}) | tee -a "${GITHUB_OUTPUT}"
|
||
|
||
- name: Cache postgres ${{ matrix.postgres-version }} build
|
||
id: cache_pg
|
||
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
|
||
with:
|
||
path: pg_install/${{ matrix.postgres-version }}
|
||
key: v1-${{ runner.os }}-${{ runner.arch }}-${{ env.BUILD_TYPE }}-pg-${{ matrix.postgres-version }}-${{ steps.pg_rev.outputs.pg_rev }}-${{ hashFiles('Makefile') }}
|
||
|
||
- name: Checkout submodule vendor/postgres-${{ matrix.postgres-version }}
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
git submodule init vendor/postgres-${{ matrix.postgres-version }}
|
||
git submodule update --depth 1 --recursive
|
||
|
||
- name: Install build dependencies
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
brew install flex bison openssl protobuf icu4c
|
||
|
||
- name: Set extra env for macOS
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
echo 'LDFLAGS=-L/usr/local/opt/openssl@3/lib' >> $GITHUB_ENV
|
||
echo 'CPPFLAGS=-I/usr/local/opt/openssl@3/include' >> $GITHUB_ENV
|
||
|
||
- name: Build Postgres ${{ matrix.postgres-version }}
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
make postgres-${{ matrix.postgres-version }} -j$(sysctl -n hw.ncpu)
|
||
|
||
- name: Build Neon Pg Ext ${{ matrix.postgres-version }}
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
make "neon-pg-ext-${{ matrix.postgres-version }}" -j$(sysctl -n hw.ncpu)
|
||
|
||
- name: Get postgres headers ${{ matrix.postgres-version }}
|
||
if: steps.cache_pg.outputs.cache-hit != 'true'
|
||
run: |
|
||
make postgres-headers-${{ matrix.postgres-version }} -j$(sysctl -n hw.ncpu)
|
||
|
||
- name: Upload "pg_install/${{ matrix.postgres-version }}" artifact
|
||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
|
||
with:
|
||
name: pg_install--${{ matrix.postgres-version }}
|
||
path: pg_install/${{ matrix.postgres-version }}
|
||
# The artifact is supposed to be used by the next job in the same workflow,
|
||
# so there’s no need to store it for too long.
|
||
retention-days: 1
|
||
|
||
build-walproposer-lib:
|
||
if: |
|
||
contains(inputs.pg_versions, 'v17') || inputs.rebuild_everything ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-macos') ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-*') ||
|
||
github.ref_name == 'main'
|
||
timeout-minutes: 30
|
||
runs-on: macos-15
|
||
needs: [build-pgxn]
|
||
env:
|
||
# Use release build only, to have less debug info around
|
||
# Hence keeping target/ (and general cache size) smaller
|
||
BUILD_TYPE: release
|
||
steps:
|
||
- name: Harden the runner (Audit all outbound calls)
|
||
uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
|
||
with:
|
||
egress-policy: audit
|
||
|
||
- name: Checkout main repo
|
||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||
|
||
- name: Set pg v17 for caching
|
||
id: pg_rev
|
||
run: echo pg_rev=$(git rev-parse HEAD:vendor/postgres-v17) | tee -a "${GITHUB_OUTPUT}"
|
||
|
||
- name: Download "pg_install/v17" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: pg_install--v17
|
||
path: pg_install/v17
|
||
|
||
- name: Cache walproposer-lib
|
||
id: cache_walproposer_lib
|
||
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
|
||
with:
|
||
path: build/walproposer-lib
|
||
key: v1-${{ runner.os }}-${{ runner.arch }}-${{ env.BUILD_TYPE }}-walproposer_lib-v17-${{ steps.pg_rev.outputs.pg_rev }}-${{ hashFiles('Makefile') }}
|
||
|
||
- name: Checkout submodule vendor/postgres-v17
|
||
if: steps.cache_walproposer_lib.outputs.cache-hit != 'true'
|
||
run: |
|
||
git submodule init vendor/postgres-v17
|
||
git submodule update --depth 1 --recursive
|
||
|
||
- name: Install build dependencies
|
||
if: steps.cache_walproposer_lib.outputs.cache-hit != 'true'
|
||
run: |
|
||
brew install flex bison openssl protobuf icu4c
|
||
|
||
- name: Set extra env for macOS
|
||
if: steps.cache_walproposer_lib.outputs.cache-hit != 'true'
|
||
run: |
|
||
echo 'LDFLAGS=-L/usr/local/opt/openssl@3/lib' >> $GITHUB_ENV
|
||
echo 'CPPFLAGS=-I/usr/local/opt/openssl@3/include' >> $GITHUB_ENV
|
||
|
||
- name: Build walproposer-lib (only for v17)
|
||
if: steps.cache_walproposer_lib.outputs.cache-hit != 'true'
|
||
run:
|
||
make walproposer-lib -j$(sysctl -n hw.ncpu)
|
||
|
||
- name: Upload "build/walproposer-lib" artifact
|
||
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
|
||
with:
|
||
name: build--walproposer-lib
|
||
path: build/walproposer-lib
|
||
# The artifact is supposed to be used by the next job in the same workflow,
|
||
# so there’s no need to store it for too long.
|
||
retention-days: 1
|
||
|
||
cargo-build:
|
||
if: |
|
||
inputs.pg_versions != '[]' || inputs.rebuild_rust_code || inputs.rebuild_everything ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-macos') ||
|
||
contains(github.event.pull_request.labels.*.name, 'run-extra-build-*') ||
|
||
github.ref_name == 'main'
|
||
timeout-minutes: 30
|
||
runs-on: macos-15
|
||
needs: [build-pgxn, build-walproposer-lib]
|
||
env:
|
||
# Use release build only, to have less debug info around
|
||
# Hence keeping target/ (and general cache size) smaller
|
||
BUILD_TYPE: release
|
||
steps:
|
||
- name: Harden the runner (Audit all outbound calls)
|
||
uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
|
||
with:
|
||
egress-policy: audit
|
||
|
||
- name: Checkout main repo
|
||
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||
with:
|
||
submodules: true
|
||
|
||
- name: Download "pg_install/v14" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: pg_install--v14
|
||
path: pg_install/v14
|
||
|
||
- name: Download "pg_install/v15" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: pg_install--v15
|
||
path: pg_install/v15
|
||
|
||
- name: Download "pg_install/v16" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: pg_install--v16
|
||
path: pg_install/v16
|
||
|
||
- name: Download "pg_install/v17" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: pg_install--v17
|
||
path: pg_install/v17
|
||
|
||
- name: Download "build/walproposer-lib" artifact
|
||
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
|
||
with:
|
||
name: build--walproposer-lib
|
||
path: build/walproposer-lib
|
||
|
||
# `actions/download-artifact` doesn't preserve permissions:
|
||
# https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss
|
||
- name: Make pg_install/v*/bin/* executable
|
||
run: |
|
||
chmod +x pg_install/v*/bin/*
|
||
|
||
- name: Cache cargo deps
|
||
uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
|
||
with:
|
||
path: |
|
||
~/.cargo/registry
|
||
!~/.cargo/registry/src
|
||
~/.cargo/git
|
||
target
|
||
key: v1-${{ runner.os }}-${{ runner.arch }}-cargo-${{ hashFiles('./Cargo.lock') }}-${{ hashFiles('./rust-toolchain.toml') }}-rust
|
||
|
||
- name: Install build dependencies
|
||
run: |
|
||
brew install flex bison openssl protobuf icu4c
|
||
|
||
- name: Set extra env for macOS
|
||
run: |
|
||
echo 'LDFLAGS=-L/usr/local/opt/openssl@3/lib' >> $GITHUB_ENV
|
||
echo 'CPPFLAGS=-I/usr/local/opt/openssl@3/include' >> $GITHUB_ENV
|
||
|
||
- name: Run cargo build
|
||
run: cargo build --all --release -j$(sysctl -n hw.ncpu)
|
||
|
||
- name: Check that no warnings are produced
|
||
run: ./run_clippy.sh
|