mirror of
https://github.com/neondatabase/neon.git
synced 2026-06-04 22:10:39 +00:00
7eaa7a496b
## Problem Writes to the postgres client socket from the page server were not wrapped in cancellation handling, so a stuck client connection could prevent tenant shutdowwn. ## Summary of changes All the places we call flush() to write to the socket, we should be respecting the cancellation token for the task. In this PR, I explicitly pass around a CancellationToken rather than doing inline `task_mgr::shutdown_token` calls, to avoid coupling it to the global task_mgr state and make it easier to refactor later. I have some follow-on commits that add a Shutdown variant to QueryError and use it more extensively, but that's pure refactor so will keep separate from this bug fix PR. Closes: https://github.com/neondatabase/neon/issues/5341
37 lines
1.2 KiB
Python
37 lines
1.2 KiB
Python
# This test spawns pgbench in a thread in the background and concurrently restarts pageserver,
|
|
# checking how client is able to transparently restore connection to pageserver
|
|
#
|
|
import threading
|
|
import time
|
|
|
|
from fixtures.log_helper import log
|
|
from fixtures.neon_fixtures import NeonEnv, PgBin
|
|
|
|
|
|
# Test restarting page server, while safekeeper and compute node keep
|
|
# running.
|
|
def test_pageserver_restarts_under_worload(neon_simple_env: NeonEnv, pg_bin: PgBin):
|
|
env = neon_simple_env
|
|
env.neon_cli.create_branch("test_pageserver_restarts")
|
|
endpoint = env.endpoints.create_start("test_pageserver_restarts")
|
|
n_restarts = 10
|
|
scale = 10
|
|
|
|
env.pageserver.allowed_errors.append(".*query handler.*failed.*Shutting down")
|
|
|
|
def run_pgbench(connstr: str):
|
|
log.info(f"Start a pgbench workload on pg {connstr}")
|
|
pg_bin.run_capture(["pgbench", "-i", f"-s{scale}", connstr])
|
|
pg_bin.run_capture(["pgbench", f"-T{n_restarts}", connstr])
|
|
|
|
thread = threading.Thread(target=run_pgbench, args=(endpoint.connstr(),), daemon=True)
|
|
thread.start()
|
|
|
|
for _ in range(n_restarts):
|
|
# Stop the pageserver gracefully and restart it.
|
|
time.sleep(1)
|
|
env.pageserver.stop()
|
|
env.pageserver.start()
|
|
|
|
thread.join()
|