Konstantin Knizhnik 563d73d923 Use smgrexists() instead of access() to enforce uniqueness of generated relfilenumber (#7992) ...

## Problem

Postgres is using `access()` function in `GetNewRelFileNumber` to check
if assigned relfilenumber is not used for any other relation. This check
will not work in Neon, because we do not have all files in local
storage.

## Summary of changes

Use smgrexists() instead which will check at page server if such
relfilenode is used.

## Checklist before requesting a review

- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist

---------

Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>

2024-07-23 18:41:55 +03:00

..

postgres-v14 @ dbd0e6428b

Use smgrexists() instead of access() to enforce uniqueness of generated relfilenumber (#7992)

2024-07-23 18:41:55 +03:00

postgres-v15 @ 035b73a9c5

Use smgrexists() instead of access() to enforce uniqueness of generated relfilenumber (#7992)

2024-07-23 18:41:55 +03:00

postgres-v16 @ b39f316137

Use smgrexists() instead of access() to enforce uniqueness of generated relfilenumber (#7992)

2024-07-23 18:41:55 +03:00

revisions.json

Use smgrexists() instead of access() to enforce uniqueness of generated relfilenumber (#7992)

2024-07-23 18:41:55 +03:00