John Spray 0fc3708de2 pageserver: use a backoff::retry in Deleter (#5534) ...

## Problem

The `Deleter` currently doesn't use a backoff::retry because it doesn't
need to: it is already inside a loop when doing the deletion, so can
just let the loop go around.

However, this is a problem for logging, because we log on errors, which
includes things like 503/429 cases that would usually be swallowed by a
backoff::retry in most places we use the RemoteStorage interface.

The underlying problem is that RemoteStorage doesn't have a proper error
type, and an anyhow::Error can't easily be interrogated for its original
S3 SdkError because downcast_ref requires a concrete type, but SdkError
is parametrized on response type.

## Summary of changes

Wrap remote deletions in Deleter in a backoff::retry to avoid logging
warnings on transient 429/503 conditions, and for symmetry with how
RemoteStorage is used in other places.

2023-10-11 15:25:08 +01:00

..

deleter.rs

pageserver: use a backoff::retry in Deleter (#5534)

2023-10-11 15:25:08 +01:00

list_writer.rs

pageserver: flush deletion queue on detach (#5452)

2023-10-10 10:46:24 +01:00

validator.rs

tests: stabilize + extend deletion queue recovery test (#5457)

2023-10-05 11:22:05 +01:00