mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-08 05:52:55 +00:00
49775d28e4
## Problem
We respect `skip_pg_catalog_updates` at the initial start, but ignore at
the follow-up `/configure`. Yet, it's used for storage->cplane->compute
notify requests after migrations, shard split, etc. So every time we get
them, applying the new config takes much longer than it should because
we go through Postgres catalog checks. Cplane sets this flag, when it
does serves notify attach call
9068c7d743
Related to `inc-403`, for example
## Summary of changes
Look at `skip_pg_catalog_updates` in `compute.reconfigure()`
63 lines
2.0 KiB
Python
63 lines
2.0 KiB
Python
from __future__ import annotations
|
|
|
|
from fixtures.neon_fixtures import NeonEnv
|
|
from fixtures.utils import wait_until
|
|
|
|
|
|
def test_compute_reconfigure(neon_simple_env: NeonEnv):
|
|
"""
|
|
Test that we can change postgresql.conf settings even if
|
|
skip_pg_catalog_updates=True is set.
|
|
"""
|
|
env = neon_simple_env
|
|
|
|
TEST_LOG_LINE_PREFIX = "%m [%p] [test_compute_reconfigure]: "
|
|
|
|
endpoint = env.endpoints.create_start("main")
|
|
|
|
# Check that the log line prefix is not set
|
|
# or different from TEST_LOG_LINE_PREFIX
|
|
with endpoint.cursor() as cursor:
|
|
cursor.execute("SHOW log_line_prefix;")
|
|
row = cursor.fetchone()
|
|
assert row is not None
|
|
assert row[0] != TEST_LOG_LINE_PREFIX
|
|
|
|
endpoint.respec_deep(
|
|
**{
|
|
"skip_pg_catalog_updates": True,
|
|
"cluster": {
|
|
"settings": [
|
|
{
|
|
"name": "log_line_prefix",
|
|
"vartype": "string",
|
|
"value": TEST_LOG_LINE_PREFIX,
|
|
}
|
|
]
|
|
},
|
|
}
|
|
)
|
|
endpoint.reconfigure()
|
|
|
|
# Check that in logs we see that it was actually reconfigured,
|
|
# not restarted or something else.
|
|
endpoint.log_contains("INFO request{method=POST uri=/configure")
|
|
|
|
# In /configure we only send SIGHUP at the end, so in theory
|
|
# it doesn't necessarily mean that Postgres already reloaded
|
|
# the new config; and it may race in some envs.
|
|
# So we wait until we see the log line that the config was changed.
|
|
def check_logs():
|
|
endpoint.log_contains(
|
|
f'[test_compute_reconfigure]: LOG: parameter "log_line_prefix" changed to "{TEST_LOG_LINE_PREFIX}"'
|
|
)
|
|
|
|
wait_until(check_logs)
|
|
|
|
# Check that the log line prefix is set
|
|
with endpoint.cursor() as cursor:
|
|
cursor.execute("SHOW log_line_prefix;")
|
|
row = cursor.fetchone()
|
|
assert row is not None
|
|
assert row[0] == TEST_LOG_LINE_PREFIX
|