mirror of
https://github.com/neondatabase/neon.git
synced 2026-05-25 09:00:37 +00:00
59b7ff8988
As the title says, I updated the lint rules to no longer allow unwrap or unimplemented. Three special cases: * Tests are allowed to use them * std::sync::Mutex lock().unwrap() is common because it's usually correct to continue panicking on poison * `tokio::spawn_blocking(...).await.unwrap()` is common because it will only error if the blocking fn panics, so continuing the panic is also correct I've introduced two extension traits to help with these last two, that are a bit more explicit so they don't need an expect message every time.
106 lines
2.9 KiB
Rust
106 lines
2.9 KiB
Rust
// rustc lints/lint groups
|
|
// https://doc.rust-lang.org/rustc/lints/groups.html
|
|
#![deny(deprecated, future_incompatible, let_underscore, nonstandard_style)]
|
|
#![warn(clippy::all, clippy::pedantic, clippy::cargo)]
|
|
// List of denied lints from the clippy::restriction group.
|
|
// https://rust-lang.github.io/rust-clippy/master/index.html#?groups=restriction
|
|
#![warn(
|
|
clippy::undocumented_unsafe_blocks,
|
|
// TODO: Enable once all individual checks are enabled.
|
|
//clippy::as_conversions,
|
|
clippy::dbg_macro,
|
|
clippy::empty_enum_variants_with_brackets,
|
|
clippy::exit,
|
|
clippy::float_cmp_const,
|
|
clippy::lossy_float_literal,
|
|
clippy::macro_use_imports,
|
|
clippy::manual_ok_or,
|
|
// TODO: consider clippy::map_err_ignore
|
|
// TODO: consider clippy::mem_forget
|
|
clippy::rc_mutex,
|
|
clippy::rest_pat_in_fully_bound_structs,
|
|
clippy::string_add,
|
|
clippy::string_to_string,
|
|
clippy::todo,
|
|
clippy::unimplemented,
|
|
clippy::unwrap_used,
|
|
)]
|
|
// List of permanently allowed lints.
|
|
#![allow(
|
|
// It's ok to cast bool to u8, etc.
|
|
clippy::cast_lossless,
|
|
// Seems unavoidable.
|
|
clippy::multiple_crate_versions,
|
|
// While #[must_use] is a great feature this check is too noisy.
|
|
clippy::must_use_candidate,
|
|
// Inline consts, structs, fns, imports, etc. are ok if they're used by
|
|
// the following statement(s).
|
|
clippy::items_after_statements,
|
|
)]
|
|
// List of temporarily allowed lints.
|
|
// TODO: fix code and reduce list or move to permanent list above.
|
|
#![expect(
|
|
clippy::cargo_common_metadata,
|
|
clippy::cast_possible_truncation,
|
|
clippy::cast_possible_wrap,
|
|
clippy::cast_precision_loss,
|
|
clippy::cast_sign_loss,
|
|
clippy::doc_markdown,
|
|
clippy::inline_always,
|
|
clippy::match_same_arms,
|
|
clippy::match_wild_err_arm,
|
|
clippy::missing_errors_doc,
|
|
clippy::missing_panics_doc,
|
|
clippy::module_name_repetitions,
|
|
clippy::needless_pass_by_value,
|
|
clippy::redundant_closure_for_method_calls,
|
|
clippy::similar_names,
|
|
clippy::single_match_else,
|
|
clippy::struct_excessive_bools,
|
|
clippy::struct_field_names,
|
|
clippy::too_many_lines,
|
|
clippy::unused_self
|
|
)]
|
|
#![cfg_attr(
|
|
any(test, feature = "testing"),
|
|
allow(
|
|
clippy::needless_raw_string_hashes,
|
|
clippy::unreadable_literal,
|
|
clippy::unused_async,
|
|
)
|
|
)]
|
|
// List of temporarily allowed lints to unblock beta/nightly.
|
|
#![allow(unknown_lints)]
|
|
|
|
pub mod auth;
|
|
pub mod cache;
|
|
pub mod cancellation;
|
|
pub mod compute;
|
|
pub mod compute_ctl;
|
|
pub mod config;
|
|
pub mod console_redirect_proxy;
|
|
pub mod context;
|
|
pub mod control_plane;
|
|
pub mod error;
|
|
mod ext;
|
|
pub mod http;
|
|
pub mod intern;
|
|
pub mod jemalloc;
|
|
pub mod logging;
|
|
pub mod metrics;
|
|
pub mod parse;
|
|
pub mod postgres_rustls;
|
|
pub mod protocol2;
|
|
pub mod proxy;
|
|
pub mod rate_limiter;
|
|
pub mod redis;
|
|
pub mod sasl;
|
|
pub mod scram;
|
|
pub mod serverless;
|
|
pub mod signals;
|
|
pub mod stream;
|
|
pub mod types;
|
|
pub mod url;
|
|
pub mod usage_metrics;
|
|
pub mod waiters;
|