Christian Schwarz afc48e2cd9 refactor responsibility for tenant/timeline activation (#4317) ...

(This is prep work to make `Timeline::activate()` infallible.)

The current possibility for failure in `Timeline::activate()` is the
broker client's presence / absence. It should be an assert, but we're
careful with these. So, I'm planning to pass in the broker client to
activate(), thereby eliminating the possiblity of its absence.

In the unit tests, we don't have a broker client. So, I thought I'd be
in trouble because the unit tests also called `activate()` before this
PR.

However, closer inspection reveals a long-standing FIXME about this,
which is addressed by this patch.

It turns out that the unit tests don't actually need the background
loops to be running. They just need the state value to be `Active`. So,
for the tests, we just set it to that value but don't spawn the
background loops.

We'll need to revisit this if we ever do more Rust unit tests in the
future. But right now, this refactoring improves the code, so, let's
revisit when we get there.

Patch series:

- #4316
- #4317
- #4318
- #4319

2023-05-24 16:54:11 +02:00

..

benches

revert: "Add check for duplicates of generated image layers" (#4104)

2023-04-28 17:20:18 +03:00

fixtures

walredo: simple tests and bench updates (#3045)

2023-01-16 18:24:45 +02:00

src

refactor responsibility for tenant/timeline activation (#4317)

2023-05-24 16:54:11 +02:00

Cargo.toml

feat(page_service): read timeouts (#4093)

2023-04-27 17:55:35 +00:00