John Spray d1bc36f536 storage controller: fix retries of compute hook notifications while a secondary node is offline (#10352) ...

## Problem

We would sometimes fail to retry compute notifications:
1. Try and send, set compute_notify_failure if we can't
2. On next reconcile, reconcile() fails for some other reason (e.g.
tried to talk to an offline node), and we fail the `result.is_ok() &&
must_notify` condition around the re-sending.

Closes: https://github.com/neondatabase/cloud/issues/22612

## Summary of changes

- Clarify the meaning of the reconcile result: it should be Ok(()) if
configuring attached location worked, even if secondary or detach
locations cannot be reached.
- Skip trying to talk to secondaries if they're offline
- Even if reconcile fails and we can't send the compute notification (we
can't send it because we're not sure if it's really attached), make sure
we save the `compute_notify_failure` flag so that subsequent reconciler
runs will try again
- Add a regression test for the above

2025-01-13 13:31:57 +00:00

..

data/extension_test/5670669815

[compute/postgres] feature: PostgreSQL 17 (#8573)

2024-09-12 23:18:41 +01:00

test_ancestor_branch.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_attach_tenant_config.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_auth_broker.py

[auth_broker]: regress test (#9541)

2024-10-29 11:39:09 +00:00

test_auth.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_backpressure.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_bad_connection.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_basebackup_error.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_branch_and_gc.py

test_runner: skip more tests using decorator instead of pytest.skip (#9704)

2024-11-11 18:07:01 +00:00

test_branch_behind.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_branching.py

Revert "pageserver: revert flush backpressure (#8550) (#10135)" (#10270)

2025-01-03 15:38:51 +00:00

test_broken_timeline.py

pageserver: fix spurious error logs in timeline lifecycle (#9589)

2024-10-31 14:44:59 +00:00

test_build_info_metric.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_change_pageserver.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_clog_truncate.py

pageserver: tighten up code around SLRU dir key handling (#10082)

2024-12-16 10:06:08 +00:00

test_close_fds.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_combocid.py

test_runner: use LFC by default (#8613)

2024-11-25 09:01:05 +00:00

test_compaction.py

pageserver: remove unused metric pageserver_layers_visited_per_read_global (#10141)

2025-01-10 20:35:50 +00:00

test_compatibility.py

tests: refine how compat snapshot is generated (#10342)

2025-01-10 13:57:23 +00:00

test_compute_catalog.py

fix(compute_ctl): Resolve issues with dropping roles having dangling permissions (#10299)

2025-01-09 16:39:53 +00:00

test_compute_locales.py

Switch compute-related locales to C.UTF-8 by default

2024-11-08 12:19:18 -06:00

test_compute_metrics.py

test_runner: update packages for Python 3.13 (#10285)

2025-01-06 20:25:31 +00:00

test_compute_migrations.py

Add more substantial tests for compute migrations (#9811)

2025-01-02 18:37:50 +00:00

test_config.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_crafted_wal_end.py

safekeeper: use protobuf for sending compressed records to pageserver (#9821)

2024-11-27 12:12:21 +00:00

test_createdropdb.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_createuser.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_ddl_forwarding.py

fix(adapter): password not set in role drop (#10130)

2024-12-14 17:37:13 +00:00

test_disk_usage_eviction.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_download_extensions.py

Improve typing in test_runner/fixtures/httpserver.py (#10103)

2024-12-11 22:21:42 +00:00

test_endpoint_crash.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_explain_with_lfc_stats.py

test_runner: use LFC by default (#8613)

2024-11-25 09:01:05 +00:00

test_extensions.py

compute_ctl: Add endpoint that allows extensions to be installed (#9344)

2024-10-18 15:07:36 +03:00

test_fsm_truncate.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_fullbackup.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_gc_aggressive.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_gin_redo.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_hot_standby.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_import_pgdata.py

tests: use high IO concurrency in test_pgdata_import_smoke, use effective_io_concurrency=2 in tests by default (#10114)

2024-12-19 10:58:49 +00:00

test_import.py

pageserver: fix spurious error logs in timeline lifecycle (#9589)

2024-10-31 14:44:59 +00:00

test_ingestion_layer_size.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_installed_extensions.py

Update compute_installed_extensions metric: (#9891)

2024-12-11 16:43:26 +00:00

test_large_schema.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_layer_bloating.py

test_runner: skip more tests using decorator instead of pytest.skip (#9704)

2024-11-11 18:07:01 +00:00

test_layer_eviction.py

test_runner: skip more tests using decorator instead of pytest.skip (#9704)

2024-11-11 18:07:01 +00:00

test_layer_writers_fail.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_layers_from_future.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_lfc_resize.py

tests: smaller datasets in LFC tests (#10346)

2025-01-10 15:53:23 +00:00

test_lfc_working_set_approximation.py

test_runner: use LFC by default (#8613)

2024-11-25 09:01:05 +00:00

test_local_file_cache.py

tests: smaller datasets in LFC tests (#10346)

2025-01-10 15:53:23 +00:00

test_logging.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_logical_replication.py

Fix test_subscriber_synchronous_commit flakiness. (#10057)

2024-12-12 11:57:00 +00:00

test_lsn_mapping.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_multixact.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_nbtree_pagesplit_cycleid.py

Emit nbtree vacuum cycle id in nbtree xlog through forced FPIs (#9932)

2024-12-10 19:42:52 +00:00

test_neon_cli.py

test_runner: skip more tests using decorator instead of pytest.skip (#9704)

2024-11-11 18:07:01 +00:00

test_neon_extension.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_neon_local_cli.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_neon_superuser.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_next_xid.py

Update ruff to much newer version (#9433)

2024-10-18 12:42:41 +02:00

test_normal_work.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_oid_overflow.py

test_runner: use LFC by default (#8613)

2024-11-25 09:01:05 +00:00

test_old_request_lsn.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_ondemand_download.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_ondemand_slru_download.py

Python 3.11 (#9515)

2024-11-21 16:25:31 +00:00

test_ondemand_wal_download.py

Register custom xlog reader callbacks for on-demand WAL download in StartupDecodingContext (#9007)

2024-11-19 22:29:57 +02:00

test_pageserver_api.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_pageserver_catchup.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_pageserver_crash_consistency.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_pageserver_generations.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_pageserver_getpage_throttle.py

tests & benchmarks: unify the way we customize the default tenant config (#9992)

2024-12-03 22:07:03 +00:00

test_pageserver_layer_rolling.py

fix(pageserver): run psql in thread to avoid blocking (#10177)

2024-12-19 09:45:06 +00:00

test_pageserver_metric_collection.py

Improve typing in test_runner/fixtures/httpserver.py (#10103)

2024-12-11 22:21:42 +00:00

test_pageserver_reconnect.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_pageserver_restart.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_pageserver_restarts_under_workload.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_pageserver_secondary.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_pg_query_cancellation.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_pg_regress.py

Python 3.11 (#9515)

2024-11-21 16:25:31 +00:00

test_pg_waldump.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_physical_and_logical_replicaiton.py

Fix flukyness of test_physical_and_logical_replicaiton.py (#10176)

2024-12-18 19:15:38 +00:00

test_physical_replication.py

Add GUC controlling whether to pause recovery if some critical GUCs at replica have smaller value than on primary (#9057)

2024-12-01 12:23:10 +00:00

test_pitr_gc.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_postgres_version.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_prefetch_buffer_resize.py

test_prefetch: reduce timeout to default 5m from 10m (#10105)

2024-12-13 14:52:54 +00:00

test_proxy_allowed_ips.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_proxy_metric_collection.py

Improve typing in test_runner/fixtures/httpserver.py (#10103)

2024-12-11 22:21:42 +00:00

test_proxy_websockets.py

Add a websockets tunnel and a test for the proxy's websockets support. (#3823)

2025-01-13 11:35:39 +00:00

test_proxy.py

feat(proxy): add option to forward startup params (#9979)

2024-12-04 12:58:35 +00:00

test_read_validation.py

test_runner: use LFC by default (#8613)

2024-11-25 09:01:05 +00:00

test_readonly_node.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_recovery.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_remote_storage.py

Revert "pageserver: revert flush backpressure (#8550) (#10135)" (#10270)

2025-01-03 15:38:51 +00:00

test_replica_start.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_role_grants.py

compute_ctl: Add endpoint that allows setting role grants (#9395)

2024-10-18 11:25:45 +01:00

test_s3_restore.py

Python 3.11 (#9515)

2024-11-21 16:25:31 +00:00

test_setup.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_sharding.py

pageserver: tweak interpreted ingest record metrics (#10291)

2025-01-09 12:31:02 +00:00

test_sni_router.py

build(deps): bump mypy from 1.3.0 to 1.13.0 (#9670)

2024-11-22 14:31:36 +00:00

test_storage_controller.py

storage controller: fix retries of compute hook notifications while a secondary node is offline (#10352)

2025-01-13 13:31:57 +00:00

test_storage_scrubber.py

tests: add upload wait in test_scrubber_physical_gc_ancestors (#10260)

2025-01-03 10:55:07 +00:00

test_subscriber_restart.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_subxacts.py

safekeeper: use protobuf for sending compressed records to pageserver (#9821)

2024-11-27 12:12:21 +00:00

test_tenant_conf.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_tenant_delete.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenant_detach.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenant_relocation.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenant_size.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenant_tasks.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenants_with_remote_storage.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_tenants.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_threshold_based_eviction.py

Improve typing in test_runner/fixtures/httpserver.py (#10103)

2024-12-11 22:21:42 +00:00

test_timeline_archive.py

Handle race between auto-offload and unarchival (#10305)

2025-01-09 20:41:49 +00:00

test_timeline_delete.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_timeline_detach_ancestor.py

pageserver/storcon: add patch endpoints for tenant config metrics (#10020)

2024-12-11 19:16:33 +00:00

test_timeline_gc_blocking.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_timeline_size.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_truncate.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_twophase.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_unlogged.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00

test_unstable_extensions.py

Create the notion of unstable extensions

2024-10-28 17:47:15 -05:00

test_vm_bits.py

test_runner: bump test_check_visibility_map timeout (#10091)

2024-12-11 21:37:25 +00:00

test_vm_truncate.py

Correctly truncate VM (#9342)

2024-11-14 17:19:13 +02:00

test_wal_acceptor_async.py

safekeeper: use protobuf for sending compressed records to pageserver (#9821)

2024-11-27 12:12:21 +00:00

test_wal_acceptor.py

Add test restarting compute at WAL page boundary (#10111)

2024-12-16 14:53:04 +00:00

test_wal_receiver.py

test_runner: improve wait_until (#9936)

2024-12-02 10:26:15 +00:00

test_wal_restore.py

Switch compute-related locales to C.UTF-8 by default

2024-11-08 12:19:18 -06:00

test_walredo_not_left_behind_on_detach.py

Enable all pyupgrade checks in ruff

2024-10-08 14:32:26 -05:00