Christian Schwarz d7f1e30112 remote_timeline_client: more metrics & metrics-related cleanups ...

- Clean up redundant metric removal in TimelineMetrics::drop.
RemoteTimelineClientMetrics is responsible for cleaning up
REMOTE_OPERATION_TIME andREMOTE_UPLOAD_QUEUE_UNFINISHED_TASKS.

- Rename `pageserver_remote_upload_queue_unfinished_tasks` to
`pageserver_remote_timeline_client_calls_unfinished`. The new name
reflects that the metric is with respect to the entire call to remote
timeline client. This includes wait time in the upload queue and hence
it's a longer span than what `pageserver_remote_OPERATION_seconds`
measures.

- Add the `pageserver_remote_timeline_client_calls_started` histogram.
See the metric description for why we need it.

- Add helper functions `call_begin` etc to `RemoteTimelineClientMetrics`
to centralize the logic for updating the metrics above (they relate to
each other, see comments in code).

- Use these constructs to track ongoing downloads in
`pageserver_remote_timeline_client_calls_unfinished`

refs https://github.com/neondatabase/neon/issues/2029
fixes https://github.com/neondatabase/neon/issues/3249
closes https://github.com/neondatabase/neon/pull/3250

2023-01-05 11:50:17 +01:00

..

benches

Move tenant-related modules below tenant module (#3190)

2022-12-23 15:40:37 +02:00

src

remote_timeline_client: more metrics & metrics-related cleanups

2023-01-05 11:50:17 +01:00

Cargo.toml

Remove code and test to generate flamegraph on GetPage requests. (#3257)

2023-01-03 20:11:32 +02:00