Vlad Lazar bde1694cb9 pageserver: remove unused on_key_error method ...

It's obvious the method is unused, but let's break down error handling
of the read path. Before this patch set, all IO was done sequentially
for a given read. If one IO failed, then the error would stop the
processing of the read path.

Now that we are doing IO concurrently when serving a read request
it's not trivial to implement the same error handling approach.
As of this commit, one IO failure does not stop any other IO requests.
When awaiting for the IOs to complete, we stop waiting on the first
failure, but we do not signal any other pending IOs to complete and
they will just fail silently.

Long term, we need a better approach for this. Two broad ideas:
1. Introduce some synchronization between pending IO tasks such
that new IOs are not issued after the first failure
2. Cancel any pending IOs when the first error is discovered

2024-11-04 14:07:20 +01:00

..

benches

pageserver: move things around to prepare for decoding logic (#9504)

2024-10-29 10:00:34 +00:00

client

pageserver: add direct io config to virtual file (#9214)

2024-10-09 08:33:07 -04:00

compaction

2024 oct new clippy lints (#9448)

2024-10-18 10:27:50 +01:00

ctl

fix(pagectl): layer parsing and image layer dump (#9571)

2024-10-29 15:16:23 -04:00

pagebench

refactor(pageserver): remove aux v1 configs (#9494)

2024-10-28 19:51:14 +00:00

src

pageserver: remove unused on_key_error method

2024-11-04 14:07:20 +01:00

test_data

pageserver: add layer visibility calculation (#8511)

2024-08-01 09:25:35 +00:00

Cargo.toml

pageserver: move things around to prepare for decoding logic (#9504)

2024-10-29 10:00:34 +00:00