John Spray d1bc36f536 storage controller: fix retries of compute hook notifications while a secondary node is offline (#10352) ...

## Problem

We would sometimes fail to retry compute notifications:
1. Try and send, set compute_notify_failure if we can't
2. On next reconcile, reconcile() fails for some other reason (e.g.
tried to talk to an offline node), and we fail the `result.is_ok() &&
must_notify` condition around the re-sending.

Closes: https://github.com/neondatabase/cloud/issues/22612

## Summary of changes

- Clarify the meaning of the reconcile result: it should be Ok(()) if
configuring attached location worked, even if secondary or detach
locations cannot be reached.
- Skip trying to talk to secondaries if they're offline
- Even if reconcile fails and we can't send the compute notification (we
can't send it because we're not sure if it's really attached), make sure
we save the `compute_notify_failure` flag so that subsequent reconciler
runs will try again
- Add a regression test for the above

2025-01-13 13:31:57 +00:00

..

client

storcon: don't assume host:port format in storcon client (#10347)

2025-01-10 18:35:16 +00:00

migrations

Remove active column (#10335)

2025-01-11 02:52:45 +00:00

src

storage controller: fix retries of compute hook notifications while a secondary node is offline (#10352)

2025-01-13 13:31:57 +00:00

Cargo.toml

cargo: update diesel, pq-sys (#10256)

2025-01-03 10:20:18 +00:00