neon/pageserver at e5384ebefc1c983c2e5eb73a5763b4c514b2c599 - neon

rust/neon

mirror of https://github.com/neondatabase/neon.git synced 2026-01-14 08:52:56 +00:00

Files

Christian Schwarz 62d77e263f test_remote_timeline_client_calls_started_metric: fix flakiness (#6911 )

fixes https://github.com/neondatabase/neon/issues/6889

# Problem

The failure in the last 3 flaky runs on `main` is 

```
test_runner/regress/test_remote_storage.py:460: in test_remote_timeline_client_calls_started_metric
    churn("a", "b")
test_runner/regress/test_remote_storage.py:457: in churn
    assert gc_result["layers_removed"] > 0
E   assert 0 > 0
```

That's this code


cd449d66ea/test_runner/regress/test_remote_storage.py (L448-L460)

So, the test expects GC to remove some layers but the GC doesn't.

# Fix

My impression is that the VACUUM isn't re-using pages aggressively
enough, but I can't really prove that. Tried to analyze the layer map
dump but it's too complex.

So, this PR:

- Creates more churn by doing the overwrite twice.
- Forces image layer creation.

It also drive-by removes the redundant call to timeline_compact,
because, timeline_checkpoint already does that internally.

2024-02-27 10:55:10 +01:00

__init__.py

tests: make neon_fixtures a bit thinner by splitting out some pageserver related helpers (#3977 )

2023-04-07 13:47:28 +03:00

allowed_errors.py

pageserver: roll open layer in timeline writer (#6661 )

2024-02-19 12:34:27 +00:00

http.py

test_remote_timeline_client_calls_started_metric: fix flakiness (#6911 )

2024-02-27 10:55:10 +01:00

many_tenants.py

pagebench-based GetPage@LSN performance test (#6214 )