Joonas Koivunen ed9a114bde fix: find gc cutoff points without holding Tenant::gc_cs (#7585) ...

The current implementation of finding timeline gc cutoff Lsn(s) is done
while holding `Tenant::gc_cs`. In recent incidents long create branch
times were caused by holding the `Tenant::gc_cs` over extremely long
`Timeline::find_lsn_by_timestamp`. The fix is to find the GC cutoff
values before taking the `Tenant::gc_cs` lock. This change is safe to do
because the GC cutoff values and the branch points have no dependencies
on each other. In the case of `Timeline::find_gc_cutoff` taking a long
time with this change, we should no longer see `Tenant::gc_cs`
interfering with branch creation.

Additionally, the `Tenant::refresh_gc_info` is now tolerant of timeline
deletions (or any other failures to find the pitr_cutoff). This helps
with the synthetic size calculation being constantly completed instead
of having a break for a timely timeline deletion.

Fixes: #7560
Fixes: #7587

2024-05-03 14:57:26 +03:00

..

data/extension_test/5670669815

Feat/postgres 16 (#4761)

2023-09-12 15:11:32 +02:00

test_ancestor_branch.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_attach_tenant_config.py

feat(pageserver): add aux-file-v2 flag on tenant level (#7505)

2024-04-26 11:48:47 -04:00

test_auth.py

chore: remove repetitive words (#7206)

2024-03-25 11:43:02 -04:00

test_backpressure.py

Revert "pageserver: use a single tokio runtime (#6555)" (#7246)

2024-03-26 15:24:18 +01:00

test_bad_connection.py

Add retry loops and bump test timeout in test_pageserver_connection_stress (#7281)

2024-05-01 21:36:50 -07:00

test_basebackup_error.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_branch_and_gc.py

tests: log hygiene checks for storage controller (#6710)

2024-03-19 10:30:33 +00:00

test_branch_behind.py

tests: log hygiene checks for storage controller (#6710)

2024-03-19 10:30:33 +00:00

test_branching.py

fix: find gc cutoff points without holding Tenant::gc_cs (#7585)

2024-05-03 14:57:26 +03:00

test_broken_timeline.py

pageserver: coalesce read paths (#7477)

2024-04-25 13:29:17 +01:00

test_build_info_metric.py

feat: add build_tag env support for set_build_info_metric (#5576)

2023-10-27 10:47:11 +01:00

test_change_pageserver.py

tests/neon_local: rename "attachment service" -> "storage controller" (#7087)

2024-03-12 11:36:27 +00:00

test_clog_truncate.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_close_fds.py

tests: enable multiple pageservers in neon_local and neon_fixture (#5231)

2023-09-08 16:19:57 +01:00

test_compaction.py

pageserver: shard-aware keyspace partitioning (#6778)

2024-04-29 17:46:46 +00:00

test_compatibility.py

pagserver: use vectored read path in benchmarks (#7498)

2024-04-29 17:26:35 +01:00

test_config.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_crafted_wal_end.py

test_runner: replace black with ruff format (#6268)

2024-01-05 15:35:07 +00:00

test_createdropdb.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_createuser.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_ddl_forwarding.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_disk_usage_eviction.py

tests: add optional cursor to log_contains + fix truthiness issues in callers (#6960)

2024-03-01 10:45:39 +01:00

test_download_extensions.py

Use test specific directory in test_remote_extensions (#5938)

2023-11-27 18:57:58 +00:00

test_duplicate_layers.py

tests: add optional cursor to log_contains + fix truthiness issues in callers (#6960)

2024-03-01 10:45:39 +01:00

test_explain_with_lfc_stats.py

new test for LFC stats in explain (#6968)

2024-03-01 14:33:08 +00:00

test_fsm_truncate.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_fullbackup.py

tests: Remove unnecessary port config with VanillaPostgres class

2024-02-11 01:34:31 +02:00

test_gc_aggressive.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_hot_standby.py

Add test to demonstrate the problem with protocol version 1 (#7377)

2024-04-25 20:45:37 +03:00

test_import.py

pageserver: remove un-needed "uninit mark" (#5717)

2024-03-15 17:23:05 +02:00

test_large_schema.py

test_runner: replace all .format() with f-strings (#7194)

2024-04-02 14:32:14 +01:00

test_layer_bloating.py

test_runner: replace all .format() with f-strings (#7194)

2024-04-02 14:32:14 +01:00

test_layer_eviction.py

pageserver: check for new image layers based on ingested WAL (#7230)

2024-03-28 17:44:55 +00:00

test_layer_writers_fail.py

Move tenant & timeline dir method to NeonPageserver and use them everywhere (#5262)

2023-09-15 11:17:18 +01:00

test_layers_from_future.py

pageserver: check for new image layers based on ingested WAL (#7230)

2024-03-28 17:44:55 +00:00

test_lfc_resize.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_lfc_working_set_approximation.py

Testcase for neon extension function approximate_working_set_size() (#6980)

2024-03-01 13:29:08 +01:00

test_local_file_cache.py

pageserver: coalesce read paths (#7477)

2024-04-25 13:29:17 +01:00

test_logging.py

tests: add optional cursor to log_contains + fix truthiness issues in callers (#6960)

2024-03-01 10:45:39 +01:00

test_logical_replication.py

fix: drop replication slot causes postgres stuck on exit (#7192)

2024-03-28 15:24:36 +00:00

test_lsn_mapping.py

fix(pageserver): properly propagate missing key error for vectored get (#7569)

2024-05-02 09:19:45 -04:00

test_migrations.py

Revoke REPLICATION (#7052)

2024-03-08 22:24:30 +00:00

test_multixact.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_neon_cli.py

tests/neon_local: rename "attachment service" -> "storage controller" (#7087)

2024-03-12 11:36:27 +00:00

test_neon_extension.py

spec: allow neon extension auto-upgrade + softfail upgrade (#7231)

2024-03-28 17:22:35 +00:00

test_neon_local_cli.py

fix(test suite): some tests leak child processes (#6497)

2024-01-26 18:23:53 +00:00

test_neon_superuser.py

fix(test): drop subscription when test completes (#6975)

2024-03-06 15:52:24 +00:00

test_next_xid.py

Fix calculation of maximal multixact in ingest_multixact_create_record (#6502)

2024-01-29 07:39:16 +02:00

test_normal_work.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_old_request_lsn.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_ondemand_download.py

tests: relax test download remote layers api (#7604)

2024-05-03 12:40:09 +01:00

test_ondemand_slru_download.py

Add test for SLRU download (#7377)

2024-04-25 20:45:37 +03:00

test_pageserver_api.py

tokio-epoll-uring: fallback to std-fs if not available & not explicitly requested (#7120)

2024-03-15 17:46:04 +00:00

test_pageserver_catchup.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_pageserver_config.py

add async walredo mode (disabled-by-default, opt-in via config) (#6548)

2024-04-15 22:14:42 +02:00

test_pageserver_generations.py

tests: further stabilize test_deletion_queue_recovery (#7335)

2024-04-07 21:21:18 +00:00

test_pageserver_getpage_throttle.py

feat(per-tenant throttling): exclude throttled time from page_service metrics + regression test (#6953)

2024-03-05 13:44:00 +00:00

test_pageserver_layer_rolling.py

pageserver: time based rolling based on the first write timestamp (#7346)

2024-04-10 06:31:28 +01:00

test_pageserver_metric_collection.py

pageserver: write consumption metrics to S3 (#7200)

2024-03-22 14:52:14 +00:00

test_pageserver_reconnect.py

Implement lockless update of pageserver_connstring GUC in shared memory (#6314)

2024-01-23 07:55:05 +02:00

test_pageserver_restart.py

tests: add basic coverage for sharding (#6380)

2024-01-26 14:40:47 +00:00

test_pageserver_restarts_under_workload.py

pageserver: improve the shutdown log error (#5792)

2023-11-07 16:57:26 +00:00

test_pageserver_secondary.py

pageserver: fix secondary download scheduling (#7396)

2024-04-18 13:16:03 +01:00

test_parallel_copy.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_pg_regress.py

pageserver: coalesce read paths (#7477)

2024-04-25 13:29:17 +01:00

test_pg_waldump.py

Fix usage of pg_waldump --ignore option (#7578)

2024-05-02 11:52:30 +00:00

test_physical_replication.py

Track size of FSM fork while applying records at replica (#5901)

2023-12-05 18:49:24 +02:00

test_pitr_gc.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_proxy_allowed_ips.py

proxy: include client IP in ip deny message (#6854)

2024-02-21 18:24:59 +01:00

test_proxy_metric_collection.py

refactor(test_consumption_metrics): split for pageserver and proxy (#5324)

2023-09-16 18:05:35 +03:00

test_proxy_websockets.py

proxy: add websocket regression tests (#7121)

2024-03-15 10:21:48 +01:00

test_proxy.py

remove http timeout (#7291)

2024-04-03 11:23:26 +01:00

test_read_trace.py

tests: enable multiple pageservers in neon_local and neon_fixture (#5231)

2023-09-08 16:19:57 +01:00

test_read_validation.py

Refactor how the request LSNs are tracked in compute (#7377)

2024-04-25 20:45:37 +03:00

test_readonly_node.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_recovery.py

test: fix test_pageserver_recovery flakyness (#7207)

2024-03-25 09:38:12 +00:00

test_remote_storage.py

pageserver: check for new image layers based on ingested WAL (#7230)

2024-03-28 17:44:55 +00:00

test_replication_start.py

fixup(#7204 / postgres): revert IsPrimaryAlive checks (#7209)

2024-03-23 01:01:51 +00:00

test_s3_restore.py

tests/neon_local: rename "attachment service" -> "storage controller" (#7087)

2024-03-12 11:36:27 +00:00

test_s3_scrubber.py

s3_scrubber: add tenant-snapshot (#7444)

2024-04-29 12:16:00 +00:00

test_setup.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_sharding.py

tests: tweak log allow list in test_sharding_split_failures (#7549)

2024-04-30 18:00:24 +01:00

test_sni_router.py

tests: split neon_fixtures.py (#4871)

2023-08-03 17:20:24 +03:00

test_storage_controller.py

storage_controller: fix non-timeline passthrough GETs (#7602)

2024-05-03 12:52:43 +01:00

test_subxacts.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_tenant_conf.py

pageserver: increase DEFAULT_MAX_WALRECEIVER_LSN_WAL_LAG (#6970)

2024-03-01 16:49:37 +00:00

test_tenant_delete.py

pageserver: return ACCEPTED when deletion already in flight (#7384)

2024-04-16 09:39:18 +01:00

test_tenant_detach.py

neon_local: add "tenant import" (#7399)

2024-04-29 08:52:18 +01:00

test_tenant_relocation.py

pageserver: remove import/export script previously used for breaking format changes (#7458)

2024-04-23 11:36:56 +01:00

test_tenant_size.py

fix: find gc cutoff points without holding Tenant::gc_cs (#7585)

2024-05-03 14:57:26 +03:00

test_tenant_tasks.py

propagate lock guard to background deletion task (#4495)

2023-06-15 17:30:12 +03:00

test_tenants_with_remote_storage.py

tests: add optional cursor to log_contains + fix truthiness issues in callers (#6960)

2024-03-01 10:45:39 +01:00

test_tenants.py

pageserver: return 429 on timeline creation in progress (#7225)

2024-03-26 15:20:05 +00:00

test_threshold_based_eviction.py

tests: add optional cursor to log_contains + fix truthiness issues in callers (#6960)

2024-03-01 10:45:39 +01:00

test_timeline_delete.py

pageserver: cancellation for remote ops in tenant deletion on shutdown (#6105)

2024-03-15 18:03:49 +00:00

test_timeline_size.py

Revert "pageserver: use a single tokio runtime (#6555)" (#7246)

2024-03-26 15:24:18 +01:00

test_truncate.py

python: more linting (#4734)

2023-07-18 12:56:40 +03:00

test_twophase.py

tests: Remove "postgres is running on ... branch" messages

2024-02-11 01:34:31 +02:00

test_unlogged.py

Rename "Postgres nodes" in control_plane to endpoints.

2023-04-13 14:34:29 +03:00

test_vm_bits.py

Refactor how the request LSNs are tracked in compute (#7377)

2024-04-25 20:45:37 +03:00

test_wal_acceptor_async.py

Upload partial segments (#6530)

2024-04-03 15:20:51 +00:00

test_wal_acceptor.py

Discover safekeepers via broker request (#7279)

2024-04-30 18:50:03 +00:00

test_wal_receiver.py

Raise pageserver walreceiver timeouts.

2023-06-19 15:59:38 +04:00

test_wal_restore.py

Allow initdb preservation for broken tenants (#6790)

2024-02-19 17:27:02 +01:00

test_walredo_not_left_behind_on_detach.py

Move tenant & timeline dir method to NeonPageserver and use them everywhere (#5262)

2023-09-15 11:17:18 +01:00