From 88fd7f091afe5e40e680ecb25b95da08adc96392 Mon Sep 17 00:00:00 2001
From: Paul Masurel <paul.masurel@gmail.com>
Date: Sat, 9 Nov 2019 21:18:51 +0900
Subject: [PATCH] SegmentUpdater.add_segment does not need to return true
 (#693)

---
 src/indexer/index_writer.rs    | 3 ++-
 src/indexer/segment_updater.rs | 4 +---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/indexer/index_writer.rs b/src/indexer/index_writer.rs
index 3e79b1688..4d37dfe8d 100644
--- a/src/indexer/index_writer.rs
+++ b/src/indexer/index_writer.rs
@@ -227,7 +227,8 @@ fn index_documents(
         delete_cursor,
         delete_bitset_opt,
     );
-    Ok(segment_updater.add_segment(segment_entry))
+    segment_updater.add_segment(segment_entry);
+    Ok(true)
 }
 
 fn apply_deletes(
diff --git a/src/indexer/segment_updater.rs b/src/indexer/segment_updater.rs
index 0415592a9..d3ba91af1 100644
--- a/src/indexer/segment_updater.rs
+++ b/src/indexer/segment_updater.rs
@@ -199,14 +199,12 @@ impl SegmentUpdater {
         self.0.pool.spawn_fn(move || Ok(f(me_clone)))
     }
 
-    pub fn add_segment(&self, segment_entry: SegmentEntry) -> bool {
+    pub fn add_segment(&self, segment_entry: SegmentEntry) {
         self.run_async(|segment_updater| {
             segment_updater.0.segment_manager.add_segment(segment_entry);
             segment_updater.consider_merge_options();
-            true
         })
         .forget();
-        true
     }
 
     /// Orders `SegmentManager` to remove all segments