From 976128a4123f2ad8489f29d394ef084873c01aa1 Mon Sep 17 00:00:00 2001
From: Pascal Seitz <pascal.seitz@gmail.com>
Date: Fri, 9 Dec 2022 15:12:29 +0800
Subject: [PATCH] extend benchmarks

---
 fastfield_codecs/src/lib.rs              |  1 +
 fastfield_codecs/src/null_index/dense.rs | 66 +++++++++++++++++++-----
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/fastfield_codecs/src/lib.rs b/fastfield_codecs/src/lib.rs
index ae9cb34b7..bf821a68a 100644
--- a/fastfield_codecs/src/lib.rs
+++ b/fastfield_codecs/src/lib.rs
@@ -44,6 +44,7 @@ mod column;
 mod gcd;
 mod serialize;
 
+/// TODO: remove when codec is used
 pub use null_index::*;
 
 use self::bitpacked::BitpackedCodec;
diff --git a/fastfield_codecs/src/null_index/dense.rs b/fastfield_codecs/src/null_index/dense.rs
index 1e59e3617..2bd45dfe0 100644
--- a/fastfield_codecs/src/null_index/dense.rs
+++ b/fastfield_codecs/src/null_index/dense.rs
@@ -72,7 +72,7 @@ impl DenseCodec {
         get_bit_at(bitvec, pos_in_bitvec)
     }
     #[inline]
-    pub(crate) fn dense_index_block(&self, block_pos: u32) -> DenseIndexBlock {
+    fn dense_index_block(&self, block_pos: u32) -> DenseIndexBlock {
         dense_index_block(&self.data, block_pos)
     }
 
@@ -132,8 +132,7 @@ impl DenseCodec {
 #[inline]
 fn dense_index_block(data: &[u8], block_pos: u32) -> DenseIndexBlock {
     let data_start_pos = block_pos as usize * SERIALIZED_BLOCK_SIZE;
-    let block_data: [u8; SERIALIZED_BLOCK_SIZE] = data
-        [data_start_pos..][..SERIALIZED_BLOCK_SIZE]
+    let block_data: [u8; SERIALIZED_BLOCK_SIZE] = data[data_start_pos..][..SERIALIZED_BLOCK_SIZE]
         .try_into()
         .unwrap();
     block_data.into()
@@ -335,11 +334,13 @@ mod bench {
 
     use super::*;
 
-    const NUM_VALUES: u32 = 1_000_000;
+    const TOTAL_NUM_VALUES: u32 = 1_000_000;
     fn gen_bools(fill_ratio: f64) -> DenseCodec {
         let mut out = Vec::new();
         let mut rng: StdRng = StdRng::from_seed([1u8; 32]);
-        let bools: Vec<_> = (0..NUM_VALUES).map(|_| rng.gen_bool(fill_ratio)).collect();
+        let bools: Vec<_> = (0..TOTAL_NUM_VALUES)
+            .map(|_| rng.gen_bool(fill_ratio))
+            .collect();
         serialize_dense_codec(bools.into_iter(), &mut out).unwrap();
 
         let codec = DenseCodec::open(OwnedBytes::new(out));
@@ -360,7 +361,10 @@ mod bench {
     }
 
     fn walk_over_data(codec: &DenseCodec, max_step_size: u32) -> Option<u32> {
-        walk_over_data_from_positions(codec, random_range_iterator(0, NUM_VALUES, max_step_size))
+        walk_over_data_from_positions(
+            codec,
+            random_range_iterator(0, TOTAL_NUM_VALUES, max_step_size),
+        )
     }
 
     fn walk_over_data_from_positions(
@@ -375,17 +379,31 @@ mod bench {
     }
 
     #[bench]
-    fn bench_dense_codec_translate_orig_to_dense_80percent_filled_random_stride(
+    fn bench_dense_codec_translate_orig_to_dense_90percent_filled_random_stride(
         bench: &mut Bencher,
     ) {
-        let codec = gen_bools(0.8f64);
+        let codec = gen_bools(0.9f64);
         bench.iter(|| walk_over_data(&codec, 100));
     }
 
     #[bench]
-    fn bench_dense_codec_translate_orig_to_dense_10percent_full_scan(bench: &mut Bencher) {
+    fn bench_dense_codec_translate_orig_to_dense_50percent_filled_random_stride(
+        bench: &mut Bencher,
+    ) {
+        let codec = gen_bools(0.5f64);
+        bench.iter(|| walk_over_data(&codec, 100));
+    }
+
+    #[bench]
+    fn bench_dense_codec_translate_orig_to_dense_full_scan_10percent(bench: &mut Bencher) {
         let codec = gen_bools(0.1f64);
-        bench.iter(|| walk_over_data_from_positions(&codec, 0..NUM_VALUES));
+        bench.iter(|| walk_over_data_from_positions(&codec, 0..TOTAL_NUM_VALUES));
+    }
+
+    #[bench]
+    fn bench_dense_codec_translate_orig_to_dense_full_scan_90percent(bench: &mut Bencher) {
+        let codec = gen_bools(0.9f64);
+        bench.iter(|| walk_over_data_from_positions(&codec, 0..TOTAL_NUM_VALUES));
     }
 
     #[bench]
@@ -397,10 +415,23 @@ mod bench {
     }
 
     #[bench]
-    fn bench_dense_codec_translate_dense_to_orig_80percent_filled_random_stride(
+    fn bench_dense_codec_translate_dense_to_orig_90percent_filled_random_stride_big_step(
         bench: &mut Bencher,
     ) {
-        let codec = gen_bools(0.8f64);
+        let codec = gen_bools(0.9f64);
+        let num_vals = codec.num_non_null_vals();
+        bench.iter(|| {
+            codec
+                .translate_codec_idx_to_original_idx(random_range_iterator(0, num_vals, 50_000))
+                .last()
+        });
+    }
+
+    #[bench]
+    fn bench_dense_codec_translate_dense_to_orig_90percent_filled_random_stride(
+        bench: &mut Bencher,
+    ) {
+        let codec = gen_bools(0.9f64);
         let num_vals = codec.num_non_null_vals();
         bench.iter(|| {
             codec
@@ -408,4 +439,15 @@ mod bench {
                 .last()
         });
     }
+
+    #[bench]
+    fn bench_dense_codec_translate_dense_to_orig_90percent_filled_full_scan(bench: &mut Bencher) {
+        let codec = gen_bools(0.9f64);
+        let num_vals = codec.num_non_null_vals();
+        bench.iter(|| {
+            codec
+                .translate_codec_idx_to_original_idx(0..num_vals)
+                .last()
+        });
+    }
 }