diff --git a/columnar/src/columnar/column_type.rs b/columnar/src/columnar/column_type.rs index ad1fcb2c0..6f9cf99e5 100644 --- a/columnar/src/columnar/column_type.rs +++ b/columnar/src/columnar/column_type.rs @@ -147,21 +147,6 @@ mod tests { } } - #[test] - fn test_column_category_sort_consistent_with_column_type_sort() { - // This is a very important property because we - // we need to serialize colunmn in the right order. - let mut column_types: Vec = super::COLUMN_TYPES.iter().copied().collect(); - column_types.sort_by_key(|col| col.to_code()); - let column_categories: Vec = column_types - .into_iter() - .map(ColumnTypeCategory::from) - .collect(); - for (prev, next) in column_categories.iter().zip(column_categories.iter()) { - assert!(prev <= next); - } - } - #[test] fn test_cardinality_to_code() { let mut num_cardinality = 0; diff --git a/columnar/src/columnar/writer/mod.rs b/columnar/src/columnar/writer/mod.rs index dfd3acbb8..43d3f6620 100644 --- a/columnar/src/columnar/writer/mod.rs +++ b/columnar/src/columnar/writer/mod.rs @@ -45,7 +45,7 @@ struct SpareBuffers { /// columnar_writer.record_str(1u32 /* doc id */, "product_name", "Apple"); /// columnar_writer.record_numerical(0u32 /* doc id */, "price", 10.5f64); //< uh oh we ended up mixing integer and floats. /// let mut wrt: Vec = Vec::new(); -/// columnar_writer.serialize(2u32, &mut wrt).unwrap(); +/// columnar_writer.serialize(2u32, None, &mut wrt).unwrap(); /// ``` pub struct ColumnarWriter { numerical_field_hash_map: ArenaHashMap,