From f262d4cc22a2ab56359683d13663dd13c09afe38 Mon Sep 17 00:00:00 2001 From: Paul Masurel Date: Fri, 8 Feb 2019 14:54:34 +0900 Subject: [PATCH] code cleaning --- src/indexer/index_writer.rs | 4 ++-- src/indexer/segment_manager.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/indexer/index_writer.rs b/src/indexer/index_writer.rs index 83fe75848..df9e1426a 100644 --- a/src/indexer/index_writer.rs +++ b/src/indexer/index_writer.rs @@ -522,7 +522,7 @@ impl IndexWriter { // // This will reach an end as the only document_sender // was dropped with the index_writer. - for _ in document_receiver.clone() {} + for _ in document_receiver.iter() {} Ok(()) } @@ -553,7 +553,7 @@ impl IndexWriter { self.prepare_commit_internal(false) } - pub(crate) fn prepare_commit_soft(&mut self) -> Result { + pub fn prepare_commit_soft(&mut self) -> Result { info!("Preparing soft commit"); self.prepare_commit_internal(true) } diff --git a/src/indexer/segment_manager.rs b/src/indexer/segment_manager.rs index 1b84a0d0b..8d2f15add 100644 --- a/src/indexer/segment_manager.rs +++ b/src/indexer/segment_manager.rs @@ -154,7 +154,7 @@ impl SegmentManager { // TODO make sure we use `committed_in_the_future` segments, // when we `commit`, to avoid replaying deletes several times. - } else if let Some(uncommitted_segment) = registers_lock.uncommitted.get(&segment_id) { + } else if registers_lock.uncommitted.get(&segment_id).is_some() { // This will override our previous entry. registers_lock.uncommitted.register_segment_entry(segment_entry); }