cmd.Which() previously shelled out to `which <name>` to determine whether
a binary was on PATH. On distributions that do not ship a `which` package
by default — Arch Linux is the canonical example, but the same applies to
several minimal container images — `which` itself is missing, so every
call to Which() returned false and 1Panel reported core dependencies
(notably Docker) as 'not installed' even when they were running normally.
Switch the primary path to Go's exec.LookPath, which uses the process
PATH directly and has no external dependency. The original shell-out is
preserved as a fallback so any environment where the agent's PATH
differs from the user's interactive shell PATH (the original reason the
shell-out existed) keeps working unchanged.
Both copies are updated (agent/utils/cmd/cmd.go and core/utils/cmd/cmd.go)
and a small unit test is added to each package to guard the regression.
Fixes#12605
Signed-off-by: Sanjay Santhanam <51058514+Sanjays2402@users.noreply.github.com>
* refactor: replace DownloadFileWithProxy with DownloadFileWithProxyStream for improved file downloading logic
* refactor: remove commented-out DownloadFileWithProxy function to clean up code
* feat: Add passkey authentication support with registration and login endpoints
* style: Refactor import statements and improve button formatting in login and settings views
* chore: Update dependencies in go.mod and go.sum, including adding go-webauthn and updating indirect dependencies
* refactor: Consolidate passkey session management and update related structures for improved clarity and functionality
* feat: Add passkey support in multiple languages with corresponding error messages and management options
* feat: Implement passkey reset command and enhance internationalization support for passkey-related messages
* refactor: Simplify login form structure by removing commented sections and unused passkey login function
* fix: Update passkey failure messages across multiple languages to include SSL certificate verification instructions
* chore: update go mod
* refactor: Update passkey handling by consolidating status checks and renaming related fields for clarity
* style: Format i18n file
* refactor: Enhance passkey configuration checks
ssongliu
zhengkunwang223
王贺
Sanjay Santhanam
蘭
ssongliu
KOMATA
巴山夜语