From 3b594198c7ac1fde74b3ff5019a2066598d4e6fa Mon Sep 17 00:00:00 2001
From: KKRainbow <5665404+KKRainbow@users.noreply.github.com>
Date: Wed, 4 Nov 2026 10:24:02 +0800
Subject: [PATCH] test(three_node): gate port-forward ACL test on routable
 destinations (#2795)

The port-forward ACL test starts its pingpong as soon as
`init_three_node_ex` observes two peer route snapshots. The port
forward, however, resolves its destination through the outbound packet
router, which can still miss the destination at that point. In that
window `connect_tcp` fails immediately, the accepted client connection
is dropped, and the pingpong read observes `Connection reset by peer`.

Observed in PR #2793 CI run 41731902400 (case_2, dhcp=true): the same
commit passed on a rerun, confirming the race rather than a code
regression.

Wait until the outbound router resolves both forward destinations
before starting the pingpong, so the first forwarded connection is no
longer reset by a transient lookup miss. The pingpong assertions are
unchanged.
---
 easytier/src/tests/three_node.rs | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/easytier/src/tests/three_node.rs b/easytier/src/tests/three_node.rs
index 7b4299c9..742e64b6 100644
--- a/easytier/src/tests/three_node.rs
+++ b/easytier/src/tests/three_node.rs
@@ -3340,6 +3340,28 @@ pub async fn port_forward_with_inbound_default_drop_acl_test(
         .await;
     }
 
+    // The port forward resolves its destination through the outbound packet
+    // router, which can lag behind the peer route snapshots that
+    // `init_three_node_ex` waits for. Gate on the router itself so the first
+    // forwarded connection is not reset by a transient lookup miss.
+    for dst in ["10.144.144.3", "10.1.2.4"] {
+        let dst: std::net::Ipv4Addr = dst.parse().unwrap();
+        wait_for_condition_named(
+            || async {
+                !insts[0]
+                    .get_core_instance()
+                    .peer_manager()
+                    .get_msg_dst_peer_ipv4(&dst)
+                    .await
+                    .0
+                    .is_empty()
+            },
+            Duration::from_secs(10),
+            "port forward destination route",
+        )
+        .await;
+    }
+
     for (bind_port, server_ns) in [
         (23456, network.namespace("net_c")),
         (23457, network.namespace("net_d")),