From 03878aed8bf5235dcd22cb9f4dc63b41eb308d94 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Fri, 13 Nov 2026 04:33:33 -0800 Subject: [PATCH] Provide settled writes for recovery mailbox regression --- .../agent-transcript-pane-test-harness.ts | 3 +++ .../terminal/wait/tui-idle-hook-lane-runtime.test.ts | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main/runtime/orca-runtime-tests/agent-transcript-pane-test-harness.ts b/src/main/runtime/orca-runtime-tests/agent-transcript-pane-test-harness.ts index e98cba75542..776a43ce33b 100644 --- a/src/main/runtime/orca-runtime-tests/agent-transcript-pane-test-harness.ts +++ b/src/main/runtime/orca-runtime-tests/agent-transcript-pane-test-harness.ts @@ -6,6 +6,7 @@ import type { TerminalProcessInspection as PtyProcessInspection } from '../../.. import type { RuntimeStore } from '../construction/runtime-store-contract' import { ORCA_LAYOUT_OWNER_IS_MAIN } from '../../../shared/layout-owner-switch' import { committingSpawn, registerBoundPty } from './bind-first-pane.test-fixture' +import type { RuntimePtyController } from '../terminal/lifecycle/runtime-pty-controller-contract' const TRANSCRIPT_PANE_LEAF_ID = '11111111-1111-4111-8111-111111111111' const TRANSCRIPT_PANE_TAB_ID = 'tab-1' @@ -33,6 +34,7 @@ export type TranscriptPaneOptions = { paneRootPid?: number onShellForegroundProof?: () => void onWrite?: (data: string) => void + writeWithSettlement?: RuntimePtyController['writeWithSettlement'] } function transcriptLayoutStore(): RuntimeStore { @@ -93,6 +95,7 @@ export async function createTranscriptPane( options.onWrite?.(data) return true }, + ...(options.writeWithSettlement ? { writeWithSettlement: options.writeWithSettlement } : {}), kill: () => true, getSize: () => options.size ?? null, getForegroundProcess: (): Promise => { diff --git a/src/main/runtime/terminal/wait/tui-idle-hook-lane-runtime.test.ts b/src/main/runtime/terminal/wait/tui-idle-hook-lane-runtime.test.ts index 66bf8271e5f..700cc92fad8 100644 --- a/src/main/runtime/terminal/wait/tui-idle-hook-lane-runtime.test.ts +++ b/src/main/runtime/terminal/wait/tui-idle-hook-lane-runtime.test.ts @@ -18,6 +18,7 @@ import type { AgentStatusIpcPayload } from '../../../../shared/agent-status/cont import { makePaneKey } from '../../../../shared/workspace-layout/stable-pane-id' import type { TuiAgent } from '../../../../shared/agent-launch/catalog/tui-agent' import type { OrcaRuntimeService } from '../../orca-runtime' +import { settledWriteStub } from '../../../providers/testing/settled-pty-write-stub' vi.mock('electron', () => ({ BrowserWindow: { fromId: vi.fn(() => null) }, @@ -63,7 +64,10 @@ describe('Hermes captured hook readiness', () => { launchAgent: 'hermes', size, data: captured, - onWrite: (data) => writes.push(data) + onWrite: (data) => writes.push(data), + writeWithSettlement: settledWriteStub((_id, data) => { + writes.push(data) + }) }) await runtime.serializeMainTerminalBuffer(TRANSCRIPT_PANE_PTY_ID) writes.length = 0