From 0ae9ca7aa05d04bb7df35968a114bca3491853ce Mon Sep 17 00:00:00 2001 From: Kelvin Amoaba <97001695+AmoabaKelvin@users.noreply.github.com> Date: Wed, 11 Nov 2026 09:15:41 +0000 Subject: [PATCH] fix(jcode): read the bare title tail only in a Jcode pane The activity tail on conversation and SSH titles is too generic to prove an agent, so title-only readers must not treat it as one. Gate it on the pane's agent, as Hermes markers are, keep identity titles self-describing, narrow the server segment, and keep the title strip linear. --- .../output/terminal-title-observation.ts | 5 ++- .../worktree-title-derived-agent-rows.ts | 3 +- .../agent-status/title/agent-title-status.ts | 4 +-- .../title/providers/jcode-terminal-title.ts | 36 ++++++++++++------- src/shared/jcode-agent-identity.test.ts | 20 +++++++---- 5 files changed, 44 insertions(+), 24 deletions(-) diff --git a/src/main/runtime/terminal/output/terminal-title-observation.ts b/src/main/runtime/terminal/output/terminal-title-observation.ts index 6d0b0c76879..a81fc7fbe7f 100644 --- a/src/main/runtime/terminal/output/terminal-title-observation.ts +++ b/src/main/runtime/terminal/output/terminal-title-observation.ts @@ -7,6 +7,7 @@ import { terminalTitleBlocksExplicitAgentStatus } from '../../workspaces/process import type { ClaudeTerminalEvidence } from '../../../../shared/claude-terminal-interrupt' import { agentStatusTakesTypedInput } from '../../orchestration/mailbox/routing/mailbox-owner' import { hermesNativeTitleStatus } from '../../../../shared/agent-status/title/providers/hermes-terminal-title' +import { jcodePaneTitleStatus } from '../../../../shared/agent-status/title/providers/jcode-terminal-title' export abstract class OrcaRuntimeWithApplyTrackedPtyTitle extends OrcaRuntimeWithGetUnpersistedTrackedTitleForPty { protected abstract collectPaneKeysForPty(ptyId: string): Set @@ -53,9 +54,11 @@ export abstract class OrcaRuntimeWithApplyTrackedPtyTitle extends OrcaRuntimeWit /** The PTY's agent status under this title: the program's own OSC 7501 activity while it * reports one, else what the title glyph says. */ protected classifyPtyTitleStatus(ptyId: string, rawTitle: string): AgentStatus | null { + const agent = this.getPaneTerminalAgent(ptyId) return ( this.ptyTitleTrackersByPtyId.get(ptyId)?.programActivity ?? - hermesNativeTitleStatus(rawTitle, this.getPaneTerminalAgent(ptyId)) ?? + hermesNativeTitleStatus(rawTitle, agent) ?? + jcodePaneTitleStatus(rawTitle, agent) ?? detectAgentStatusFromTitle(rawTitle) ) } diff --git a/src/renderer/src/components/sidebar/workspace-card/activity/worktree-title-derived-agent-rows.ts b/src/renderer/src/components/sidebar/workspace-card/activity/worktree-title-derived-agent-rows.ts index c3b5296cf45..21572a2c9d2 100644 --- a/src/renderer/src/components/sidebar/workspace-card/activity/worktree-title-derived-agent-rows.ts +++ b/src/renderer/src/components/sidebar/workspace-card/activity/worktree-title-derived-agent-rows.ts @@ -8,6 +8,7 @@ import { import { detectAgentStatusFromTitle } from '../../../../../../shared/agent-status/title/agent-title-status' import { getAgentLabel } from '../../../../../../shared/agent-status/title/agent-title-identity' +import { jcodePaneTitleStatus } from '../../../../../../shared/agent-status/title/providers/jcode-terminal-title' import { tabHasLivePty } from '../../../../../../shared/tab-has-live-pty' import type { AgentStatusEntry, @@ -182,7 +183,7 @@ function buildTitleDerivedAgentRow(args: { return null } // Why: the title sets activity only; a plain title on a process-identified pane is idle. - const status = titleStatus ?? 'idle' + const status = titleStatus ?? jcodePaneTitleStatus(title, agentType) ?? 'idle' const rowLabel = agentType === titleAgentType && label && diff --git a/src/shared/agent-status/title/agent-title-status.ts b/src/shared/agent-status/title/agent-title-status.ts index 49696e2ae42..3e6c362b1fd 100644 --- a/src/shared/agent-status/title/agent-title-status.ts +++ b/src/shared/agent-status/title/agent-title-status.ts @@ -1,6 +1,6 @@ import { getDeepSeekBuildTitleStatus } from './providers/dsb-terminal-title' import { qoderTitleStatus } from './providers/qoder-terminal-title' -import { jcodeTitleStatus } from './providers/jcode-terminal-title' +import { jcodeIdentityTitleStatus } from './providers/jcode-terminal-title' import { cursorTitleStatus } from './providers/cursor-terminal-title' import { AGY_AGENT_NAME_RE, @@ -280,7 +280,7 @@ function computeAgentStatusFromTitle(title: string): AgentStatus | null { if (title.startsWith(`${CLAUDE_IDLE} `) || title === CLAUDE_IDLE) { return 'idle' } - const jcodeStatus = jcodeTitleStatus(title) + const jcodeStatus = jcodeIdentityTitleStatus(title) if (jcodeStatus) { return jcodeStatus } diff --git a/src/shared/agent-status/title/providers/jcode-terminal-title.ts b/src/shared/agent-status/title/providers/jcode-terminal-title.ts index 30631c5e4d3..23bda185bb5 100644 --- a/src/shared/agent-status/title/providers/jcode-terminal-title.ts +++ b/src/shared/agent-status/title/providers/jcode-terminal-title.ts @@ -2,36 +2,46 @@ import { CLAUDE_IDLE } from '../agent-title-glyphs' // jcode updates emoji/session/diff/duration titles about once a second (terminal_title.rs); generated codenames are identity, not conversation names. // Captured provenance: docs/reference/jcode-hook-events.md. +// (?