From b3fef58adcf4246b4c9ef2fff07cf2dc93a2824b Mon Sep 17 00:00:00 2001 From: Jinwoo-H Date: Mon, 9 Nov 2026 20:38:34 -0500 Subject: [PATCH] perf(terminal): find OSC 133 markers by their rare ']' instead of ESC --- .../output/terminal-osc133-command-finished.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/shared/terminal/output/terminal-osc133-command-finished.ts b/src/shared/terminal/output/terminal-osc133-command-finished.ts index 255514c9c1f..c2bc50b77a3 100644 --- a/src/shared/terminal/output/terminal-osc133-command-finished.ts +++ b/src/shared/terminal/output/terminal-osc133-command-finished.ts @@ -8,6 +8,7 @@ type OscTerminator = { } const OSC_133_PREFIX = '\x1b]133;' +const OSC_133_BODY = OSC_133_PREFIX.slice(1) const MAX_OSC_CARRY_LENGTH = 4096 function findOscTerminator(data: string, startIndex: number): OscTerminator | null { @@ -31,6 +32,16 @@ function parseBestEffortExitCode(value: string | undefined): number | null { return Number.isNaN(parsed) ? null : parsed } +// Why: ESC starts nearly every TUI escape, so searching the rare ']' first is ~4x faster on agent output. +function findOsc133Prefix(data: string): number { + for (let i = data.indexOf(OSC_133_BODY, 1); i !== -1; i = data.indexOf(OSC_133_BODY, i + 1)) { + if (data.charCodeAt(i - 1) === 0x1b) { + return i - 1 + } + } + return -1 +} + function findPrefixCarry(data: string): string { const maxCarryLength = Math.min(data.length, OSC_133_PREFIX.length - 1) for (let length = maxCarryLength; length > 0; length -= 1) { @@ -96,7 +107,7 @@ export function createOsc133CommandFinishedScanner( carry = '' while (combined.length > 0) { - const start = combined.indexOf(OSC_133_PREFIX) + const start = findOsc133Prefix(combined) if (start === -1) { carry = findPrefixCarry(combined) if (carry.length < combined.length) {