* Open search-result agent setup as a hover submenu
The + menu's search-result agent rows opened setup through a separate
click popover. Route them through the same native submenu the regular
agent rows use, delete the popover path, and keep hover from moving
focus off the omnibox input.
* Keep omnibox typing in the search box when agent setup opens or closes
Hovering a search row's › no longer moves focus into the setup panel, and
Escape, ArrowLeft or leaving the open row return focus to the search input.
Also stop dimming disabled setup rows twice.
* Give omnibox agent setup pointer grace before another row closes it
Crossing an ordinary result on the way to the panel no longer closes the
setup; another row closes it after 300 ms unless the pointer reaches the
panel or returns to its row, like Radix submenus.
* Keep a hover-opened omnibox setup from taking focus after a keystroke
Typing can shift a row under a resting pointer and open its setup while
Radix is in keyboard mode; its content autofocus now returns to the
search input until the pointer moves into the panel.
* Open omnibox agent setup on pointer movement, and keep panel typing on leave
Per the decider ruling: a row shifting under a resting pointer no longer
opens its setup (Radix sub-triggers also open on pointermove), and leaving
the row after clicking › keeps focus in the setup editor instead of moving
typing back to the search box.
* Return omnibox focus to the search box when a focused setup closes on its own
Clicking › and then moving to another row let the hover grace close the
panel while it held focus, dropping focus to the page; closing it now
returns typing to the search input.
* Test that a caller-closed setup returns focus to the omnibox input
* Render omnibox search tests inside the + menu so agent setup has its menu
* Keep omnibox setup wiring React Compiler friendly
Build each row's setup handlers at the call site from plain hook state, and
configure the launched option inside the handler, so nothing that reads refs
runs during render.
* Open the branch picker from the branch name under the chat composer
* Copy the current branch from its row in the composer's branch picker
* Keep the composer copy button clickable and out of the list's keyboard, and keep a twin copy's status out of the picker
* Read a twin copy's status privately in the branch picker and drop refreshes that land after its twin is selected
* Block on a twin's returned read error, re-read after the picker closes itself, and distrust a twin's leftover status on becoming owner
* Build the environment name selector outside the component so the React compiler can lower the picker
* Trust a copy's status again once its picker refresh settles, even when an identical newer poll superseded it
* Read a newly owning copy's own status until the inherited slot changes, instead of trusting a settled refresh
* Route the composer picker through the copy's owner and block while this chat's turn is active
* Keep the composer picker's agent gate on the shared working check, as in Source Control
* Show CI result lines on the phone, following the desktop setting
The host now sends nativeChatCiResultLines resolved in settings.get, the
ready snapshot and a nativeChatCiResultLinesChanged event, from one
publisher that tracks each pushed chat preference separately. The phone
keeps one store per desktop connection and preference, reads the CI value
only from the paired desktop, and hides the lines until that desktop
reports one. CI rows stay in the projection and are filtered after it, so
a flip rebuilds nothing. The phone draws the line with links to the pull
request and commit.
* Let the phone CI line wrap and select like other notices
Long repository names at large font scale no longer push the commit link
past an ellipsis: the line wraps, centered, with the icon on its first
line. Its text follows the system-notice selection policy, so iOS selects
natively and Android keeps the long-press actions sheet. The CI strings
are translated in every mobile locale, the filter copies only once it
meets a CI row, and the tests drop a token assertion and a duplicate case.
* Draw CI results as one-line cards on desktop and phone
The CI result line becomes a one-line card in the same frame as the
opened pull request card, with the Hide button inline at its right end
on desktop, and in the phone's chat card frame without one. Only the
lead and pull request name truncate, so the commit link and the Hide
button stay reachable on narrow widths. The fixture uses real
percent-encoded item ids so its links render.
* Make the CI card's whole lead open its pull request
A translated lead at large font scale can push the ellipsis before
repo#N, which left no visible way to open the pull request. The
truncating segment is now the pull request's target on desktop and
phone, named for it, while "at <sha>" stays the commit's own target.
The ja, zh and zh-Hant leads use a plain colon so the space after it
isn't doubled.
* Read the CI result lines setting only for structured chats
CI result lines come only from structured sessions' journals, so a
terminal chat no longer sends the setting read. The prompt-controller
fixture stubs the setting hook: its tests count only the chat's prompt
writes, and the structured chat's one read per desktop connection is
expected.
* refactor: import journal queue state from defining owners
* refactor(shared): organize execution and automation owners
* fix: retain type imports used by surviving test cases
* refactor: finish work item owners and refresh validation metadata
* test: infer reconnect status fixture type
* test(claude): resolve source files beside same-named directories
* test(runtime): group repository creation mock registrations
* chore(lint): bump oxlint to 1.91, add perf lint rules and perf audits
* fix(lint): await promises returned inside try/catch/finally for return-await
Prepare typescript/return-await with error-handling-correctness-only: await
returns whose catch or finally was meant to cover them, and suppress the eight
sites where the catch must not re-handle the returned promise.
* chore(lint): enable return-await (error-handling-correctness-only); exempt secondary-scan directives in the changed gate
* refactor(mobile): move file preview discard modal into its own module
Keeps MobileFilePreviewScreen under the 400-line limit after merging main.
---------
Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local>
* fix(window): cancelling a quit prompt now cancels the quit
Renderer-owned quit prompts (running-work "Close Window?", Save dialog,
close-guard and shutdown-checkpoint vetoes) never reach
will-prevent-unload, so main kept isQuitting latched after Cancel. A later
plain close was treated as a quit and renderer crashes were not recovered.
Add a window:close-cancelled IPC (preload ui.cancelWindowClose; no-op in the
web client) that the renderer sends on each cancel path. Main accepts it only
from its own renderer, only while quitting, and only once that renderer has
acknowledged the newest close request, then runs the same abort path as a
beforeunload veto.
Fixes#39596
Co-authored-by: Neil <neil@stably.ai>
* test(window): expose webContents.send on the renderer recovery harness type
---------
Co-authored-by: tomarai85 <tomarai85@users.noreply.github.com>
Co-authored-by: Neil <neil@stably.ai>
On Windows, Hankaku/Zenkaku commits the Japanese composition as a
Process/229 keydown that may never send a keyup. The composer treated any
Process/229 keydown as an IME-confirm Enter and armed the carry, so the
user's next real Enter was swallowed. Only arm the carry when the
processed key's physical code is Enter (or unknown), sharing the code
check with the terminal IME path.
Fixes#39289
* perf(main): overlap independent fs probes on git status, agent detection and orcad startup
* perf: skip per-entry copies in git change list and tab hydration; drop unused activity barrel
Adds commit actions to the Git Graph: check out a commit or branch, cherry-pick, revert, and create a branch from a commit. Conflicts hand off to Source Control with continue and abort. Works on local, WSL and remote hosts.
A folder workspace with no worktrees now offers Create worktree for each repository, named after the folder workspace. If that branch name is already taken, the host refuses instead of picking another name, and the composer opens so you can choose.
With Hide sleeping on, deleting the active workspace activated the most
recently visited sibling (or main) and seeded it a terminal, so a hidden
sleeping row popped back into the sidebar. The removal successor now
skips siblings the sleeping sweep hides, using the same check the
sidebar's reveal path uses and honoring rows held through the PTY-rebind
grace window. With no eligible sibling the user lands on the start screen.
Fixes#39231
Co-authored-by: Neil <neil@stably.ai>
Command, Environment and Codex's session source home now use Input's
code variant, so they render at text-xs instead of md:text-sm above
768px. The Arguments label matches its siblings' text-xs style, and the
Arguments wrapper uses py-0.75 so its text is vertically centred.
Co-authored-by: Neil <neil@stably.ai>
List the Bitbucket API token scopes Orca needs (read:user, read:repository,
read:pullrequest, write:pullrequest) in the Email & API token form so users
configure a working token up front instead of hitting missing-permission
errors when creating a pull request. Strings are translated in every locale.
Fixes#38652
Co-authored-by: Neil <neil@stably.ai>
* Open the new-tab landing when splitting a Chat UI pane
Splitting a chat with Cmd+D opened a terminal nobody asked for. The split now
opens an empty pane that shows the home-screen landing (New agent, New
Terminal, New Browser Tab, plus shortcuts); Cmd+W closes it. Chats in the
floating panel and inside terminal tabs keep their terminal split.
* Split landing review fixes: agent launch cancellation, browser policy, labels
- New Agent on the landing cancels like the keyboard shortcut when the user leaves the workspace or host
- Hide New Browser Tab where the creation policy hides it (paired web without streaming)
- Chat split actions read Split Right / Split Down; New Agent gets its own key
- Tour visibility reads the projection's existing group subscriptions
* Show the split landing only in panes a chat split opened
Other flows reserve an empty split group for content they already chose
(remote terminal splits, AI Vault resume, browser and source-control
opens). The landing, its Close collapse and the tour now apply only to
groups the chat split marked, kept in window-only state and dropped when
the group goes away.
* Move split landing marks with their groups on worktree rename
* Keep the rename test's chooser mark out of the cast fixture
* Read the landing's browser policy by workspace; keep Agent in the Japanese label
* Keep the passed split lesson in the agent sessions tour count
* Keep the workspace open on a waiting split landing when its last tab closes
* Keep a waiting split landing when its workspace is reopened; drop its close row when it is the only pane
* Let a waiting split landing satisfy automatic default seeding, not recovery
Restores main's agent-activation inventory gate (a chooser never bypasses
ownership checks). Each automatic default-surface decision (shared seeder,
deferred reseed, startup watcher, paired wake, stream bootstrap) now leaves
a waiting chooser in place, and the paired mirror keeps a marked chooser when
the host reports no tabs. Explicit launches and requested default tabs are
unchanged.
* Fill an emptied paired workspace with its waiting landings, layout and focus together
* Read landing labels through useTranslate for main's render-path ratchet
* Drop the split landing's subtitle
* fix(settings): unify terminal theme pickers
Reuse the Appearance searchable selector and palette swatches while preserving imported-theme actions and independent terminal theme slots.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(settings): don't replay a handled theme import after remount
Settings search unmounts the theme row, so the picker remounted with
handledImportSignal=0 and reopened at Imported without a new import.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat(sidebar): simplify delete workspace dialog
Replace the "Don't ask again" checkbox with an "Always delete" option in a
split-button dropdown on the Delete button, matching the force-delete toasts.
Shorten the description and change-loss copy so the dialog reads lighter.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix(sidebar): keep delete change-loss warning protected and shown when status is unknown
Default Delete forces removal, so restore the permanent-loss notice while a
target's Git status is still checking or unavailable. Mark the dirty-change
hint as protected copy so language packs cannot replace the loss warning.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Add project dialog focused Browse in a mount effect before its focus
trap registered, so the composer trap bounced focus back to the Project
field, which reopened the project list on top of the new dialog.
Focus Browse from the dialog's onOpenAutoFocus instead, and close the
project list when focus leaves the field and its popup.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Use Ctrl+K for search on Linux and Windows
Preserve existing search and terminal clear shortcuts for legacy profiles until reset.
* Preserve existing Windows and Linux search shortcuts on rollout
* Preserve saved shortcuts in new profiles
* Keep window shortcut tests independent of defaults
* fix(terminal): send one ACK overflow recovery image per drained window
Recovery snapshots bypass ACK windows, so on a link slower than a flooding
TUI each ACK while overflowed published another full-screen image behind
the queued window. Measured through real orcad over a 1 Mbit/s shaped link
this queued images without bound: keystroke echo grew from 22s to 50s over
a 45s flood and the pane took 51s to settle. Holding the next image until
the output sent ahead of the previous one is acknowledged bounds that
queue to the window plus one image (echo <= 18s, settle 7s, 10x fewer
snapshot bytes). Server-only; no protocol change.
* fix(terminal): let adaptive ACK pacing engage under overflowing TUI floods
Through real orcad on a shaped 1 Mbit/s link, ORCA_TERMINAL_ADAPTIVE_ACK_WINDOW=1
never paced a 60fps full-screen TUI: once its queue overflowed, recovery
images cleared the queue, so later sends counted as idle trickle and the
estimate never collected window-limited samples. When it did, the images
(never acked) inflated paced RTT and tripped the divergence fallback.
- A stream whose output outran the window stays backlogged until an ACK
finds its queue empty, so sends after a recovery still measure the link.
- The estimate records recovery images: they count as queue ahead of later
sends (no drained/paced samples behind them) and as delivered bytes once
an ACK of a later send confirms them.
Shaped-link soak (1 Mbit/s, 50ms): echo p50 13s -> 2.2s, settle 7s -> 1.1s.
Bench gains a 6.4 MB/s TUI scenario: paced 7.7s -> 1.2s.
The batch skipped it because the rewrite would cross the line budget;
with the panel's current shape the converted file fits, so convert it
in place with no split.
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
* feat(agent-launch): simplify the new-tab agent launch menu
Drop Permissions and Arguments from the launch-mode setup panel; they are
agent defaults edited in Agent settings. Put effort levels (unlabeled) and
Fast mode on one row, and make the Launch chat/terminal buttons fill the
row at a larger size with icons. Select-mode pickers (automations, new
workspace, source control, continuation) keep both controls.
* fix(agent-launch): let current Agent settings win over launch-menu speed edits
A Fast or speed-tier edit copies the current Permissions and Arguments into the
launch draft. With no Arguments editor in the launch menu, a later settings
change was silently ignored. Launch drafts now drop Arguments stamped by older
settings; the speed choice still applies. Also stop pointing hosts without a
model list at the removed Arguments editor.
* fix(agent-launch): show Fast as a button in the launch menu
Matches the mock: an outlined Fast chip with the lightning icon in place of the
"Fast mode" switch. The chat composer keeps its switch.
* refactor(main): organize runtime implementation owners
* test: retire wall-clock CLI title recovery case
* refactor: route new folder mutation to runtime store owner
* test: import folder mutation store contract from its owner
Both would go over budget once converted. The send-target ordering and
the resume tree's group node move to their own modules first, then the
codemod converts the menu, its target rows and the resume tree nodes.
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
* feat(chat): /btw asks a side question in a fork beside the chat
In a Chat UI chat that can fork, /btw <question> (or /side) forks the chat
through its newest finished response, sends the question there, and moves the
fork beside the chat the way dragging it does. The source chat is untouched;
the draft clears only once the question went out. Agents that cannot fork keep
their own /btw.
* fix(chat): type-guard the side chat command names
* fix(chat): side chats own the screen from Send and never place an unsent question
- Placement starts at Send, retires for good on any other selection in the
workspace or on leaving it, and looks only at the requesting workspace.
- A question that never went out leaves its fork in the background; an
unconfirmed one says to check the side chat before asking again; a failure
the new chat already reported is not repeated.
- The command menu shows "Available after the first reply" / "when this reply
finishes" while it is open, using the drawn turn order.
- File pills count as attachments; picking /btw completes the row.
* fix(chat): /btw reads the newest response the drawn transcript offers Fork on
The menu reason and Send now follow the transcript's own Fork rule as drawn,
reported when it changes, instead of rebuilding turn membership in the composer.
* fix(chat): side chat failures always reach the source; watch window starts when the fork opens
- A failed side question toasts in the source even when the fork recorded it,
since the fork stays in the background.
- The 60 s placement window starts once the fork exists, not at Send.
- The fork-point scan stops at a /clear and, for tip-only agents, at the
newest turn; split placement looks only in the requesting workspace.
* fix(chat): /btw forgets a fork point the transcript no longer offers
- Send and the menu reason refuse a reported response that is no longer
forkable, and an unmounted transcript reports nothing to fork.
- The fork-point scan skips subagent sections before its early stops.
* perf(chat): /btw steps over a running turn instead of walking its rows
The slot builder groups root responses by turn in its existing pass; the side
chat's fork point reads those groups newest first and skips a running turn
whole, so streamed replies add no per-row work.
* fix(chat): /btw looks past responses outside any turn and skips the scan when nothing is forkable
* perf(chat): find the /btw fork point while laying out the transcript
Per the review ruling: the slot builder keeps the newest row that offers Fork
in its existing pass, only when /btw listens, and returns one point; the
response groups and their second search are gone.
* test(chat): /btw fork point contract through the transcript and Send hooks
* refactor(chat): response rows and /btw share one Fork rule
* test(chat): /btw fork point ignores pending-only renders and an emptied conversation
* test(chat): /btw contract counts every eligibility lookup and covers an undrawn transcript
* fix(chat): /btw shows ahead of agent commands, sends on one Enter, and focuses the side chat
- Side-chat rows lead the slash menu, so a long agent catalog no longer
pushes them past the menu's row limit.
- Enter on a fully typed /btw sends it instead of only completing the row.
- Placing the side chat also moves keyboard focus to its composer.
* fix(chat): picking /btw completes the row again, as the common pattern does
Sending a fully typed /btw from the menu bypassed a same-named skill's
release and sent on a mouse click; a pick now always leaves '/btw ' to
add a question to.
* fix(chat): on layout-owner builds the moved side chat keeps its composer focus
Main selects a tab it moved once its frame shows it there, so placement no
longer selects it first in the source pane; moveTabToNewPaneColumn reports
whether main or this window moved it, as moveTabToGroup does.
* fix(chat): side chat placement owns main-drawn moves through to the drawn result
Per the review ruling: the placement claim stays alive while main draws the
move, reads the side chat's own new pane and selection as its own, and selects
and focuses the side chat once the frame shows it moved, in place when main
refuses, and never after the user selected elsewhere. The owner command takes
an optional completion in place of its own moved-tab selection.
* fix(chat): selecting the side chat in the pane it is leaving still retires the claim
Only what main's move changes elsewhere (a new pane holding only the side
chat, another pane showing it) reads as the request's own; the selection
counter in the placement contract reads every pane's selection, and the move
helpers' completion is exercised through main's frame transport.
* fix(chat): a side chat main never moves is selected where Fork put it
When main neither draws nor answers the move before the watch ends, the
side chat is selected in place rather than left hidden; the owner command's
completion path (no moved-tab intent, hand-back asks first) is tested.
* fix(chat): a side chat this window moves keeps its focus request
The move's own changes count as the request's from before the move starts,
so a synchronous move no longer retires the claim before the side chat is
selected and focused.
* fix(chat): picking an unavailable /btw row does nothing, as the common pattern does
* refactor(native-chat): keep /btw hooks compilable by React Compiler
* fix(chat): say side chats aren't ready while a fork from the chat is opening
* test(chat): assert the opening-fork refusal without its copy
* fix(native-chat): share one latest-turn scan between /btw and transcript rows
Without the provider useTranslate() falls back to the stable module
translate(), so `t` never changes in the test and only an unmemoized
render could pass it. Mount it the way the app does.
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Applies pnpm i18n:reactive-translate --helpers. Output is unchanged: t delegates
to translate() and helpers default the threaded parameter.
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Three tests only counted how often facet, measurement and query passes
ran, and a fourth checked a zero count beside its real assertion.
AGENTS.md bans work-count tests, and they fail under React Compiler,
which memoizes differently. The behavior checks stay.
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>