starred/camoufox
1
0
Fork 0
mirror of https://github.com/daijro/camoufox.git synced 2026-08-19 00:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #273 from joaoneves0/fix/xvfb-leak

Browse Source 
fix: Ensure virtual_display is killed even if browser.close fails
This commit is contained in:
daijro
2026-01-11 23:38:28 -06:00
committed by GitHub
parent 2e98b57693 fd1bb2f878
commit 90c916e708
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pythonlib/camoufox/utils.py
+14 -6
View File
@@ -317,9 +317,13 @@ async def async_attach_vd(
_close = browser.close
async def new_close(*args: Any, **kwargs: Any):
await _close(*args, **kwargs)
if virtual_display:
virtual_display.kill()
try:
await _close(*args, **kwargs)
except Exception:
raise
finally:
if virtual_display:
virtual_display.kill()
browser.close = new_close
browser._virtual_display = virtual_display
@@ -339,9 +343,13 @@ def sync_attach_vd(
_close = browser.close
def new_close(*args: Any, **kwargs: Any):
_close(*args, **kwargs)
if virtual_display:
virtual_display.kill()
try:
_close(*args, **kwargs)
except Exception:
raise
finally:
if virtual_display:
virtual_display.kill()
browser.close = new_close
browser._virtual_display = virtual_display