mirror of
https://github.com/daijro/camoufox.git
synced 2026-10-04 16:00:21 +00:00
Jake WriterandClaude Opus 5.5
e8989c4291
Proxy.as_string() and ProxyHelper.asString() pasted the username and password into scheme://user:pass@host:port unencoded. A password holding `#`, `/` or `?` made the URL unparseable (requests: InvalidURL, impit: "Failed to build Impit instance"), so public_ip() and proxy_exit_geo() reported a working proxy as dead; a password holding `%41` parsed but was decoded, and the gateway was sent `A` instead. Playwright gets the credentials as separate fields, so only the lookup was affected. Encode both with quote(safe='') / encodeURIComponent. Checked against a local proxy recording Proxy-Authorization: requests and impit both decode the encoded form back to the exact credentials. Reported-by: alkaz-nodemaven (https://github.com/daijro/camoufox/issues/823) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
110 lines
4.1 KiB
Python
110 lines
4.1 KiB
Python
"""NewContext derives the WebRTC IP and timezone from the proxy's exit IP.
|
|
|
|
Two defects, both of which left a context with the host's WebRTC IP and
|
|
timezone while its traffic went through the proxy:
|
|
|
|
- The lookup built its own proxy URL with urlparse, which reads a scheme-less
|
|
server such as "1.2.3.4:8080" (a form Playwright accepts) as scheme "1.2.3.4"
|
|
and drops the host.
|
|
- A failed lookup was swallowed, and the context launched without the values.
|
|
"""
|
|
|
|
import asyncio
|
|
from unittest import mock
|
|
from urllib.parse import unquote, urlsplit
|
|
|
|
import pytest
|
|
|
|
from camoufox import async_api, ip, sync_api
|
|
from camoufox.exceptions import InvalidIP
|
|
|
|
|
|
class _Response:
|
|
def __init__(self, payload):
|
|
self._payload = payload
|
|
|
|
def raise_for_status(self):
|
|
pass
|
|
|
|
def json(self):
|
|
return self._payload
|
|
|
|
|
|
EXIT = {"status": "success", "query": "203.0.113.7", "timezone": "Europe/Paris"}
|
|
|
|
|
|
def _sync_browser():
|
|
browser = mock.MagicMock()
|
|
browser.version = "152.0.4"
|
|
return browser
|
|
|
|
|
|
def _async_browser():
|
|
context = mock.MagicMock()
|
|
context.add_init_script = mock.AsyncMock()
|
|
browser = mock.MagicMock()
|
|
browser.version = "152.0.4"
|
|
browser.new_context = mock.AsyncMock(return_value=context)
|
|
return browser
|
|
|
|
|
|
def _new_context(api, proxy, **kwargs):
|
|
if api == "sync":
|
|
browser = _sync_browser()
|
|
sync_api.NewContext(browser, os="linux", proxy=proxy, **kwargs)
|
|
return browser.new_context.call_args.kwargs, browser.new_context.return_value
|
|
browser = _async_browser()
|
|
asyncio.run(async_api.AsyncNewContext(browser, os="linux", proxy=proxy, **kwargs))
|
|
return browser.new_context.call_args.kwargs, browser.new_context.return_value
|
|
|
|
|
|
@pytest.mark.parametrize("api", ["sync", "async"])
|
|
@pytest.mark.parametrize(
|
|
"server, expected",
|
|
[
|
|
("1.2.3.4:8080", "http://u:p@1.2.3.4:8080"),
|
|
("proxy.example.com:8080", "http://u:p@proxy.example.com:8080"),
|
|
("http://proxy.example.com:8080", "http://u:p@proxy.example.com:8080"),
|
|
("socks5://proxy.example.com:1080", "socks5://u:p@proxy.example.com:1080"),
|
|
],
|
|
)
|
|
def test_lookup_goes_through_the_proxy_with_its_credentials(api, server, expected):
|
|
with mock.patch.object(ip.requests, "get", return_value=_Response(EXIT)) as get:
|
|
options, context = _new_context(api, {"server": server, "username": "u", "password": "p"})
|
|
assert get.call_args.kwargs["proxies"] == {"http": expected, "https": expected}
|
|
assert options["timezone_id"] == "Europe/Paris"
|
|
assert "203.0.113.7" in context.add_init_script.call_args.args[0]
|
|
|
|
|
|
@pytest.mark.parametrize("api", ["sync", "async"])
|
|
def test_credentials_with_url_delimiters_survive_the_proxy_url(api):
|
|
# A raw `#`, `/` or `?` stops the URL parsing, and a raw `%41` would be
|
|
# decoded into a different password (#823).
|
|
username, password = "us@r name", "p#ss/w?rd:%41"
|
|
with mock.patch.object(ip.requests, "get", return_value=_Response(EXIT)) as get:
|
|
_new_context(api, {"server": "proxy.example.com:8080", "username": username, "password": password})
|
|
url = urlsplit(get.call_args.kwargs["proxies"]["https"])
|
|
assert (url.hostname, url.port) == ("proxy.example.com", 8080)
|
|
assert (unquote(url.username), unquote(url.password)) == (username, password)
|
|
|
|
|
|
@pytest.mark.parametrize("api", ["sync", "async"])
|
|
@pytest.mark.parametrize(
|
|
"failure",
|
|
[
|
|
ip.requests.ConnectionError("proxy refused"),
|
|
_Response({"status": "fail", "message": "private range"}),
|
|
],
|
|
)
|
|
def test_a_failed_lookup_raises_instead_of_launching_without_the_values(api, failure):
|
|
get = mock.Mock(side_effect=failure) if isinstance(failure, Exception) else mock.Mock(return_value=failure)
|
|
with mock.patch.object(ip.requests, "get", get), pytest.raises(InvalidIP, match="webrtc_ip"):
|
|
_new_context(api, {"server": "1.2.3.4:8080"})
|
|
|
|
|
|
@pytest.mark.parametrize("api", ["sync", "async"])
|
|
def test_no_lookup_when_both_values_are_given(api):
|
|
with mock.patch.object(ip.requests, "get") as get:
|
|
_new_context(api, {"server": "1.2.3.4:8080"}, webrtc_ip="198.51.100.1", timezone_id="UTC")
|
|
get.assert_not_called()
|