Jake WriterandClaude Opus 5.5
9cc18faf92
With a spoofed locale, Intl.DisplayNames(['en'], {type: 'region'}).of(code)
returned the spoofed region's name for every code, and an explicitly named
Intl.Locale took the spoofed subtags. The cause, Language()/Region() being
overridden on every mozilla::intl::Locale, was already removed from
patches/locale-spoofing.patch in #779, so v156.0.1-beta.32 and later are
fixed; 152.0.4-beta.30/31 still have it.
Nothing tested it, so add a spoofing guard. With locale="tr-TR" it passes on
v156.0.1-beta.33 and fails on 152.0.4-beta.30, where every code comes back
as "Türkiye" and Intl.Locale('ja-Jpan-JP').minimize() is "tr-Latn-TR".
Reported-by: neuronaline (https://github.com/daijro/camoufox/issues/824)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests
Two things live here, and neither is a copy of anyone else's suite.
patches/ — patch guards
One standalone script per shipped behaviour. Each exits 0 or 1 and drives the browser through the Python package. Whether the patches apply is the build's check; these are the most direct evidence that a Firefox bump did not quietly neuter a patch that still applies cleanly — the failure a compile check cannot catch.
Each guard belongs to one of three groups (GROUPS in
ci/run_patch_guards.py), and CI runs each group as its own job:
- spoofing: a spoofed value still reaches the page and holds together (media devices, voices, fonts, the touchscreen digitizer, the sealed setters, …);
- automation: Playwright stays invisible to the page and never deadlocks it (isolated evaluate, trusted events, humanized and edge-case mouse input, …);
- parity: what a page or the OS can observe matches stock Firefox (content-accessible files, GPU probes, the popup blocker, the Windows manifest, …).
A new guard must be added to a group; ci/tests fails until it is.
python3 -m ci.run_patch_guards --binary /path/to/camoufox-bin
python3 -m ci.run_patch_guards --binary /path/to/camoufox-bin --group automation
python3 -m ci.run_patch_guards --binary /path/to/camoufox-bin --only isolated-evaluate
camoufox/ — Camoufox's own Playwright tests
Tests for behaviour upstream Playwright has no equivalent for, or asserts the
opposite of on purpose. ci/suite.py overlays them onto the upstream checkout
so they run against its harness. See camoufox/README.md for when to add one.
Where the Playwright suite went
This directory used to hold a fork of a ~v1.55-era playwright-python suite. It was deleted, because measuring it showed it was strictly weaker than running upstream's own suite:
- 73 of the 74 tests it skipped as "Not supported by Camoufox" pass when the same binary runs upstream's copy. The skips predated main-world execution and were never revisited; the suite was asserting that Camoufox was worse than it is.
- Of its passing tests, eight had no upstream counterpart. Six of those were
Camoufox-specific and are now the three modules in
camoufox/; the other two were tests upstream had since renamed. - Everything else was upstream code, one generation stale.
ci/run_playwright.py fetches playwright-python at the tag ci/versions.py
resolves for the browser under test, applies ci/skiplist.yml, and overlays
camoufox/. A suite that is re-fetched every run cannot go stale, and a
deliberate difference from upstream now has to be written down in the skiplist
with a reason instead of being encoded as a silent fork.
make tests # the whole suite
make tests headful=true # ... headed
python3 -m ci.run_playwright --binary /path/to/camoufox-bin --shard 3/6