From 5c61d8ec2eeb296bd5e31bdd4e8f14ebadd5b7e1 Mon Sep 17 00:00:00 2001 From: JJ Liebig Date: Thu, 17 Sep 2026 15:33:04 +0200 Subject: [PATCH] fix(windows): temporarily revert VT only mode on Windows (#4295) refs #4251 --- src/client/terminal_setup.rs | 2 +- src/client/tests/mod.rs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/client/terminal_setup.rs b/src/client/terminal_setup.rs index 1e072a4f..e888305d 100644 --- a/src/client/terminal_setup.rs +++ b/src/client/terminal_setup.rs @@ -501,7 +501,7 @@ fn pop_keyboard_enhancement_flags() -> io::Result<()> { pub(super) fn windows_win32_input_mode_enabled() -> bool { std::env::var("HERDR_WINDOWS_INPUT_PROBE") .map(|probe| probe.eq_ignore_ascii_case("win32")) - .unwrap_or(false) + .unwrap_or(true) } #[cfg(windows)] diff --git a/src/client/tests/mod.rs b/src/client/tests/mod.rs index 1072bd30..2665e7fd 100644 --- a/src/client/tests/mod.rs +++ b/src/client/tests/mod.rs @@ -103,21 +103,21 @@ fn windows_virtual_terminal_input_mode_sets_only_vti_bit() { } #[test] -fn windows_win32_input_mode_defaults_to_vt_and_honors_probe() { +fn windows_win32_input_mode_defaults_to_win32_and_honors_probe() { let _guard = env_lock().lock().unwrap(); let _removed = EnvVarsRemovedGuard::new(&["HERDR_WINDOWS_INPUT_PROBE", "SSH_CONNECTION", "SSH_TTY"]); - assert!(!windows_win32_input_mode_enabled()); + assert!(windows_win32_input_mode_enabled()); { let _ssh = EnvVarGuard::set("SSH_CONNECTION", "1 2 3 4"); - assert!(!windows_win32_input_mode_enabled()); + assert!(windows_win32_input_mode_enabled()); let _probe = EnvVarGuard::set("HERDR_WINDOWS_INPUT_PROBE", "WiN32"); assert!(windows_win32_input_mode_enabled()); } { let _ssh = EnvVarGuard::set("SSH_TTY", "terminal"); - assert!(!windows_win32_input_mode_enabled()); + assert!(windows_win32_input_mode_enabled()); let _probe = EnvVarGuard::set("HERDR_WINDOWS_INPUT_PROBE", "vT"); assert!(!windows_win32_input_mode_enabled()); }