From 55bac0dd130c68666dce65c93f466f3dd155f4ec Mon Sep 17 00:00:00 2001 From: mbecker20 Date: Mon, 1 Jul 2024 03:12:22 -0700 Subject: [PATCH] check right thing for empty --- bin/core/src/api/execute/build.rs | 2 +- client/core/rs/src/entities/build.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/core/src/api/execute/build.rs b/bin/core/src/api/execute/build.rs index c8e31447e..bb3c56711 100644 --- a/bin/core/src/api/execute/build.rs +++ b/bin/core/src/api/execute/build.rs @@ -264,7 +264,7 @@ impl Resolve for State { .join("\n"), ); } - if !secret_replacers.is_empty() { + if !secret_replacers_for_log.is_empty() { update.push_simple_log( "interpolate core secrets", secret_replacers_for_log diff --git a/client/core/rs/src/entities/build.rs b/client/core/rs/src/entities/build.rs index c8524aa26..7bdae6ebf 100644 --- a/client/core/rs/src/entities/build.rs +++ b/client/core/rs/src/entities/build.rs @@ -161,10 +161,10 @@ pub struct BuildConfig { /// These values remain hidden in the final image by using /// docker secret mounts. See ``. /// - /// To use the values, add commands like this in the Dockerfile: + /// The values can be used in RUN commands: /// ``` /// RUN --mount=type=secret,id=SECRET_KEY \ - /// SECRET_VALUE=$(cat /run/secrets/SECRET_KEY) ... + /// SECRET_KEY=$(cat /run/secrets/SECRET_KEY) ... /// ``` #[serde( default,