diff --git a/bin/core/src/api/execute/build.rs b/bin/core/src/api/execute/build.rs index bb3c56711..cdc61e48a 100644 --- a/bin/core/src/api/execute/build.rs +++ b/bin/core/src/api/execute/build.rs @@ -354,9 +354,9 @@ impl Resolve for State { // don't hold response up for user tokio::spawn(async move { handle_post_build_redeploy(&build.id).await; - info!("post build redeploy handled"); }); } else { + warn!("build unsuccessful, alerting..."); let target = update.target.clone(); let version = update.version; let err = update.logs.iter().find(|l| !l.success).cloned(); @@ -407,6 +407,7 @@ async fn handle_early_return( } update_update(update.clone()).await?; if !update.success && !is_cancel { + warn!("build unsuccessful, alerting..."); let target = update.target.clone(); let version = update.version; let err = update.logs.iter().find(|l| !l.success).cloned(); diff --git a/bin/core/src/helpers/alert.rs b/bin/core/src/helpers/alert.rs index 89e123fb9..5e206db8b 100644 --- a/bin/core/src/helpers/alert.rs +++ b/bin/core/src/helpers/alert.rs @@ -19,20 +19,18 @@ pub async fn send_alerts(alerts: &[Alert]) { return; } - let alerters = match find_collect( + let Ok(alerters) = find_collect( &db_client().await.alerters, doc! { "config.enabled": true }, None, ) .await - { - Ok(alerters) => alerters, - Err(e) => { - error!( - "ERROR sending alerts | failed to get alerters from db | {e:#}" - ); - return; - } + .inspect_err(|e| { + error!( + "ERROR sending alerts | failed to get alerters from db | {e:#}" + ) + }) else { + return; }; let handles =