diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/filters.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/filters.rs index caccc699840..6e999bb691e 100644 --- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/filters.rs +++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/filters.rs @@ -148,6 +148,49 @@ struct ComponentTransferFunctionDeclaration { table_values: (), } +#[derive(WebApiFunctionTemplate)] +#[webapi(interface = web_api_interfaces::SVGFEDropShadowElement, enumerable)] +struct DropShadowMethodsDeclaration { + #[webapi(method = "setStdDeviation", length = 2, callback = set_std_deviation)] + set_std_deviation: (), +} + +#[derive(WebApiFunctionTemplate)] +#[webapi(interface = web_api_interfaces::SVGFEGaussianBlurElement, enumerable)] +struct GaussianBlurMethodsDeclaration { + #[webapi(method = "setStdDeviation", length = 2, callback = set_std_deviation)] + set_std_deviation: (), +} + +#[derive(webidl::WebIdlArgs)] +#[webidl(prefix = "setStdDeviation")] +struct SetStdDeviationArgs { + #[webidl(required, converter = "raw")] + x: webidl::Float, + #[webidl(required, converter = "raw")] + y: webidl::Float, +} + +fn set_std_deviation<'s>( + scope: &mut v8::PinScope<'s, '_>, + args: v8::FunctionCallbackArguments<'s>, + _rv: v8::ReturnValue<'_, v8::Value>, +) { + let Some(parsed) = webidl::parse_args::(scope, &args) else { + return; + }; + // Both float conversions complete before a single native mutation. The + // f64 text view preserves the exact f32 values for existing live tear-offs. + let value = format!("{} {}", f64::from(parsed.x.0), f64::from(parsed.y.0)); + let Ok((runtime_ptr, handle)) = + node_runtime_and_handle_from_object_or_detached(scope, args.this()) + else { + return; + }; + let runtime = unsafe { &mut *runtime_ptr }; + let _ = runtime.set_attribute(scope, runtime_ptr, handle, "stdDeviation", &value); +} + pub(super) fn install_bindings<'s>( scope: &mut v8::PinScope<'s, '_, ()>, template: v8::Local<'s, v8::FunctionTemplate>, diff --git a/moli-renderer-v8/src/script_vm/tests/svg_filter_interfaces.rs b/moli-renderer-v8/src/script_vm/tests/svg_filter_interfaces.rs index 9df5577ffa5..48d02762c9d 100644 --- a/moli-renderer-v8/src/script_vm/tests/svg_filter_interfaces.rs +++ b/moli-renderer-v8/src/script_vm/tests/svg_filter_interfaces.rs @@ -1,5 +1,81 @@ use super::*; +#[test] +fn svg_filter_set_std_deviation_uses_native_receivers_and_float_arguments() { + let mut vm = new_storage_page_task_executor_test_vm("https://svg-filter-std-deviation.test/"); + vm.eval("document.body.innerHTML = ''") + .unwrap(); + vm.eval(include_str!("svg_filter_std_deviation.js")) + .unwrap(); + assert_eq!(vm.eval("__uiEventResults.complete").unwrap(), "true"); + assert_eq!(vm.eval("__uiEventResults.total").unwrap(), "804"); + assert_eq!( + vm.eval("JSON.stringify(__uiEventResults.checks.filter(row => !row.passed))") + .unwrap(), + "[]" + ); +} + +#[test] +fn svg_filter_set_std_deviation_updates_retained_isolated_world_numbers() { + let mut vm = + new_storage_page_task_executor_test_vm("https://svg-filter-deviation-worlds.test/"); + vm.eval( + r#" + globalThis.filters = ['feGaussianBlur', 'feDropShadow'].map(tag => { + const element = document.createElementNS('http://www.w3.org/2000/svg', tag); + element.id = tag; document.body.appendChild(element); + return {element, x: element.stdDeviationX, y: element.stdDeviationY}; + }); + "#, + ) + .unwrap(); + let isolated = vm + .create_isolated_world("svg-filter-deviation", false) + .unwrap(); + assert_eq!( + vm.eval_in_isolated_context( + isolated, + r#" + globalThis.filters = ['feGaussianBlur', 'feDropShadow'].map(tag => { + const element = document.getElementById(tag); + const x = element.stdDeviationX, y = element.stdDeviationY; + element.setStdDeviation(2.5, 3.25); + return {element, x, y}; + }); + filters.every(({element, x, y}) => x.baseVal === 2.5 && y.baseVal === 3.25 && + x === element.stdDeviationX && y === element.stdDeviationY); + "# + ) + .unwrap(), + "true" + ); + assert_eq!( + vm.eval( + r#" + filters.every(({element, x, y}) => { + if (x.baseVal !== 2.5 || y.animVal !== 3.25) return false; + element.setStdDeviation(4.5, 5.25); + return x.baseVal === 4.5 && y.baseVal === 5.25; + }); + "# + ) + .unwrap(), + "true" + ); + assert_eq!( + vm.eval_in_isolated_context( + isolated, + r#" + filters.every(({element, x, y}) => x.baseVal === 4.5 && y.animVal === 5.25 && + x === element.stdDeviationX && y === element.stdDeviationY); + "# + ) + .unwrap(), + "true" + ); +} + #[test] fn svg_number_lists_synchronize_each_native_attribute_change() { let mut vm = new_storage_page_task_executor_test_vm("https://svg-number-list-sync.test/");