From 40868d3767d405d970f1cc82a5cbbbb2ece01e11 Mon Sep 17 00:00:00 2001 From: ldm0 Date: Wed, 2 Sep 2026 16:02:53 +0800 Subject: [PATCH] fix(v8): avoid embedding duplicate ICU data --- Cargo.lock | 7 ------- moli-v8-init/Cargo.toml | 1 - moli-v8-init/src/lib.rs | 7 ++----- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 446a85e03d..f08d0ea6e1 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -979,12 +979,6 @@ version = "0.1.3" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "da220af51a1a335e9a930beaaef53d261e41ea9eecfb3d973a3ddae1a7284b9c" -[[package]] -name = "deno_core_icudata" -version = "0.78.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b963d2d79672b4c379e4511acccd27bb35b4c1b32a93f596d52ff14a064293bc" - [[package]] name = "deno_error" version = "0.7.1" @@ -3104,7 +3098,6 @@ dependencies = [ name = "moli-v8-init" version = "0.1.0" dependencies = [ - "deno_core_icudata", "v8", ] diff --git a/moli-v8-init/Cargo.toml b/moli-v8-init/Cargo.toml index 7cb645142b..db4855b586 100644 --- a/moli-v8-init/Cargo.toml +++ b/moli-v8-init/Cargo.toml @@ -5,7 +5,6 @@ version = "0.1.0" edition = "2024" [dependencies] -deno_core_icudata = "0.78.0" v8 = "152.2.0" [lints] diff --git a/moli-v8-init/src/lib.rs b/moli-v8-init/src/lib.rs index ab3a5bd200..d16e6bec29 100644 --- a/moli-v8-init/src/lib.rs +++ b/moli-v8-init/src/lib.rs @@ -1,8 +1,7 @@ //! Process-wide V8 initialization shared by Moli V8 users. //! -//! V8 platform and ICU initialization are process-global. Keep the `Once` -//! boundary here so production and tests do not each grow their own init -//! guards. +//! V8 platform initialization is process-global. Keep the `Once` boundary +//! here so production and tests do not each grow their own init guards. use std::sync::Once; @@ -25,8 +24,6 @@ pub fn ensure_v8_initialized_with_flags( if let Some(flags) = flags { v8::V8::set_flags_from_string(flags); } - v8::icu::set_common_data_78(deno_core_icudata::ICU_DATA) - .expect("V8 ICU data should initialize"); let platform = create_platform(); v8::V8::initialize_platform(platform); v8::V8::initialize();