From de528c992b4446997aaf3fe346c1fded25199cae Mon Sep 17 00:00:00 2001 From: ldm0 Date: Mon, 19 Oct 2026 03:02:31 +0800 Subject: [PATCH] fix(images): load valid images from HTTP error responses Use MIME and image bytes to determine decode eligibility instead of requiring an HTTP 2xx status. Keep upstream request security checks and origin cleanliness unchanged. Cover valid raster and SVG bodies at error statuses and rejection of empty or malformed image data through the shared parkable image path. --- moli-renderer-v8/src/network_host/image.rs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/moli-renderer-v8/src/network_host/image.rs b/moli-renderer-v8/src/network_host/image.rs index 20effd827a6..07b60c95163 100644 --- a/moli-renderer-v8/src/network_host/image.rs +++ b/moli-renderer-v8/src/network_host/image.rs @@ -545,11 +545,18 @@ mod tests { headers.clone(), String::new(), ); - let descriptor = image_response_descriptor_from_parkable(&response, &encoded, true) + for origin_clean in [false, true] { + let descriptor = image_response_descriptor_from_parkable( + &response, + &encoded, + origin_clean, + ) .unwrap_or_else(|| { panic!("{mime} image rejected at HTTP {status}, nosniff={nosniff}") }); - assert_eq!((descriptor.width, descriptor.height), (2, 1)); + assert_eq!((descriptor.width, descriptor.height), (2, 1)); + assert_eq!(descriptor.origin_clean, origin_clean); + } } } }