From f7325becd2eb04c3d468480aaacb4b7cc75ee040 Mon Sep 17 00:00:00 2001 From: ldm0 Date: Wed, 30 Sep 2026 19:29:41 +0800 Subject: [PATCH] fix(webaudio): preserve Gain processing guards and popup node interfaces --- .../script_vm/tests/audio_param_node_backend_guards.js | 2 +- .../src/script_vm/tests/audio_param_node_interfaces.js | 9 +++++---- moli-webapi/src/web_audio/gain.rs | 3 +++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/moli-renderer-v8/src/script_vm/tests/audio_param_node_backend_guards.js b/moli-renderer-v8/src/script_vm/tests/audio_param_node_backend_guards.js index d8fa5a906e2..3d13fecfe39 100644 --- a/moli-renderer-v8/src/script_vm/tests/audio_param_node_backend_guards.js +++ b/moli-renderer-v8/src/script_vm/tests/audio_param_node_backend_guards.js @@ -5,7 +5,7 @@ try { await callback(); rows.push({name, pass: true}); } catch (error) { rows.push({name, pass: false, message: String(error)}); } }; - for (const factory of ['createDelay', 'createStereoPanner']) { + for (const factory of ['createGain', 'createDelay', 'createStereoPanner']) { for (const automaticPull of [false, true]) { await check(factory + '/unsupported processing/' + automaticPull, async () => { const context = new OfflineAudioContext(1, 32, 8000); diff --git a/moli-renderer-v8/src/script_vm/tests/audio_param_node_interfaces.js b/moli-renderer-v8/src/script_vm/tests/audio_param_node_interfaces.js index db14194a925..073d2508f9c 100644 --- a/moli-renderer-v8/src/script_vm/tests/audio_param_node_interfaces.js +++ b/moli-renderer-v8/src/script_vm/tests/audio_param_node_interfaces.js @@ -9,12 +9,13 @@ try { callback(); } catch (error) { return error; } throw Error('expected exception'); }; - - const realms = [['main', window], ['child', document.getElementById('child').contentWindow]]; - + const popup = open(); + const realms = [['main', window], ['child', document.getElementById('child').contentWindow], ['popup', popup]]; + try { for (const [label, w] of realms) { const context = new w.AudioContext(); const types = [ + ['GainNode', 'createGain', 'gain', 1, -Math.fround(3.4028234663852886e38), Math.fround(3.4028234663852886e38), 'max'], ['DelayNode', 'createDelay', 'delayTime', 0, 0, 1, 'max'], ['StereoPannerNode', 'createStereoPanner', 'pan', 0, -1, 1, 'clamped-max'] ]; @@ -144,7 +145,7 @@ }); } finally { await context.close(); } } - + } finally { popup.close(); } globalThis.__nodeReplacementResults = {rows, rejectedModeStates, passed: rows.filter(row => row.pass).length, total: rows.length, failures: rows.filter(row => !row.pass)}; return rows.every(row => row.pass); })() diff --git a/moli-webapi/src/web_audio/gain.rs b/moli-webapi/src/web_audio/gain.rs index 57884270815..c2f80e649f4 100644 --- a/moli-webapi/src/web_audio/gain.rs +++ b/moli-webapi/src/web_audio/gain.rs @@ -105,6 +105,9 @@ fn initialize<'s>( return false; } graph::initialize_node(scope, node, context); + // The legacy oscillator signal is not a Gain processor. Preserve the + // explicit unsupported-rendering boundary until PCM processing exists. + graph::mark_unsupported_processor(scope, node); true }