Files
moli/moli-core/tests/javascript_url_lifecycle.rs
T
ldm0 eba9d50092 fix: unload descendant documents during frame navigation
Snapshot retiring frame documents and finish their beforeunload phase before
actual unload delivery. Preserve ancestor unload counters through descendant
callbacks and check exact owners before dispatching further events.

Retain visibility state on the native Document and dispatch trusted, bubbling
visibilitychange events through the host event path. Use native unload
counters to suppress navigation during visibility and ancestor callbacks;
cancel each retiring window's timers after its unload.

Eight Browser integration tests cover 50 scenarios. The 181-case WPT
comparison gains two passing cases and seven passing subtests without
regressions; update the passed ledger to 9,101 cases.

Validation: cargo fmt --all; cargo clippy --workspace --all-targets
--all-features -- -D warnings; cargo nextest run --no-fail-fast
(17,910 passed, 13 skipped). Rebuilt CLI matches the tested WPT binary.
2026-09-23 08:56:35 +08:00

223 lines
9.9 KiB
Rust

use anyhow::Result;
use moli_core::runtime::{Browser, BrowserConfig};
use moli_test_support::FixtureServer;
use serde_json::{Value, json};
use tokio::time::Duration;
use url::Url;
async fn child_navigation_lifecycle(via: &str, kind: &str, depth: usize) -> Result<Value> {
let server = FixtureServer::spawn().await?;
let browser = Browser::new(BrowserConfig::default())?;
let markup = format!(
r#"<!doctype html><body><script>
window.events = [];
window.visibility = [];
window.bubbledVisibility = [];
window.syntheticDispatchCalled = false;
window.staleTimerRan = false;
window.unloadNavigationRan = false;
window.finished = (async () => {{
async function makeFrame(owner, label) {{
const frame = owner.document.createElement('iframe');
const loaded = new Promise(resolve => frame.onload = resolve);
frame.src = '/compat/child-dynamic-markup-document?markup=' +
encodeURIComponent('<!doctype html><body>original');
owner.document.body.append(frame);
await loaded;
const win = frame.contentWindow;
for (const type of ['beforeunload', 'pagehide', 'unload'])
win.addEventListener(type, () => events.push(label + ':' + type));
win.document.addEventListener('visibilitychange', event => {{
events.push(label + ':visibilitychange');
visibility.push({{label, hidden: win.document.hidden,
state: win.document.visibilityState, trusted: event.isTrusted,
bubbles: event.bubbles, cancelable: event.cancelable,
documentTarget: event.target === win.document}});
}});
win.addEventListener('visibilitychange', () => bubbledVisibility.push(label));
win.document.dispatchEvent = () => {{ syntheticDispatchCalled = true; }};
const cleanup = () => {{
win.setTimeout(() => staleTimerRan = true, 0);
win.location.href = 'javascript:top.unloadNavigationRan = true; void 0';
}};
win.addEventListener('unload', cleanup);
win.document.addEventListener('visibilitychange', cleanup);
return frame;
}}
const frame = await makeFrame(window, 'target');
let owner = frame.contentWindow;
for (let i = 0; i < {depth}; ++i)
owner = (await makeFrame(owner, 'descendant-' + i)).contentWindow;
if ({depth} > 0) owner.addEventListener('unload', () => {{
frame.contentWindow.location.href =
'javascript:top.unloadNavigationRan = true; void 0';
}});
const unrelated = await makeFrame(window, 'unrelated');
const oldDocument = frame.contentDocument;
const unrelatedDocument = unrelated.contentDocument;
let resolveDone;
const done = new Promise(resolve => resolveDone = resolve);
let loads = 0;
frame.onload = () => {{ loads++; resolveDone(); }};
window.nonStringDone = () => setTimeout(resolveDone, 0);
const kind = {kind:?};
const url = kind === 'string' ? 'javascript:"<body>replacement"' :
kind === 'undefined' ? 'javascript:top.nonStringDone(); void 0' :
'/compat/child-dynamic-markup-document?markup=' +
encodeURIComponent('<!doctype html><body>network');
const via = {via:?};
if (via === 'location') frame.contentWindow.location.href = url;
else if (via === 'src') frame.src = url;
else {{
const anchor = frame.contentDocument.createElement('a');
anchor.href = url;
frame.contentDocument.body.append(anchor);
anchor.click();
}}
await done;
await new Promise(resolve => setTimeout(resolve, 0));
return {{events, visibility, bubbledVisibility, syntheticDispatchCalled,
staleTimerRan, unloadNavigationRan, loads,
sameDocument: frame.contentDocument === oldDocument,
oldHidden: oldDocument.hidden, newHidden: frame.contentDocument.hidden,
unrelatedUnchanged: unrelated.contentDocument === unrelatedDocument,
text: frame.contentDocument.body.textContent,
children: frame.contentWindow.length}};
}})();
</script>"#
);
let mut url = Url::parse(&server.url("/compat/child-dynamic-markup-document"))?;
url.query_pairs_mut().append_pair("markup", &markup);
let result = tokio::time::timeout(Duration::from_secs(10), async {
let mut page = browser.fetch(url.as_str()).await?;
page.evaluate_runtime_expression_with_await_async(
"finished.then(value => JSON.stringify(value))",
true,
)
.await
})
.await??;
let result: Value = serde_json::from_str(result["value"].as_str().unwrap())?;
server.shutdown().await;
assert_eq!(result["unrelatedUnchanged"], true, "{via}/{kind}: {result}");
assert_eq!(result["staleTimerRan"], false, "{via}/{kind}: {result}");
assert_eq!(
result["syntheticDispatchCalled"], false,
"{via}/{kind}: {result}"
);
assert_eq!(result["newHidden"], false, "{via}/{kind}: {result}");
assert_eq!(
result["unloadNavigationRan"], false,
"{via}/{kind}: {result}"
);
Ok(result)
}
#[tokio::test(flavor = "multi_thread")]
async fn child_javascript_url_string_unloads_without_beforeunload() -> Result<()> {
for via in ["location", "src", "anchor"] {
for depth in [0, 2] {
let result = child_navigation_lifecycle(via, "string", depth).await?;
assert_eq!(result["sameDocument"], false);
assert_eq!(result["loads"], 1);
assert_eq!(result["text"], "replacement");
assert_eq!(result["children"], 0);
let events = result["events"].as_array().unwrap();
let labels = std::iter::once("target".to_owned())
.chain((0..depth).map(|index| format!("descendant-{index}")));
for label in labels {
let actual: Vec<_> = events
.iter()
.filter(|event| event.as_str().unwrap().starts_with(&format!("{label}:")))
.cloned()
.collect();
assert_eq!(
actual,
vec![
json!(format!("{label}:pagehide")),
json!(format!("{label}:visibilitychange")),
json!(format!("{label}:unload")),
],
"{via}/{depth}: {result}"
);
}
assert_eq!(events.len(), 3 * (depth + 1), "{via}/{depth}: {result}");
}
}
Ok(())
}
#[tokio::test(flavor = "multi_thread")]
async fn child_javascript_url_non_string_preserves_document_and_descendants() -> Result<()> {
for via in ["location", "src", "anchor"] {
let result = child_navigation_lifecycle(via, "undefined", 2).await?;
assert_eq!(result["sameDocument"], true);
assert_eq!(result["loads"], 0);
assert_eq!(result["events"], json!([]));
assert_eq!(result["children"], 1);
}
Ok(())
}
#[tokio::test(flavor = "multi_thread")]
async fn ordinary_child_navigation_unloads_descendants_and_updates_visibility() -> Result<()> {
for via in ["location", "src", "anchor"] {
for depth in [0, 2] {
let result = child_navigation_lifecycle(via, "network", depth).await?;
assert_eq!(result["sameDocument"], false);
assert_eq!(result["loads"], 1);
assert_eq!(result["text"], "network");
assert_eq!(result["oldHidden"], true);
let events = result["events"].as_array().unwrap();
let labels: Vec<_> = std::iter::once("target".to_owned())
.chain((0..depth).map(|index| format!("descendant-{index}")))
.collect();
// Cancellation checks for every document precede actual unloads.
assert!(
events
.iter()
.take(labels.len())
.all(|event| event.as_str().unwrap().ends_with(":beforeunload")),
"{via}/{depth}: {result}"
);
for label in &labels {
let actual: Vec<_> = events
.iter()
.filter(|event| event.as_str().unwrap().starts_with(&format!("{label}:")))
.cloned()
.collect();
assert_eq!(
actual,
vec![
json!(format!("{label}:beforeunload")),
json!(format!("{label}:pagehide")),
json!(format!("{label}:visibilitychange")),
json!(format!("{label}:unload"))
],
"{via}/{depth}: {result}"
);
assert!(
result["visibility"].as_array().unwrap().contains(&json!({
"label": label, "hidden": true, "state": "hidden", "trusted": true,
"bubbles": true, "cancelable": false, "documentTarget": true
})),
"{via}/{depth}: {result}"
);
assert!(
result["bubbledVisibility"]
.as_array()
.unwrap()
.contains(&json!(label))
);
}
assert_eq!(events.len(), 4 * labels.len(), "{via}/{depth}: {result}");
assert_eq!(result["visibility"].as_array().unwrap().len(), labels.len());
assert_eq!(
result["bubbledVisibility"].as_array().unwrap().len(),
labels.len()
);
}
}
Ok(())
}