starred/native
1
0
Fork 0
mirror of https://github.com/bulwarkmail/native.git synced 2026-11-02 00:06:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: hide settings export and import when the organisation turns them off

Browse Source
This commit is contained in:
Linus Rath
2026-10-31 15:31:27 +01:00
parent 1d654bbeaf
commit df1e211780
2 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/settings/StorageSettings.tsx
+19 -13
View File
@@ -10,6 +10,7 @@ import { spacing, radius, typography, type ThemePalette } from '../../theme/toke
import { useColors } from '../../theme/colors'; import { useColors } from '../../theme/colors';
import { useSettingsStore } from '../../stores/settings-store'; import { useSettingsStore } from '../../stores/settings-store';
import { useLocaleStore } from '../../stores/locale-store'; import { useLocaleStore } from '../../stores/locale-store';
import { usePolicyFeature } from '../../stores/policy-store';
import { useOfflineCacheStore } from '../../stores/offline-cache-store'; import { useOfflineCacheStore } from '../../stores/offline-cache-store';
import { useOutboxStore } from '../../stores/outbox-store'; import { useOutboxStore } from '../../stores/outbox-store';
import { runOfflineSync, formatBytes } from '../../lib/offline-sync'; import { runOfflineSync, formatBytes } from '../../lib/offline-sync';
@@ -29,6 +30,9 @@ export function StorageSettings({ onOpenTroubleshooting }: StorageSettingsProps)
const resetToDefaults = useSettingsStore((s) => s.resetToDefaults); const resetToDefaults = useSettingsStore((s) => s.resetToDefaults);
const exportSettings = useSettingsStore((s) => s.exportSettings); const exportSettings = useSettingsStore((s) => s.exportSettings);
const importSettings = useSettingsStore((s) => s.importSettings); const importSettings = useSettingsStore((s) => s.importSettings);
// The organisation can turn settings export and import off (webmail
// about-data-settings.tsx).
const exportAllowed = usePolicyFeature('settingsExportEnabled');
const [confirmReset, setConfirmReset] = useState(false); const [confirmReset, setConfirmReset] = useState(false);
@@ -229,19 +233,21 @@ export function StorageSettings({ onOpenTroubleshooting }: StorageSettingsProps)
title={t('settings.backup.title', 'Settings backup')} title={t('settings.backup.title', 'Settings backup')}
description={t('settings.backup.description', 'Move your settings to another phone or the webmail.')} description={t('settings.backup.description', 'Move your settings to another phone or the webmail.')}
> >
<SettingItem {exportAllowed && (
label={t('settings.backup.export_import', 'Export or import')} <SettingItem
description={t('settings.backup.export_import_desc', 'A JSON file, same format as the webmail')} label={t('settings.backup.export_import', 'Export or import')}
> description={t('settings.backup.export_import_desc', 'A JSON file, same format as the webmail')}
<View style={styles.buttonPair}> >
<Button variant="outline" size="sm" onPress={() => void handleExport()}> <View style={styles.buttonPair}>
{t('settings.advanced.export_settings.button', 'Export')} <Button variant="outline" size="sm" onPress={() => void handleExport()}>
</Button> {t('settings.advanced.export_settings.button', 'Export')}
<Button variant="outline" size="sm" onPress={() => void handleImport()}> </Button>
{t('settings.advanced.import_settings.button', 'Import')} <Button variant="outline" size="sm" onPress={() => void handleImport()}>
</Button> {t('settings.advanced.import_settings.button', 'Import')}
</View> </Button>
</SettingItem> </View>
</SettingItem>
)}
<SettingItem <SettingItem
label={t('settings.advanced.reset_settings.label', 'Reset Settings')} label={t('settings.advanced.reset_settings.label', 'Reset Settings')}
description={t('settings.backup.reset_desc', 'Back to the defaults; mail stays')} description={t('settings.backup.reset_desc', 'Back to the defaults; mail stays')}
src/components/settings/__tests__/org-policy-settings.test.ts
+6
View File
@@ -43,4 +43,10 @@ describe('organisation policy on the settings pages', () => {
expect(page).toMatch(/\{showExternalContent && \(\s*<SettingItem\s+label=\{t\('settings\.email_behavior\.external_content\.label'[\s\S]*?locked=\{externalContentLocked\}/); expect(page).toMatch(/\{showExternalContent && \(\s*<SettingItem\s+label=\{t\('settings\.email_behavior\.external_content\.label'[\s\S]*?locked=\{externalContentLocked\}/);
expect(page).toContain("const externalContentLocked = useSettingLocked('externalContentPolicy');"); expect(page).toContain("const externalContentLocked = useSettingLocked('externalContentPolicy');");
}); });
it('offers settings export and import only while the organisation allows them', () => {
const page = settings('StorageSettings');
expect(page).toContain("const exportAllowed = usePolicyFeature('settingsExportEnabled');");
expect(page).toMatch(/\{exportAllowed && \(\s*<SettingItem\s+label=\{t\('settings\.backup\.export_import'[\s\S]*?handleExport[\s\S]*?handleImport[\s\S]*?<\/SettingItem>\s*\)\}/);
});
}); });