Kang
bc4c32a854
Open the existing paste review from both suggestion entry points, preserving complete quick commands and replacing the query only after confirmation. Revalidate the input and session before sending; require bracketed paste for direct filling and retain explicit line-by-line execution. Preserve literal newlines through Telnet while sharing input recording and write guards. Add multiline candidate labels, translations, regression coverage and docs. No persistence format, dependency or fork revision changes. Validation: workspace check, test (5863 passed, 37 ignored), fmt check and clippy --all-targets passed. File permission tests used an unprivileged runner. Linux Bash, Zsh and Fish PTY checks preserved continuations and blank lines, with execution only after manual Enter. GUI, Windows and macOS unverified.
7.5 KiB
Offline command catalog
The bundled catalog is generated from the pinned MIT-licensed Carapace source
archive, not from an executable or a live shell. Install the tool dependency with
python -m pip install -r scripts/completion/requirements.txt, download
https://codeload.github.com/carapace-sh/carapace-bin/tar.gz/6bc2b8d69a2474b6eeb626a85ef83254c2ab7d82, and run:
python scripts/completion/generate_catalog.py --archive /path/carapace.tar.gz
python scripts/completion/generate_catalog.py --archive /path/carapace.tar.gz --check
The generator verifies the archive hash and emits deterministic UTF-8 JSON,
source metadata including the catalog hash, and the original upstream license.
Unsupported YAML and dynamic values are counted rather than evaluated. Docker's
public root command shortcuts reuse the corresponding container declarations.
Updating the catalog requires changing the pinned revision and digest together,
regenerating all three artifacts, and reviewing the statistics and diff.
The runtime parses the artifact on its completion worker and only enumerates the active command's tree. It does not query paths, branches or containers. Automatic suggestions search whole commands from current-scope and legacy history and named quick commands first, then add contextual catalog and learned-history tokens. Alt+R searches only whole history and quick commands, using the same matching, ordering and deduplication rules; an empty query shows recent history and ranked quick commands. Quick commands match their label (or their command when the label is empty) and insert their full command, rather than contributing individual tokens. Final target lines are deduplicated before the 12-item limit.
Single-line suggestions append an exact raw suffix when possible. Non-prefix matches replace the current input only with confirmed shell editing capability and a fresh input mapping, using the same key encoder as smart selection. Both operations wait for echo confirmation and never synthesize Enter: execution requires another manual Enter. Multiline whole commands open the existing editable paste review in both entry points, regardless of the clipboard confirmation setting. Cancelling keeps the terminal input unchanged; confirmation revalidates the original session, input version, scope and terminal state before replacing the whole query. Direct paste requires confirmed shell editing capability and bracketed paste, preserves continuations and blank lines, and does not append Enter. The separate line-by-line send action explicitly submits the lines, following the existing paste semantics. Unsupported text and uncertain terminal states cannot authorize a write. Multiline buffers remain outside scalar editing and its single-line echo acknowledgement.
Scoped history is device-local and excluded from portable backup and cloud-sync documents. Restoring/replacing history clears scoped contributions and registers restored rows as legacy global history. The learning filter intentionally drops entire suspicious commands; it cannot recognize every possible secret.
Matching uses nucleo-matcher 0.3.1 (MPL-2.0), unchanged, from crates.io: https://crates.io/crates/nucleo-matcher/0.3.1 https://github.com/helix-editor/nucleo The Carapace data license is bundled beside the generated asset. Release packages must retain that notice and the nucleo source/license reference in this document.
Reproducible performance baseline
Run the synthetic fixture benchmark in an optimized build:
cargo run --release -p nyaterm-core --example completion_bench > /tmp/completion-bench.csv
It measures the previous matcher, the reusable Nucleo matcher and the full search adapter at 64, 1,000, 10,000 and 50,000 candidates. It also measures warm token completion against the embedded catalog and 5,000 distinct learned Docker commands. Each query runs once to warm buffers, then 25 timed samples; p95 is sample 24 after sorting. The counting allocator reports average allocations per query and the maximum increase in live heap bytes, excluding preloaded data. These synthetic strings contain no user history. Numbers depend on hardware, concurrent load and the instrumentation; they are not production guarantees.
The Linux baseline and raw CSV are in benchmark-baseline.csv. Warm contextual p95 ranges from 0.05 to 4.53 ms in that run, below the 8 ms target. Raw Unicode scans are slower than the old matcher for several queries; Nucleo does eliminate warm per-item scoring allocations. Full history scans still scale with history size and run on the worker. The contextual engine enumerates only the active node and the relevant learned relation bucket.
Validation and platform boundaries
Pure Rust tests cover all five dialects, byte ranges, Unicode highlights, option values, scope isolation, source merging and deterministic ordering. Store tests cover reopening the database, old global history, unknown fields, unsupported versions, retention, deletion and restore. Desktop tests cover worker ordering, cross-window invalidation and the existing input transaction guards. The local integration suite exercises actual interactive Bash, Zsh and Fish processes and verifies that each first submission produces exactly one accepted-command event. Optional live-shell fixtures skip when their executable is absent.
The implementation environment is Linux; Bash, Zsh 5.9 and Fish 4.2.1 were validated locally. Windows PowerShell/Cmd, macOS, live SSH and WSL require platform validation before claiming complete platform acceptance. On each:
- Verify
dock,docker r,docker run --na, an empty argument and learned internal commands. Tab/Enter must fill a suffix without a space or execution. - Open Alt+R, verify current-scope and compatible legacy history without a legacy
badge, then execute only with another manual Enter. Verify that
!reaches the shell. - Submit on two hosts/users/distributions, restart, delete history from another window and restore a backup; unrelated scopes and stale popups must stay clear.
- Exercise delayed echo, passwords, alternate screen, broadcast, disconnect, lock screen, middle-of-line cursors and complex graphemes; unsafe fills must be rejected.
- Select a named multiline quick command in both entry points, edit/cancel its paste review, then verify bracketed paste preserves its entire text without executing. Confirm stale reviews cannot replace input or write to another tab.
The first version deliberately excludes middle-of-line replacement, editing inside quoted/escaped tokens, Ghost Text and dynamic environment queries.
When driving the workspace tests as Linux root, run the file crate's tests as an unprivileged user. The existing file permission test expects opening an owner-read-only file for writing to fail; unrestricted root can write that file. Other tests branch on the actual UID, so removing root capabilities alone is not equivalent to an ordinary user. The file crate passed all 204 active unit tests using this runner configuration:
cargo test -p nyaterm-files --lib --config 'target.x86_64-unknown-linux-gnu.runner=["runuser","-u","nobody","--"]'
For a root-driven workspace run, use a native Cargo runner that selects
runuser -u nobody -- for nyaterm_files-* test executables and directly runs
other executables. Existing desktop SSH-start fixtures depend on the launch
user's environment and fail when the entire suite is forced into the nobody
account. These are validation-environment constraints; the completion changes do
not modify those test behaviors.