mirror of
https://github.com/nyakang/nyaterm.git
synced 2026-11-06 00:07:41 +00:00
Kang
e967621060
- Added `nyaterm-files` for local and remote file services, including SFTP and shell file backends. - Introduced `nyaterm-remote-ops` for system metrics, process management, and Docker operations. - Updated `AGENTS.md` to reflect the new crates and their responsibilities. - Ensured that the new crates remain independent of GPUI and desktop presentation types. - Updated `Cargo.toml` and `Cargo.lock` to include new dependencies and workspace members.
71 lines
3.7 KiB
Python
71 lines
3.7 KiB
Python
"""Keep plugin dependency rules effective for aliases and platform dependencies."""
|
|
from pathlib import Path
|
|
import tempfile
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from scripts.ci import check_architecture
|
|
|
|
|
|
class PluginDependencyTests(unittest.TestCase):
|
|
def check_dependencies(self, sdk, host, overrides=None):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
root = Path(temporary)
|
|
(root / "Cargo.toml").write_text(
|
|
'[workspace.dependencies]\nhidden-transport = { package = "nyaterm-transport", version = "1" }\n',
|
|
encoding="utf-8",
|
|
)
|
|
crates = (
|
|
"nyaterm-files", "nyaterm-recording", "nyaterm-remote-ops",
|
|
"nyaterm-core", "nyaterm-transport", "nyaterm-terminal", "nyaterm-store", "nyaterm-sync",
|
|
"nyaterm-remote-desktop", "nyaterm-desktop", "nyaterm-plugin-api", "nyaterm-plugin-host",
|
|
)
|
|
for crate in crates:
|
|
directory = root / "crates" / crate
|
|
directory.mkdir(parents=True)
|
|
document = sdk if crate == "nyaterm-plugin-api" else host if crate == "nyaterm-plugin-host" else ""
|
|
document = (overrides or {}).get(crate, document)
|
|
(directory / "Cargo.toml").write_text(document, encoding="utf-8")
|
|
with patch.object(check_architecture, "ROOT", root):
|
|
return check_architecture.dependency_errors()
|
|
|
|
def test_guest_and_host_keep_their_allowed_dependencies(self):
|
|
self.assertEqual(self.check_dependencies(
|
|
'[dependencies]\nwit-bindgen = "0.49"\n',
|
|
'[dependencies]\nnyaterm-core = "1"\nnyaterm-store = "1"\nwasmtime = "39"\n',
|
|
), [])
|
|
|
|
def test_workspace_alias_cannot_hide_sdk_transport_dependency(self):
|
|
errors = self.check_dependencies('[dependencies]\nhidden-transport.workspace = true\n', "")
|
|
self.assertEqual(errors, ["crate_boundary: nyaterm-plugin-api must not depend on nyaterm-transport"])
|
|
|
|
def test_target_and_build_aliases_cannot_hide_presentation_dependencies(self):
|
|
errors = self.check_dependencies(
|
|
'[target.\'cfg(windows)\'.dev-dependencies]\npresentation = { package = "gpui-base", version = "1" }\n',
|
|
'[build-dependencies]\nshell = { package = "nyaterm-desktop", version = "1" }\n',
|
|
)
|
|
self.assertCountEqual(errors, [
|
|
"crate_boundary: nyaterm-plugin-api must not depend on gpui-base",
|
|
"crate_boundary: nyaterm-plugin-host must not depend on nyaterm-desktop",
|
|
])
|
|
|
|
def test_transport_cannot_depend_on_business_crates_even_through_aliases(self):
|
|
for crate in ["nyaterm-files", "nyaterm-recording", "nyaterm-remote-ops"]:
|
|
with self.subTest(crate=crate):
|
|
errors = self.check_dependencies("", "", {"nyaterm-transport":
|
|
f'[target.\'cfg(windows)\'.dev-dependencies]\nhidden = {{ package = "{crate}", version = "1" }}\n'})
|
|
self.assertEqual(errors, [f"crate_boundary: nyaterm-transport must not depend on {crate}"])
|
|
|
|
def test_business_crates_remain_independent_and_recording_needs_no_transport(self):
|
|
for source, target in [("nyaterm-files", "nyaterm-remote-ops"),
|
|
("nyaterm-remote-ops", "nyaterm-recording"),
|
|
("nyaterm-recording", "nyaterm-transport")]:
|
|
with self.subTest(source=source, target=target):
|
|
errors = self.check_dependencies("", "", {source:
|
|
f'[dependencies]\nhidden = {{ package = "{target}", version = "1" }}\n'})
|
|
self.assertEqual(errors, [f"crate_boundary: {source} must not depend on {target}"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|