starred/openidea
1
0
Fork 0
mirror of https://github.com/l0ng-ai/openidea.git synced 2026-11-07 00:07:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(search): make the search popups draggable (#625)

Browse Source 
Find in Files, Replace in Files and Search Everywhere have no window title bar, so they could not be moved off the editor underneath. Dialogs can now be dragged from any element marked `data-dialog-drag`: the headers of those search popups, the title of any titled popup, and the existing window title bars and alert bodies, which now use the same mark. Controls inside a handle never start a drag.

Also waits for a review thread inlay in a test where it can mount a tick later.

Co-authored-by: a-rookie-of-C-language <186315048+a-rookie-of-C-language@users.noreply.github.com>
This commit is contained in:
arookieofc
2026-11-01 08:13:15 +08:00
committed by GitHub
co-authored by a-rookie-of-C-language
parent 95e79116d1
commit 0bf597c2fd
5 changed files with 53 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/github/diff/reviewDiff.test.tsx
+2 -1
View File
@@ -216,7 +216,8 @@ describe("review threads in a pull request diff", () => {
expect(right.contains(t1)).toBe(true);
expect(t1.closest(".cm-lineInlay")!.previousElementSibling?.textContent).toBe("line three");
expect(right.querySelectorAll(".cm-reviewControl-toggle")).toHaveLength(2);
expect(inlay("T2")).not.toBeNull();
// Each thread's inlay mounts in its own effect, so T2 may land a tick after T1.
await waitFor(() => expect(inlay("T2")).not.toBeNull());
act(() => setReviewDiffSettings({ threadsView: "unresolved" }));
await waitFor(() => expect(inlay("T2")).toBeNull());