From 17e7b98cfc3fcbf1761cedddf76ee42252004226 Mon Sep 17 00:00:00 2001 From: Vadim Lazuk Date: Mon, 16 Nov 2026 22:46:36 +0300 Subject: [PATCH] fix(e2e): size-check both close button svgs in findUsages-ui (#3834) The Close Tab button now stacks idle and hovered icons, so the single-svg locator hit Playwright's strict mode. The spec checks every svg each toolbar button renders. Closes #3828 Co-authored-by: Inf1mum <8135225+Inf1mum@users.noreply.github.com> --- e2e/findUsages-ui.spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/e2e/findUsages-ui.spec.ts b/e2e/findUsages-ui.spec.ts index 577542077..6caaf1c3c 100644 --- a/e2e/findUsages-ui.spec.ts +++ b/e2e/findUsages-ui.spec.ts @@ -69,8 +69,10 @@ for (const theme of ["light", "dark"] as const) { await checkSize(fileIcon); await checkSize(directoryIcon); await checkSize(find.getByRole("status", { name: "Loading", exact: true })); + // The close button stacks idle and hovered icons (both 16px); check every svg each button renders. for (const title of ["Stop", "Expand All", "Collapse All", "Close Tab"]) - await checkSize(find.getByRole("button", { name: title, exact: true }).last().locator("svg")); + for (const icon of await find.getByRole("button", { name: title, exact: true }).last().locator("svg").all()) + await checkSize(icon); await page.evaluate(async () => { const path = "/src/ui/iconAppearance.ts";