From ac3c564249d5acd2466f9ef2c19d20ed4458d4c5 Mon Sep 17 00:00:00 2001 From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com> Date: Mon, 16 Nov 2026 20:58:50 +0800 Subject: [PATCH] fix(python): visit a shared base or subclass once when walking inheritance --- src/editor/navigation/inheritanceGraph.ts | 4 +++- src/editor/navigation/pythonHierarchy.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/editor/navigation/inheritanceGraph.ts b/src/editor/navigation/inheritanceGraph.ts index c92ea69f5..adbcb4b33 100644 --- a/src/editor/navigation/inheritanceGraph.ts +++ b/src/editor/navigation/inheritanceGraph.ts @@ -316,7 +316,9 @@ export async function ancestryResolution( continue; } for (const parent of found) { - if (!seen.add(declarationKey(parent))) continue; + const key = declarationKey(parent); + if (seen.has(key)) continue; + seen.add(key); out.push({ decl: parent, depth: d }); next.push(parent); } diff --git a/src/editor/navigation/pythonHierarchy.ts b/src/editor/navigation/pythonHierarchy.ts index 755a403b9..0c64992f9 100644 --- a/src/editor/navigation/pythonHierarchy.ts +++ b/src/editor/navigation/pythonHierarchy.ts @@ -123,7 +123,9 @@ export async function pythonDescendants( const next: ClassInheritance[] = []; for (const parent of level) { for (const sub of subclasses.get(declarationKey(parent)) ?? []) { - if (!seen.add(declarationKey(sub))) continue; + const key = declarationKey(sub); + if (seen.has(key)) continue; + seen.add(key); out.push(sub); next.push(sub); }