mirror of
https://github.com/l0ng-ai/openidea.git
synced 2026-11-06 16:08:05 +00:00
JawandClaude Opus 5.5
d1acf9f9ac
Ref-name inputs only validated after the fact, so a space typed or pasted into a branch name showed "Branch name contains invalid characters" and disabled Create. Branch-name fields (New Branch, from a revision and in several repositories, Rename Branch, New Worktree, GitHub New Remote Branch) now clean the name while typing: forbidden characters are dropped and whitespace becomes '-', without stacking separators, keeping the caret in place. Shared via src/platform/gitRefName.ts and the useSanitizedField hook in src/ui. Closes #1553 Co-authored-by: jaw52 <53564781+jaw52@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
71 lines
2.9 KiB
TypeScript
71 lines
2.9 KiB
TypeScript
/**
|
|
* Create New Branch: spaces typed or pasted into the name become separators on the fly, as in
|
|
* IDEA, so the name stays valid. Git is stubbed at the IPC layer.
|
|
*/
|
|
import type { Page } from "@playwright/test";
|
|
import { expect, ipcCalls, stubDesktop, test } from "./fixtures";
|
|
|
|
const ROOT = "/dev/acme-api";
|
|
|
|
async function openNewBranchDialog(page: Page) {
|
|
await stubDesktop(page);
|
|
await page.evaluate(async (root) => {
|
|
const h = window.__ipc.handlers;
|
|
h.vcs_roots = () => [{ root, operation: null, head: "main", headCommit: "1111111" }];
|
|
h.vcs_branch_info = () => ({
|
|
head: "main",
|
|
headCommit: "1111111",
|
|
upstream: null,
|
|
ahead: 0,
|
|
behind: 0,
|
|
operation: null,
|
|
});
|
|
h.vcs_status = () => [];
|
|
h.vcs_create_branch = () => null;
|
|
const vcsModule = "/src/features/vcs/store.ts";
|
|
const { useVcs, refreshNow } = await import(/* @vite-ignore */ vcsModule);
|
|
useVcs.setState({ available: true, root, repo: root, branchesLoaded: false, stashesLoaded: false });
|
|
await refreshNow();
|
|
const actionsModule = "/src/platform/actions.ts";
|
|
const { executeAction } = await import(/* @vite-ignore */ actionsModule);
|
|
void executeAction("vcs.newBranch");
|
|
}, ROOT);
|
|
const dialog = page.getByRole("dialog", { name: "Create New Branch" });
|
|
const input = dialog.getByRole("textbox", { name: "New branch name:" });
|
|
await expect(input).toBeVisible();
|
|
return { dialog, input };
|
|
}
|
|
|
|
test("a typed space becomes a separator and Create stays enabled", async ({ workbench: page }) => {
|
|
const { dialog, input } = await openNewBranchDialog(page);
|
|
await input.fill("");
|
|
await input.pressSequentially("fix login redirect");
|
|
await expect(input).toHaveValue("fix-login-redirect");
|
|
await expect(dialog.getByText("Branch name contains invalid characters")).toHaveCount(0);
|
|
await expect(dialog.getByRole("button", { name: "Create", exact: true })).toBeEnabled();
|
|
await dialog.getByRole("button", { name: "Create", exact: true }).click();
|
|
const [call] = await ipcCalls(page, "vcs_create_branch");
|
|
expect(call).toMatchObject({ name: "fix-login-redirect" });
|
|
});
|
|
|
|
test("a space typed in the middle keeps the caret after it", async ({ workbench: page }) => {
|
|
const { input } = await openNewBranchDialog(page);
|
|
await input.fill("ab");
|
|
await input.evaluate((el: HTMLInputElement) => el.setSelectionRange(1, 1));
|
|
await page.keyboard.press("Space");
|
|
await expect(input).toHaveValue("a-b");
|
|
await page.keyboard.type("x");
|
|
await expect(input).toHaveValue("a-xb");
|
|
});
|
|
|
|
test("pasted text has its spaces replaced", async ({ workbench: page }) => {
|
|
const { dialog, input } = await openNewBranchDialog(page);
|
|
await input.fill("");
|
|
await input.evaluate((el: HTMLInputElement) => {
|
|
el.focus();
|
|
document.execCommand("insertText", false, "feature/add new thing");
|
|
});
|
|
await expect(input).toHaveValue("feature/add-new-thing");
|
|
await expect(dialog.getByRole("button", { name: "Create", exact: true })).toBeEnabled();
|
|
});
|