From 14360b4e86543234061b58abeb4e684d28ebe30e Mon Sep 17 00:00:00 2001 From: Sai Nikhil Date: Wed, 16 Jul 2025 13:02:35 +0530 Subject: [PATCH] fix: add alert page UI changes (#7571) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### **User description** 1. this will reduce the padding all over the page (white space) 2. this will query for the data if multi time range is selected , upto specific period that user selected not the entire period ___ ### **PR Type** Enhancement, Bug fix ___ ### **Description** - Revamp alert creation page layout and spacing - Refactor SQL/VRL editors responsiveness - Add AI generate SQL/VRL buttons - Prevent wildcard queries before running ___ ### **Changes diagram** ```mermaid flowchart LR A["Layout adjustments"] --> B["Editor layout refactor"] B --> C["AI generate button addition"] C --> D["Query validation guard"] ``` ___ ### **Changes walkthrough** 📝
Relevant files
Enhancement
3 files
AddAlert.vue
Update AddAlert layout, logic and styling                               
+22/-22 
SelectFolderDropDown.vue
Mark SelectFolder label as required                                           
+1/-1     
FullViewContainer.vue
Extend FullViewContainer expand behavior                                 
+7/-1     
Formatting
5 files
AlertsContainer.vue
Adjust AlertsContainer spacing and font size                         
+2/-2     
PreviewAlert.vue
Tweak PreviewAlert container spacing                                         
+1/-1     
RealTimeAlert.vue
Update RealTimeAlert layout spacing                                           
+4/-4     
ScheduledAlert.vue
Refine ScheduledAlert spacing and styles                                 
+310/-231
VariablesInput.vue
Fix VariablesInput layout width                                                   
+6/-3     
___ >
Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • --- .../pages/alertsPages/alertsPage.js | 3 +- web/src/assets/images/common/ai_icon_blue.svg | 5 + web/src/components/alerts/AddAlert.vue | 44 +- web/src/components/alerts/AlertsContainer.vue | 4 +- web/src/components/alerts/PreviewAlert.vue | 2 +- web/src/components/alerts/RealTimeAlert.vue | 12 +- web/src/components/alerts/ScheduledAlert.vue | 750 +++++++++++------- web/src/components/alerts/VariablesInput.vue | 9 +- .../common/sidebar/SelectFolderDropDown.vue | 2 +- .../functions/FullViewContainer.vue | 8 +- 10 files changed, 499 insertions(+), 340 deletions(-) create mode 100644 web/src/assets/images/common/ai_icon_blue.svg diff --git a/tests/ui-testing/pages/alertsPages/alertsPage.js b/tests/ui-testing/pages/alertsPages/alertsPage.js index a897d812f3..33683ef1f8 100644 --- a/tests/ui-testing/pages/alertsPages/alertsPage.js +++ b/tests/ui-testing/pages/alertsPages/alertsPage.js @@ -444,7 +444,8 @@ export class AlertsPage { await this.page.waitForTimeout(2000); // Close dialog - await this.page.locator('div').filter({ hasText: /^closeAdd Conditions$/ }).locator('i').click(); + //this is modified according to the new dialog structure and new close icon + await this.page.locator('#q-portal--dialog--9').getByText('arrow_back_ios_new').click(); await this.page.waitForTimeout(1000); // Submit alert diff --git a/web/src/assets/images/common/ai_icon_blue.svg b/web/src/assets/images/common/ai_icon_blue.svg new file mode 100644 index 0000000000..599933e8c6 --- /dev/null +++ b/web/src/assets/images/common/ai_icon_blue.svg @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/web/src/components/alerts/AddAlert.vue b/web/src/components/alerts/AddAlert.vue index 2ed6755bff..3c65112e22 100644 --- a/web/src/components/alerts/AddAlert.vue +++ b/web/src/components/alerts/AddAlert.vue @@ -59,21 +59,20 @@ along with this program. If not, see .
    -
    +
    -
    +
    .
    @@ -100,6 +99,7 @@ along with this program. If not, see . outlined filled dense + hide-bottom-space v-bind:readonly="beingUpdated" v-bind:disable="beingUpdated" :rules="[ @@ -111,13 +111,13 @@ along with this program. If not, see . ]" tabindex="0" /> -
    +
    @@ -126,7 +126,7 @@ along with this program. If not, see .
    . />
    -
    +
    . v-model="formData.is_real_time" :checked="formData.is_real_time" val="false" + dense :label="t('alerts.scheduled')" class="q-ml-none" /> @@ -206,13 +207,12 @@ along with this program. If not, see . v-model="formData.is_real_time" :checked="!formData.is_real_time" val="true" + dense :label="t('alerts.realTime')" class="q-ml-none" />
    - -
    @@ -285,9 +285,9 @@ along with this program. If not, see .
    -
    +
    . subLabel="Go deeper with custom options" class="tw-mt-1 tw-w-full col-12" /> -
    -
    +
    +
    .
    .
    -
    +
    -
    +
    . -->