From 271ff27faca0b3d8950d5ae40459dd3b9bfb482f Mon Sep 17 00:00:00 2001 From: Bhargav Date: Tue, 30 Dec 2025 12:08:04 +0530 Subject: [PATCH] fix: remove traces error and rate value filters (#9617) ### **PR Type** Bug fix ___ ### **Description** - Merge Rate and Errors filter chip displays - Remove redundant Errors start-value span - Always display Duration time range when set ___

File Walkthrough

Relevant files
Bug fix
TracesMetricsDashboard.vue
Unify filter chip display logic                                                   

web/src/plugins/traces/metrics/TracesMetricsDashboard.vue
  • Merged Rate and Errors chips into single time-range indicator
  • Removed specific Errors value display span
  • Changed Duration chip to always use time-range v-if
+2/-5     
___ --------- Co-authored-by: omkark06 --- tests/api-testing/tests/test_streaming.py | 4 ++-- web/coverage.sh | 8 ++++---- web/src/plugins/traces/metrics/TracesMetricsDashboard.vue | 7 ++----- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/tests/api-testing/tests/test_streaming.py b/tests/api-testing/tests/test_streaming.py index 5ceccdd96a..0542b324b2 100644 --- a/tests/api-testing/tests/test_streaming.py +++ b/tests/api-testing/tests/test_streaming.py @@ -213,7 +213,7 @@ def test_histogram( now = datetime.now(timezone.utc) end_time = int(now.timestamp() * 1000000) - ten_min_ago = int((now - timedelta(minutes=15)).timestamp() * 1000000) # Increased to 15 minutes to ensure data coverage + ten_min_ago = int((now - timedelta(hours=1)).timestamp() * 1000000) # Increased to 1 hour to ensure data coverage across test runs json_data_hist = { "query": { "sql": hist_query, @@ -929,7 +929,7 @@ def test_streaming_histogram( now = datetime.now(timezone.utc) end_time = int(now.timestamp() * 1000000) - ten_min_ago = int((now - timedelta(minutes=15)).timestamp() * 1000000) # Increased to 15 minutes to ensure data coverage + ten_min_ago = int((now - timedelta(hours=1)).timestamp() * 1000000) # Increased to 1 hour to ensure data coverage across test runs json_data_hist = { "query": { "sql": hist_query, diff --git a/web/coverage.sh b/web/coverage.sh index cfa9d4c9fc..feee7309e6 100755 --- a/web/coverage.sh +++ b/web/coverage.sh @@ -2,10 +2,10 @@ set -eu -o pipefail # Default coverage thresholds - you can override these with environment variables -export FRONTEND_COVERAGE_LINES=${FRONTEND_COVERAGE_LINES:-50} -export FRONTEND_COVERAGE_FUNCTIONS=${FRONTEND_COVERAGE_FUNCTIONS:-40} -export FRONTEND_COVERAGE_BRANCHES=${FRONTEND_COVERAGE_BRANCHES:-40} -export FRONTEND_COVERAGE_STATEMENTS=${FRONTEND_COVERAGE_STATEMENTS:-50} +export FRONTEND_COVERAGE_LINES=${FRONTEND_COVERAGE_LINES:-55} +export FRONTEND_COVERAGE_FUNCTIONS=${FRONTEND_COVERAGE_FUNCTIONS:-44} +export FRONTEND_COVERAGE_BRANCHES=${FRONTEND_COVERAGE_BRANCHES:-45} +export FRONTEND_COVERAGE_STATEMENTS=${FRONTEND_COVERAGE_STATEMENTS:-54} usage() { cat < > {{ filter.panelTitle }} - + : {{ t('latencyInsights.timeRangeSelected') }} - - >= {{ filter.start }} - - + {{ formatTimeWithSuffix(filter.start) }} - {{ formatTimeWithSuffix(filter.end) }}