From 953f7bd096c4b73159202ff6089cafdc03356f89 Mon Sep 17 00:00:00 2001
From: Sai Nikhil <nikhil@openobserve.ai>
Date: Tue, 10 Dec 2024 23:21:19 +0530
Subject: [PATCH] fix: save pipeline warn (#5303)

This PR warns the user when tries to save the pipeline having same input
and output node as that doesnot make any impact

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a confirmation dialog for saving pipelines to enhance user
experience.
	- Added validation checks for pipeline nodes before saving.

- **Bug Fixes**
- Improved error handling by ensuring users are prompted before saving
invalid configurations.
- Enhanced user experience with appropriate redirection after dialog
cancellation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Taiming Liu <liutaiming3@gmail.com>
---
 .../components/pipeline/PipelineEditor.vue    | 58 +++++++++++++++++--
 1 file changed, 53 insertions(+), 5 deletions(-)

diff --git a/web/src/components/pipeline/PipelineEditor.vue b/web/src/components/pipeline/PipelineEditor.vue
index b4b1f141fa..39fa049a0f 100644
--- a/web/src/components/pipeline/PipelineEditor.vue
+++ b/web/src/components/pipeline/PipelineEditor.vue
@@ -135,6 +135,13 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     @update:cancel="resetConfirmDialog"
     v-model="confirmDialogMeta.show"
   />
+  <ConfirmDialog
+    title="Save Pipeline"
+    message="Are you sure you want to save this Pipeline, as it does not have any impact?"
+    @update:ok="confirmSaveBasicPipeline"
+    @update:cancel="resetBasicDialog"
+    v-model="confirmDialogBasicPipeline"
+  />
 </template>
 
 <script setup lang="ts">
@@ -369,6 +376,7 @@ const nodeRows = ref<(string | null)[]>([]);
 
 const q = useQuasar();
 
+const confirmDialogBasicPipeline = ref(false);
 const associatedFunctions: Ref<string[]> = ref([]);
 
 const { t } = useI18n();
@@ -531,7 +539,6 @@ const savePipeline = async () => {
     });
     return;
   }
-
   // Find the input node
   const inputNodeIndex = pipelineObj.currentSelectedPipeline.nodes.findIndex(
     (node:any) =>
@@ -565,8 +572,8 @@ const savePipeline = async () => {
     });
     return;
   }
-  
   else {
+
     pipelineObj.currentSelectedPipeline.nodes.map((node : any) => {
       if (node.data.node_type === "stream" && node.data.stream_name && node.data.stream_name.hasOwnProperty("value")) {
         node.data.stream_name = node.data.stream_name.value;
@@ -595,13 +602,27 @@ const savePipeline = async () => {
     return;
   }
 
+  const isValid = isValidNodes(pipelineObj.currentSelectedPipeline.nodes);
+  if(!isValid){
+    confirmDialogBasicPipeline.value  = true;
+    return;
+  }
+
+  await onSubmitPipeline();
+ 
+}
+
+const confirmSaveBasicPipeline = async () => {
+  confirmDialogBasicPipeline.value = false;
+  await onSubmitPipeline();
+}
+
+const onSubmitPipeline = async () =>{
   const dismiss = q.notify({
     message: "Saving pipeline...",
     position: "bottom",
     spinner: true,
   });
-
-
   const saveOperation = pipelineObj.isEditPipeline
     ? pipelineService.updatePipeline({
         data: pipelineObj.currentSelectedPipeline,
@@ -689,7 +710,6 @@ const openCancelDialog = () => {
   }
 
 };
-
 const resetConfirmDialog = () => {
   confirmDialogMeta.value.show = false;
   confirmDialogMeta.value.title = "";
@@ -698,6 +718,18 @@ const resetConfirmDialog = () => {
   confirmDialogMeta.value.data = null;
 };
 
+const resetBasicDialog = () =>{
+  confirmDialogBasicPipeline.value = false;
+  router.push({
+    name: "pipelines",
+    query: {
+      org_identifier: store.state.selectedOrganization.identifier,
+    },
+  });
+}
+
+
+
 const findMissingEdges = () => {
   const nodes = pipelineObj.currentSelectedPipeline.nodes;
   const edges = pipelineObj.currentSelectedPipeline.edges;
@@ -724,6 +756,22 @@ const findMissingEdges = () => {
 
   return false; // All nodes are properly connected
 };
+const isValidNodes = (nodes:any) =>{
+  if(nodes.length > 2){
+    return true;
+  }
+  const inputNode = nodes.find((node:any) => node.io_type === "input");
+  const outputNode = nodes.find((node:any) => node.io_type === "output");
+
+  if(inputNode.data.node_type !== 'stream'){
+    return true;
+  }
+  if(inputNode.data.node_type === 'stream' && outputNode.data.node_type === 'stream' && inputNode.data.stream_name === outputNode.data.stream_name && inputNode.data.stream_type === outputNode.data.stream_type){
+    return false;
+  }
+  return true;
+
+}