From aa2b641b7b787b1b34f501c8cdcdbf2126cca40b Mon Sep 17 00:00:00 2001 From: Abhay Padamani <141122205+ktx-abhay@users.noreply.github.com> Date: Thu, 29 Aug 2024 18:12:55 +0530 Subject: [PATCH] fix: wrong timeseries hover issue for dashboard (#4397) - #4365 ## Summary by CodeRabbit - **New Features** - Improved stability of chart interactions by ensuring the hovered series name defaults to an empty string when not available. - Enhanced user experience with updated event handling, renaming the event listener from "downplay" to "highlight" for clearer interaction feedback. --- web/src/components/dashboards/panels/ChartRenderer.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/src/components/dashboards/panels/ChartRenderer.vue b/web/src/components/dashboards/panels/ChartRenderer.vue index ac5ac1d461..046d0c98aa 100644 --- a/web/src/components/dashboards/panels/ChartRenderer.vue +++ b/web/src/components/dashboards/panels/ChartRenderer.vue @@ -233,7 +233,7 @@ export default defineComponent({ } // set current hovered series name in state - hoveredSeriesState?.value?.setHoveredSeriesName(params?.seriesName); + hoveredSeriesState?.value?.setHoveredSeriesName(params?.seriesName ?? ""); // Below logic is to scroll legend upto current series index // which creates wrong legend highlight issue in tooltip @@ -316,9 +316,9 @@ export default defineComponent({ }); chart?.on("legendselectchanged", legendSelectChangedFn); - chart?.on("downplay", (params: any) => { + chart?.on("highlight", (params: any) => { // reset hovered series name on downplay - hoveredSeriesState?.value?.setHoveredSeriesName(""); + // hoveredSeriesState?.value?.setHoveredSeriesName(""); // downplay event will only called by currently hovered panel else it will go into infinite loop // and chart must be timeseries chart