From ea891d2bb7e2996747e12637db18be25e2e38134 Mon Sep 17 00:00:00 2001
From: Bhargav <BJP232004@GMAIL.COM>
Date: Mon, 10 Feb 2025 14:56:58 +0530
Subject: [PATCH] fix: 5891 rum improvement (#5910)

Co-authored-by: ktx-vaidehi <vaidehi.akhani@kiara.tech>
---
 web/src/components/login/Login.vue              |  8 ++++++++
 web/src/components/rum/AppTable.vue             |  4 ++--
 web/src/composables/dashboard/useAnnotations.ts |  6 ++++--
 web/src/utils/rum/errors.json                   |  4 ++--
 web/src/utils/rum/overview.json                 | 12 ++++++++----
 web/src/utils/rum/web_vitals.json               | 12 ++++++------
 6 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/web/src/components/login/Login.vue b/web/src/components/login/Login.vue
index 7d5287d2a3..e9bdf36140 100644
--- a/web/src/components/login/Login.vue
+++ b/web/src/components/login/Login.vue
@@ -187,6 +187,7 @@ import {
 import { redirectUser } from "@/utils/common";
 import { computed } from "vue";
 import config from "@/aws-exports";
+import { openobserveRum } from "@openobserve/browser-rum";
 
 export default defineComponent({
   name: "PageLogin",
@@ -280,6 +281,13 @@ export default defineComponent({
                 useLocalCurrentUser(JSON.stringify(userInfo));
                 store.dispatch("setCurrentUser", userInfo);
 
+                if(store.state.zoConfig?.rum?.enabled) {
+                  openobserveRum.setUser({
+                    name: userInfo.given_name + " " + userInfo.family_name,
+                    email: userInfo.email,
+                  });
+                }
+
                 //check for redirect URI and redirect user to that page
                 const redirectURI =
                   window.sessionStorage.getItem("redirectURI");
diff --git a/web/src/components/rum/AppTable.vue b/web/src/components/rum/AppTable.vue
index 579d1e405e..e09fe255c3 100644
--- a/web/src/components/rum/AppTable.vue
+++ b/web/src/components/rum/AppTable.vue
@@ -50,7 +50,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
           </q-tr>
         </template>
         <template v-slot:body="props">
-          <q-tr :props="props" :key="`m_${props.row.index}`">
+          <q-tr :props="props" :key="`m_${props.row.index}`" class="cursor-pointer">
             <q-td
               v-for="col in props.cols"
               :key="col.name"
@@ -130,7 +130,7 @@ defineProps({
 const emit = defineEmits(["event-emitted"]);
 
 const handleDataClick = (columnName: string, row: any) => {
-  emit("event-emitted", "cell-click", { columnName, row });
+  emit("event-emitted", "cell-click", { columnName: "action_play", row });
 };
 
 const onScroll = (e: any) => {
diff --git a/web/src/composables/dashboard/useAnnotations.ts b/web/src/composables/dashboard/useAnnotations.ts
index 6fe4df5b53..ce27bb41fc 100644
--- a/web/src/composables/dashboard/useAnnotations.ts
+++ b/web/src/composables/dashboard/useAnnotations.ts
@@ -9,7 +9,10 @@ export const useAnnotations = (
     if (!panelId) {
       return;
     }
-
+    if (!dashboardId) {
+      return;
+    }
+    
     try {
       const response = await annotationService.get_timed_annotations(
         organization,
@@ -22,7 +25,6 @@ export const useAnnotations = (
       );
 
       return response.data;
-
     } catch (err: any) {
       console.error("Error fetching annotations:", err);
       return null;
diff --git a/web/src/utils/rum/errors.json b/web/src/utils/rum/errors.json
index 5e96dc5a61..8f3986b334 100644
--- a/web/src/utils/rum/errors.json
+++ b/web/src/utils/rum/errors.json
@@ -13,7 +13,7 @@
       "title": "Errors by Time",
       "description": "",
       "config": {
-        "show_legends": true,
+        "show_legends": false,
         "legends_position": null,
         "base_map": { "type": "osm" },
         "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
@@ -36,7 +36,7 @@
             ],
             "y": [
               {
-                "label": "",
+                "label": " ",
                 "alias": "y_axis_1",
                 "column": "y_axis_1",
                 "color": "#5960b2",
diff --git a/web/src/utils/rum/overview.json b/web/src/utils/rum/overview.json
index 90f467ea1c..78918a27fe 100644
--- a/web/src/utils/rum/overview.json
+++ b/web/src/utils/rum/overview.json
@@ -156,7 +156,8 @@
         "show_legends": true,
         "legends_position": null,
         "base_map": { "type": "osm" },
-        "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
+        "map_view": { "zoom": 1, "lat": 0, "lng": 0 },
+        "decimals": 0
       },
       "error_config": {
         "custom_error_handeling": true,
@@ -202,7 +203,8 @@
         "show_legends": true,
         "legends_position": null,
         "base_map": { "type": "osm" },
-        "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
+        "map_view": { "zoom": 1, "lat": 0, "lng": 0 },
+        "decimals": 0
       },
       "error_config": {
         "custom_error_handeling": true,
@@ -249,7 +251,8 @@
         "legends_position": null,
         "unit": "custom",
         "base_map": { "type": "osm" },
-        "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
+        "map_view": { "zoom": 1, "lat": 0, "lng": 0 },
+        "decimals": 0
       },
       "error_config": {
         "custom_error_handeling": true,
@@ -295,7 +298,8 @@
         "show_legends": true,
         "legends_position": null,
         "base_map": { "type": "osm" },
-        "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
+        "map_view": { "zoom": 1, "lat": 0, "lng": 0 },
+        "decimals": 0
       },
       "error_config": {
         "custom_error_handeling": true,
diff --git a/web/src/utils/rum/web_vitals.json b/web/src/utils/rum/web_vitals.json
index 40a9774f4c..d314820b72 100644
--- a/web/src/utils/rum/web_vitals.json
+++ b/web/src/utils/rum/web_vitals.json
@@ -13,7 +13,7 @@
       "title": "Largest Contentful Paint ( LCP )",
       "description": "",
       "config": {
-        "show_legends": true,
+        "show_legends": false,
         "legends_position": null,
         "unit": "seconds",
         "unit_custom": "",
@@ -39,7 +39,7 @@
             ],
             "y": [
               {
-                "label": "",
+                "label": " ",
                 "alias": "y_axis_1",
                 "column": "y_axis_1",
                 "color": null,
@@ -64,7 +64,7 @@
       "title": "First Input Delay ( FID )",
       "description": "",
       "config": {
-        "show_legends": true,
+        "show_legends": false,
         "legends_position": null,
         "unit": "milliseconds",
         "base_map": { "type": "osm" },
@@ -89,7 +89,7 @@
             ],
             "y": [
               {
-                "label": "",
+                "label": " ",
                 "alias": "y_axis_1",
                 "column": "y_axis_1",
                 "color": null,
@@ -114,7 +114,7 @@
       "title": "Cumulative Layout Shift ( CLS )",
       "description": "",
       "config": {
-        "show_legends": true,
+        "show_legends": false,
         "legends_position": null,
         "base_map": { "type": "osm" },
         "map_view": { "zoom": 1, "lat": 0, "lng": 0 }
@@ -138,7 +138,7 @@
             ],
             "y": [
               {
-                "label": "",
+                "label": " ",
                 "alias": "y_axis_1",
                 "column": "view_cumulative_layout_shift",
                 "color": "#5960b2",