mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
50e45e2ea72b9bb34f847fa29830d2cbfbcbf7fa
5
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Shrinath Rao
|
bffa2fefbb |
test: use empty template in email destination import JSON (#9736)
### **User description**
## Summary
- Fix email destination import test to work consistently across
environments
- Changed `template: "email"` to `template: ""` in
emailDestinationImport.json
- Also updated the GitHub file (alert_tests repo) with the same fix
## Root Cause
The email destination import JSON had `"template": "email"` which caused
different behavior:
- On environments without a built-in "email" template: UI shows template
dropdown
- On environments with a built-in "email" template: UI hides the
dropdown (since template is already valid)
Using empty template ensures the dropdown is always shown, making tests
consistent.
## Test plan
- [x] Tested on test.internal - passes
- [x] Tested on dev2.internal - passes
___
### **PR Type**
Tests
___
### **Description**
- Set `template` to empty string in import JSON
- Ensure consistent template dropdown in UI tests
___
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>emailDestinationImport.json</strong><dd><code>Template
field reset in import JSON</code>
</dd></summary>
<hr>
tests/ui-testing/utils/emailDestinationImport.json
- Updated `template` from "email" to "".
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/9736/files#diff-57ea7fbee46a4944f5ca07827afa5e1f411dfc33e4153a29951719360d097883">+1/-1</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___
|
||
|
Shrinath Rao
|
f61b715a1e |
test: Cleanup Mechanism and ENV Runs for e2e tests (#8839)
### **PR Type** Enhancement, Tests ___ ### **Description** - Add robust alerts cleanup utilities - Improve UI flows and resiliency - Support deployed env testing delays - Add CI cleanup and health checks ___ ### Diagram Walkthrough ```mermaid flowchart LR UI["Playwright UI flows hardened"] API["APICleanup cascade (Alerts→Folders→Destinations→Templates)"] CI["CI workflow targets deployed env"] Delay["Configurable test step delay"] Data["Global ingestion more robust"] UI -- "uses" --> API CI -- "runs cleanup.spec" --> API CI -- "health checks + env vars" --> Data Delay -- "slows page ops" --> UI Data -- "ingest logs with parsing" --> UI ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>alertDestinationsPage.js</strong><dd><code>Add search, cascade-safe delete, bulk prefix cleanup</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-57e5c53b4ef998b3d8708149620ff94dcc46807927f1a3a9e9f28ed3ebe25b0a">+178/-0</a> </td> </tr> <tr> <td><strong>alertTemplatesPage.js</strong><dd><code>Add template search, in-use handling, prefix cleanup</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-f4ebd248b2140051e74dbbbd1aabe344f01c80704ce5857e9c28a04350e018f3">+177/-2</a> </td> </tr> <tr> <td><strong>alertsPage.js</strong><dd><code>Harden alert actions, bulk deletion, search across folders</code></dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-79ee01d6d7f145f19207b93b87143b545a1188cfc6a82bc8c45fecfbf68f8a1d">+280/-9</a> </td> </tr> <tr> <td><strong>apiCleanup.js</strong><dd><code>New API-based cascade cleanup utility</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-537fe76c0d8e26e81c5f77c83bd0ee35daaa973822105c809bf83171a26b33c5">+399/-0</a> </td> </tr> <tr> <td><strong>page-manager.js</strong><dd><code>Wire APICleanup into PageManager</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-565eab8b3c767ae50c9d05e591621d14f66b81af84d6b5ea6efe136c1c3933df">+4/-0</a> </td> </tr> <tr> <td><strong>baseFixtures.js</strong><dd><code>Add configurable test step delay hooks</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-c4c5ee7fbb248d1ab14d3d4e33ffb9626f9aab74c9e0207fcfc08051c8c3c7ee">+46/-0</a> </td> </tr> <tr> <td><strong>global-setup.js</strong><dd><code>Harden login and ingestion with diagnostics</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-06323dad7214f86b41b62e121e716eeea0054bc4d950c6bcf4a0efe53894acc8">+61/-22</a> </td> </tr> </table></details></td></tr><tr><td><strong>Bug fix</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>commonActions.js</strong><dd><code>Fix ingestion URLs to use org variable</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-4d726dd2bdb34b2c90a31798ff49b6df5bc952bd049b7c38bebb18b6db0076e2">+4/-4</a> </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>4 files</summary><table> <tr> <td><strong>alerts-e2e-flow.spec.js</strong><dd><code>Pre-move folder cleanup and stabilization</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-32972e38c1fe0e8bb887f9f254b3130916a36f96ea924f9987493d44efefeab9">+13/-3</a> </td> </tr> <tr> <td><strong>alerts-import.spec.js</strong><dd><code>Use dedicated invalid import test data</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-62b6ec4818685eacc0a934d68aaadfd73b512ef4f4be25fcd5135b97c2844912">+1/-1</a> </td> </tr> <tr> <td><strong>cleanup.spec.js</strong><dd><code>New pre-test API cleanup spec</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-c214275a512fa285a7e4f2ab61dfcb42d71a0436b0e4241f94d7b45693587983">+29/-0</a> </td> </tr> <tr> <td><strong>invalid-alert.json</strong><dd><code>Add invalid alert sample for import tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-c695f71048e9393a45d3e3e3e415696559fecf3ba85712e7c3f366092f53f424">+24/-0</a> </td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>playwright.yml</strong><dd><code>Target deployed env; add cleanup job and health checks</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/8839/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+123/-65</a></td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___ |
||
|
Shrinath Rao
|
7fe850326a |
test: Folder Structure changes for Alerts, updated yml file for running multiple spec files instead of one (#7212)
### **PR Type** Tests, Enhancement ___ ### **Description** - Fix import paths in Alerts page classes - Add template import and creation methods - Introduce new Alerts E2E, import, UI tests - Update CI workflow with new test specs ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>alertDestinationsPage.js</strong><dd><code>fix import path for common actions</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-57e5c53b4ef998b3d8708149620ff94dcc46807927f1a3a9e9f28ed3ebe25b0a">+1/-1</a> </td> </tr> <tr> <td><strong>changeOrg.spec.js</strong><dd><code>update AlertsPage import path reference</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-607c77ca637716a5b8d37ec25dbaf7dc91cddd7d981b72f9c460f54498d14351">+1/-1</a> </td> </tr> </table></details></td></tr><tr><td><strong>Enhancement</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>alertTemplatesPage.js</strong><dd><code>add template import locators and methods</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-f4ebd248b2140051e74dbbbd1aabe344f01c80704ce5857e9c28a04350e018f3">+71/-0</a> </td> </tr> <tr> <td><strong>alertsPage.js</strong><dd><code>improve locators and add timeouts</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-79ee01d6d7f145f19207b93b87143b545a1188cfc6a82bc8c45fecfbf68f8a1d">+8/-6</a> </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>5 files</summary><table> <tr> <td><strong>alerts-e2e-flow.spec.js</strong><dd><code>add end-to-end alerts flow tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-32972e38c1fe0e8bb887f9f254b3130916a36f96ea924f9987493d44efefeab9">+162/-0</a> </td> </tr> <tr> <td><strong>alerts-import.spec.js</strong><dd><code>add import/export alerts functionality tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-62b6ec4818685eacc0a934d68aaadfd73b512ef4f4be25fcd5135b97c2844912">+129/-0</a> </td> </tr> <tr> <td><strong>alerts-ui-operations.spec.js</strong><dd><code>add alerts UI operations validation tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-c9b523b5f5dea834b69abdf20f4acef361bdf37b1585c450e10238b1d1984f2e">+255/-0</a> </td> </tr> <tr> <td><strong>emailTemplateImport.json</strong><dd><code>add email template import fixture</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-2f3913b2a88452f900baf8bec360cca87b30e26819c98483028ec98dc09a23d2">+7/-0</a> </td> </tr> <tr> <td><strong>webhookTemplateImport.json</strong><dd><code>add webhook template import fixture</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-7b0a644740e335227bc785d900c70972619e669ec2e0669f521d50de9d0425ba">+7/-0</a> </td> </tr> </table></details></td></tr><tr><td><strong>Miscellaneous</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>alerts.spec.js</strong><dd><code>comment out legacy alerts spec file</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-a51e6bab2ebb7ff9069a707fd7da5bb3e0948db8013765b4a934ba594c1bcf57">+426/-354</a></td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>playwright.yml</strong><dd><code>include new alerts spec files in CI</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7212/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+3/-1</a> </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> |
||
 Shrinath RaoandShyam Panjiyar
|
1aaffd0585 |
test: Updated Alerts Module Test Cases and added a couple tests (#7151)
### **PR Type** Tests, Enhancement ___ ### **Description** Add AlertDestinationsPage, AlertTemplatesPage, AlertsNewPage New E2E tests for template, destination, alerts Skip outdated organization tests in usersOrg.spec.js Test Cases added and covered in this -  ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>alertDestinationsPage.js</strong><dd><code>Add AlertDestinationsPage page object</code> </dd></summary> <hr> tests/ui-testing/pages/alertDestinationsPage.js <li>Create AlertDestinationsPage class<br> <li> Add navigation and creation locators<br> <li> Implement createDestination with assertions </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7151/files#diff-3c9cc3c2853f55de304cb4ba26f9841e720774435f5ed890b40cd085d2aef108">+49/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>alertTemplatesPage.js</strong><dd><code>Add AlertTemplatesPage page object</code> </dd></summary> <hr> tests/ui-testing/pages/alertTemplatesPage.js <li>Create AlertTemplatesPage class<br> <li> Define create, edit, search, delete methods<br> <li> Add assertion checks for template operations </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7151/files#diff-85075c8512133f05cc1a149872574c9e498613329c17e36521a0dfbff1d83e2e">+97/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>alertsNew.js</strong><dd><code>Add AlertsNewPage page object</code> </dd></summary> <hr> tests/ui-testing/pages/alertsNew.js <li>Create AlertsNewPage class<br> <li> Implement folder and alert management methods<br> <li> Add stream selection and clone operations </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7151/files#diff-e30d87f85be81e5bfe97cd508ee6f357ca0d8c07510781a6af1b1e1ddb1108e3">+193/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>alertsNew.spec.js</strong><dd><code>Add alerts module E2E test suite</code> </dd></summary> <hr> tests/ui-testing/playwright-tests/alertsNew.spec.js <li>Add tests for template and destination creation<br> <li> Add folder and alert lifecycle test suite<br> <li> Setup API log ingestion in beforeEach hook </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7151/files#diff-1ee99432f0206c9da5686514ac4b941aedb70f75a75539488ed0e2aeb01071e3">+142/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>usersOrg.spec.js</strong><dd><code>Skip outdated organization tests</code> </dd></summary> <hr> tests/ui-testing/playwright-tests/usersOrg.spec.js <li>Convert organization tests to test.skip<br> <li> Disable Add Org and related scenarios </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7151/files#diff-01a0201901f4022cf6708a20432f8a70bc20ac5ccdb9943fd5a6b41eaf0e550b">+4/-4</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> --------- Co-authored-by: Shyam Panjiyar <shyam@openobserve.ai> |
||
 Neha P
|
3ff97016cf |
test: e2e-stream-name (#6764)
Added a test to add stream name and assert if stream with uppercase exists add a stream with lowercase and assert if stream name with lowercase exists |