- Pending renames stay queued until their tuples move; every tuple on
the old name, ownership and role grants, moves in one write that
reports failure, and a failed one is retried on the next boot.
- A Custom email subject is plain text, so "API & worker" no longer
reads "API & worker" for synthetics, downtime and on-call.
- The Content path substitutes in one pass over the authored tokens,
so no inserted value is scanned again.
- The on-call and incident samples carry the chosen severity as their
priority, and the incident sample reads its severity as its level.
- inferAppliesTo reads {name:30} and {name|modifier} tokens.
- Migrations treat only o2_default_content as a seed, so a user row
named o2_default moves to user_o2_default with its body and
references; the boot rename still leaves the seeder's row alone.
- Migrations 137 and 143 record their renames, and boot moves the
OpenFGA ownership tuples for them, then clears the list.
- A renamed name is cut to fit the 256-character column.
- Migration 144 turns a json templates column from an earlier build
of 141 or 142 into text on Postgres.
- A downtime Send test goes through the new
POST /v2/{org}/downtimes/{id}/test, which sends the started message
through the live path to the row's own destinations, so it reads
exactly what a real start sends.
- The Content path no longer rescans inserted values for the new
tokens, and a literal kind token in a value survives.
- The Playground severity also sets the example's level text.
- The override picker reloads after Create template opens a new tab,
and an imported template keeps its kind and applies_to.
The anomaly link opens the detector's detail page on its detection tab,
the synthetics link uses the synthetics route that exists, and the
downtime link opens the downtime itself instead of the list.
- Main seeded only o2_default_content, so a default org row named like
another kind default is a user row: migration 137 renames it and 143
leaves it alone. Tests cover the rename and the fold.
- The templates columns of downtime_notifications and
oncall_response_events are text, not json.
- Custom templates replace the new tokens first, so an inserted value
is never scanned for them.
- A reserved rename moves the OpenFGA ownership tuples, and a rename
in an org skips a name the default org holds.
- An incident card reads the incident severity as its level, and
Warning or degraded gets the orange dot before the notice rule.
- A saved template opens Applies to in manual mode, and the draft keeps
the list and the mode.
- The downtime Send test always renders on the server.
Retiring prebuilt_downtime moved generic webhook downtime sends to the
o2_default envelope, which nests downtime_name under context. Downtime
now has a legacy payload like anomaly, synthetics and on-call, so a
generic webhook keeps {"text", "downtime": {...}}. The content
templates Playwright spec reads the top-level Slack blocks.
Amendment A to the unified notification templates design.
- D2: remove the org default level. The Default templates card, the
default_templates setting and its validation, the legacy pointer
backfill and the incident org override are gone. Resolution is the
override, then the destination's template if it applies, then the
compiled default. Stored template_source rows that say org_default
still read.
- D3: one compiled content template, o2_default, for every kind, with
the 17-field superset. A field whose variables are all blank hides,
and another kind's variable reads blank instead of unknown. Each
module maps its values onto the common keys. Migration 143 folds the
five o2_default_* rows and the prebuilt_downtime pair into
o2_default, moves their references and deletes the org pointer
settings. The seeder repeats it on boot.
- D1: new status_dot, alert_level_label and alert_trigger_time_utc
variables. Slack blocks sit at the top level with no attachment
color. Teams, Discord and email lose their accent color and badge.
- D4 to D6: Playground heading and help line. The playground Kind
drives the variable chips and guide. A template opens on its first
Applies to kind.
- The downtime Send test renders o2_default on the server.
- The content templates Playwright spec expects the Critical default.
A content template now hides a field whose value is blank on every kind,
alerts included; legacy custom templates are unchanged. The editor preview
and test send start on Critical, so the sample Level is never blank.
notification_kind_label and notification_event_label give the title-case
kind and event (Alert, On-call, Firing). notification_kind and
notification_event stay lowercase because webhook bodies read them.
The compiled defaults keep what each module sent before: synthetics adds
Status, Environments and Time (check_environments, check_checked_at);
incident adds Stream, Threshold, Value and Triggered from the alert card;
on-call uses the engine's subject and page body as title and body, so the
priority no longer shows twice.
The shared on-call sender returns the template name and source it
rendered with. The delivery ledger row stores them in a new nullable
templates column on oncall_response_events (migration 142), and the
Deliveries tab shows a Template line per row. Rows written before the
column stay blank. The downtime log and the ledger share one formatter.
F-01: TemplateOverridePicker takes a context prop. An org default row
shows "Built-in <kind> message" and its own help, with no override
drawer. The drawer copy is kind-neutral for object overrides and names
the destinations the override does not fit.
F-02: the preview response lists empty_variables, the variables the
draft uses that render blank in the previewed kind's sample. The
preview panel shows them as "Empty for <kind>: ...".
F-03: under each override picker, "Will use: <name> (<source>)" follows
the server's order: override, destination template if it applies, org
default, built-in. The downtime notification log records the template
name and source per destination (migration 141) and shows a Template
column.
F-04: the template list has an Applies to column, an Applies to filter,
and a dismissable notice that counts user templates stored as every
kind, with a Review action that filters to them.
F-05: the alert edit page loads the org templates, so the Advanced tab
override select has options.
build_notification_context and the alert sample never set event, so a
recovered alert rendered {notification_event} as firing next to
alert_status=resolved. Both now follow resolved. Also moves the
saveCustomDestination comment back above its function.
- Preview as Downtime renders a downtime sample (started, or ended
for the resolved preview) instead of the alert sample, with a golden
fixture beside the other kinds.
- A downtime start sends event Firing and an end or cancel Resolved,
matching alert_status. Ending soon and extended stay Informational.
Platforms still skip every downtime event.
- A reopened template stored as all kinds, whose body infers no kind,
opens in the inferred mode instead of Chosen by you.
A user row under o2_default_ in the default org is shared, so the
migration moves every org's references to its new name. If another
org already owned that name, its local row won the read and the
inherited reference changed body on upgrade. The replacement name
for a default org row must now be free in every org.
- Destination skip names not_applicable for a user template whose
applies_to excludes the kind; reserved rows keep "reserved".
- o2_default_* rows are read only for every caller, root included.
The seeder writes them directly, so it still re-creates a missing row.
- Synthetics alert_description no longer wraps the error in a code
fence. The card's Error field carries the error, so body_markdown
has no escaped backticks.
A platform skip is no longer counted as a delivery, so a test page or a
notice that only reaches PagerDuty, Opsgenie or ServiceNow reports that
nothing was sent. The policy handler checks the template first, writes the
policy, and only then writes and replicates the template override, so a
refused policy leaves no half-applied override. The upgrade line also scans
the team's own channel destinations for email and SNS.
The private location card sets check_type, check_locations_line and an
empty check_error, so no field renders the unknown marker on Slack or
email. A downtime result names each destination (ok, skipped with its
reason, or the error) and fails only on a real error, so a platform skip
no longer logs a warning. slack_publish::send_post lost its last caller and
is deleted. A Slack app destination now gets the compiled card through
send_templated_post instead of the plain text through send_post.
Tests: the run event mapping, the location card render, the downtime
summary, the Slack app route, and email and SNS entries in every example
fixture. The on-call adapter drops an import that only its tests use.
The on-call engine reaches notify() through a registered sender slot. Pages,
escalations, manual escalates and handoffs are Firing with the response id
as the platform key; coverage gap, verdict and test pages are
Informational, so platforms skip them. Email and SNS destinations now get
pages (D9), and a generic webhook keeps today's page JSON (D1). Nothing is
sent on acknowledge or resolve (strict D8, D4). oncall_policies gains a
template column (m20261210_000001) with validation and replication, and a
startup line names the policies whose email or SNS destinations now get
pages.
A location down is sent as Informational with no platform key, so
PagerDuty, Opsgenie and ServiceNow skip it with a logged reason (strict
D8). Every other destination gets the location card, and a generic webhook
keeps today's text body.
D8 is strict: a platform resolve goes out only where a module sends a
recovery today. Incident and on-call Resolved are now a platform skip, and
the incident resolve hook, resolve_platform_destinations and its guard are
removed. Incidents keep the keyed trigger.
Review pass 1: incidents pass "[{event}] {title}" as the subject again,
and the subject rule is a pure function with a matrix test. Alerts set
cluster_name. The rename migration exempts only the exact seeded names, so
a root user's o2_default_foo in the default org is renamed. PlatformNoAck
is removed. The resolve answer mapping and the default_templates miss cache
have tests. A non-alert destination returns Ok(false) from the anomaly
sender again, as before this branch.
Loakesh Indiran
Subhra264
Huaijin
Loakesh Indiran
Omkar Kesarkhaneandgithub-actions[bot]
Vamsi Karthik R
Hengfei Yang
Harsh MahajanandHengfei Yang
Nikith Sai
uddhavdave
Ashish Kolhe
Shrinath Rao
Bhargav